Skip to content

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Nov 30, 2025

Backport of #7005 to cloud/1.33

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…n cloud (#7005)

Fixes issue on cloud where the Loader node dropdowns showed placeholder
values (after refresh) in the widget UI despite a value being loaded.

Cloud loader dropdowns hydrate via `useAssetWidgetData(nodeType)`, so
`dropdownItems` stays empty until the Asset API returns friendly
filenames. Meanwhile `modelValue` already holds the saved asset and the
watcher only tracks `modelValue`:
https://github.com/Comfy-Org/ComfyUI_frontend/blob/df653d6ce183fde7a67feb81c1a029143e521458/src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue#L215-L226

This watcher runs before assets load, fails to find a match, clears
`selectedSet`, and the placeholder persists:


https://github.com/Comfy-Org/ComfyUI_frontend/blob/df653d6ce183fde7a67feb81c1a029143e521458/src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue#L222-L224

Once the assets API resolves, `dropdownItems` recomputes but nothing
resyncs because the watcher never sees that change. Desktop doesn’t hit
this because it still reads from `widget.options.values` immediately.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7005-fix-loader-node-widget-value-shows-placeholder-instead-of-filename-on-cloud-2b86d73d36508125a16de5c9e366b014)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Nov 30, 2025
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner November 30, 2025 01:13
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Nov 30, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 30, 2025
@github-actions
Copy link

github-actions bot commented Nov 30, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 11/30/2025, 01:24:52 AM UTC

📈 Summary

  • Total Tests: 493
  • Passed: 479 ✅
  • Failed: 0
  • Flaky: 5 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 470 / ❌ 0 / ⚠️ 5 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 11/30/2025, 01:15:30 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@christian-byrne christian-byrne merged commit 3856e0d into cloud/1.33 Nov 30, 2025
35 of 37 checks passed
@christian-byrne christian-byrne deleted the backport-7005-to-cloud-1.33 branch November 30, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants