Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Dec 1, 2025

Summary

Cherry-picked from d76c59c

┆Issue is synchronized with this Notion page by Unito

Temporarily simplifies the resize logic to only work on bottom right
corner and eliminates edge cases where corner resizing caused position
drift issues.

- Remove multi-corner resize handles in favor of bottom-right only
- Delete resizeMath.ts and its tests (no longer needed)
- Simplify useNodeResize to only handle bottom-right resize
- Remove position tracking from resize callback

---------

Co-authored-by: github-actions <[email protected]>
@christian-byrne christian-byrne requested a review from a team as a code owner December 1, 2025 03:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/cloud-1.33-resize-simplify

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/01/2025, 03:25:24 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/01/2025, 03:34:23 AM UTC

📈 Summary

  • Total Tests: 493
  • Passed: 479 ✅
  • Failed: 2 ❌
  • Flaky: 3 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 470 / ❌ 2 / ⚠️ 3 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 1, 2025
@christian-byrne christian-byrne changed the title [refactor] Backport: Simplify Vue node resize to bottom-right corner only (#7063) [backport cloud/1.33] Simplify Vue node resize to bottom-right corner only (#7063) Dec 1, 2025
@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 1, 2025
@christian-byrne christian-byrne merged commit ffa55cb into cloud/1.33 Dec 1, 2025
3 checks passed
@christian-byrne christian-byrne deleted the backport/cloud-1.33-resize-simplify branch December 1, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants