Skip to content

Reactive widget.value and node.inputs in vue #7095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AustinMroz wants to merge 11 commits into from
Closed

Reactive widget.value and node.inputs in vue #7095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3eece91
Wip control widget state migration
AustinMroz Nov 27, 2025
47650be
Migrate vue widget data to use refs
AustinMroz Dec 2, 2025
a50eb8d
End duck violence
AustinMroz Dec 2, 2025
9483201
Make vue inputs reactive
AustinMroz Dec 2, 2025
a07097e
Fix unit tests
AustinMroz Dec 2, 2025
090ee7a
Fix node previews
AustinMroz Dec 2, 2025
1c75a49
Add control button to vue combo widget
AustinMroz Dec 3, 2025
c4efedf
Fix ColorPicker, further test cleanup
AustinMroz Dec 3, 2025
48962a4
Remove unused code
AustinMroz Dec 11, 2025
87c3ba6
Fix unused export
AustinMroz Dec 11, 2025
574a3c2
[automated] Apply ESLint and Prettier fixes
actions-user Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
End duck violence 
I would prefer that valueRef used the TValue generic, but that causes
many, many awful errors. This is far preferable
  • Loading branch information
@AustinMroz
AustinMroz committed Dec 13, 2025
commit a50eb8dd57f89d195e4686ad3570d6f1be303911
6 changes: 1 addition & 5 deletions src/composables/graph/useGraphNodeManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ export function safeWidgetMapper(
) {
widget.value = widget.options.values[0]
}
//@ts-expect-error duck violence
if (!widget.valueRef) {
const valueRef = ref(widget.value)
watch(valueRef, (newValue) => {
Expand All @@ -128,10 +127,8 @@ export function safeWidgetMapper(
})
widget.callback = useChainCallback(widget.callback, () => {
if (valueRef.value !== widget.value)
//@ts-expect-error duck violence
valueRef.value = validateWidgetValue(widget.value)
valueRef.value = validateWidgetValue(widget.value) ?? undefined
})
//@ts-expect-error duck violence
widget.valueRef = () => valueRef
}
const spec = nodeDefStore.getInputSpecForWidget(node, widget.name)
Expand All @@ -145,7 +142,6 @@ export function safeWidgetMapper(
return {
name: widget.name,
type: widget.type,
//@ts-expect-error duck violence
value: widget.valueRef,
borderStyle,
isDOMWidget: isDOMWidget(widget),
Expand Down
3 changes: 3 additions & 0 deletions src/lib/litegraph/src/types/widgets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { Ref } from 'vue'

import type { CanvasColour, Point, RequiredProps, Size } from '../interfaces'
import type { CanvasPointer, LGraphCanvas, LGraphNode } from '../litegraph'
import type { CanvasPointerEvent } from './events'
Expand Down Expand Up @@ -284,6 +286,7 @@ export interface IBaseWidget<
/** Widget type (see {@link TWidgetType}) */
type: TType
value?: TValue
valueRef?: () => Ref<boolean | number | string | object | undefined>
Copy link
Contributor

@DrJKL DrJKL Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be able to get this to work if you use NoInfer


/**
* Whether the widget value should be serialized on node serialization.
Expand Down