Skip to content

feat: add upgrade modal for model upload when private models disabled #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-mino-altherr merged 6 commits into from
Dec 4, 2025
Merged

feat: add upgrade modal for model upload when private models disabled #7124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62bd595
feat: add upgrade modal for model upload when private models disabled
luke-mino-altherr Dec 3, 2025
615a700
feat: extend feature flags to read from remote config
luke-mino-altherr Dec 3, 2025
0f1e4e8
Update src/scripts/api.ts
luke-mino-altherr Dec 3, 2025
9a2f43a
refactor: improve i18n and security in upgrade modal components
luke-mino-altherr Dec 3, 2025
fb16f19
Apply suggestions from code review
luke-mino-altherr Dec 4, 2025
75cabea
code review comments
luke-mino-altherr Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: improve i18n and security in upgrade modal components 
- Use proper i18n keys (g.learnMore, subscription.required.subscribe)
- Add rel="noopener noreferrer" to external link for security
- Remove empty script block from UploadModelUpgradeModalBody

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
@luke-mino-altherr @claude
luke-mino-altherr and claude committed Dec 4, 2025
commit 9a2f43a9735c9cf69f4d13504116614f4e3ea2fb
2 changes: 0 additions & 2 deletions src/platform/assets/components/UploadModelUpgradeModalBody.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@
</p>
</div>
</template>

<script setup lang="ts"></script>
5 changes: 3 additions & 2 deletions src/platform/assets/components/UploadModelUpgradeModalFooter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
<a
href="https://blog.comfy.org/p/comfy-cloud-new-features-and-pricing"
target="_blank"
rel="noopener noreferrer"
class="text-muted-foreground mr-auto underline flex items-center gap-2"
>
<i class="icon-[lucide--external-link]" />
<span>{{ $t('Learn more') }}</span>
<span>{{ $t('g.learnMore') }}</span>
</a>
<TextButton
:label="$t('g.close')"
Expand All @@ -15,7 +16,7 @@
@click="emit('close')"
/>
<TextButton
:label="$t('Subscribe')"
:label="$t('subscription.required.subscribe')"
type="secondary"
size="md"
@click="emit('subscribe')"
Expand Down