Skip to content

fix: reset touch state when iPad Safari loses focus #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtydhr88 merged 2 commits into from
Dec 4, 2025
Merged

fix: reset touch state when iPad Safari loses focus #7134

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5093faa
fix: reset touch state when iPad Safari loses focus
jtydhr88 Dec 3, 2025
a9d30d8
code improve
jtydhr88 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: reset touch state when iPad Safari loses focus
  • Loading branch information
@jtydhr88
jtydhr88 committed Dec 3, 2025
commit 5093faa05bc6d0a93ed2a4552210c0fc209c7c73
23 changes: 23 additions & 0 deletions src/extensions/core/simpleTouchSupport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,29 @@ app.registerExtension({
}
)

// Reset touch state when page loses visibility (e.g., switching apps on iPad)
// This prevents touchCount from getting stuck when touchend events are missed
document.addEventListener('visibilitychange', () => {
if (document.hidden) {
touchCount = 0
touchZooming = false
touchTime = null
lastTouch = null
lastScale = null
touchDist = null
}
})

// Also handle touchcancel which fires when touch is interrupted
app.canvasEl.parentElement?.addEventListener('touchcancel', () => {
touchCount = 0
touchZooming = false
touchTime = null
lastTouch = null
lastScale = null
touchDist = null
Copy link
Contributor

@DrJKL DrJKL Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we require the same cleanup, can we extract a method to make sure they stay in sync?

Also, not for this PR, but we might want to find a way to make sure we're cleaning up all the listeners we're adding. It's been a source of memory leaks.

})

app.canvasEl.parentElement?.addEventListener(
'touchmove',
(e) => {
Expand Down