Skip to content

On adding output matchType, initialize type #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 2 commits into from
Dec 4, 2025
Merged

On adding output matchType, initialize type #7161

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c0d47f
On adding output matchType, initialize type
AustinMroz Dec 4, 2025
3136df4
Add nit comment
AustinMroz Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
On adding output matchType, initialize type 
The output type of a matchType output is initialized to
COMFY_MATCHTYPE_V3, but is updated soon after to the value calculated
from input types, under some difficult to reproduce circumstances, this
output type may be incorrectly evaluated in connections to other switch
nodes. Since the initial type is never a valid connection, this can
produce errors.

Instead, the output type of a matchtype node is initialized to allow
connections to anything to ensure that the subsequent restriction of
output types is guaranteed to be directional
  • Loading branch information
@AustinMroz
AustinMroz committed Dec 4, 2025
commit 2c0d47fca5573b35ac7e4cece8efb9a3afb0ab33
3 changes: 2 additions & 1 deletion src/services/litegraphService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ export const useLitegraphService = () => {
*/
function addOutputs(node: LGraphNode, outputs: OutputSpec[]) {
for (const output of outputs) {
const { name, type, is_list } = output
const { name, is_list } = output
const type = output.type === 'COMFY_MATCHTYPE_V3' ? '*' : output.type
const shapeOptions = is_list ? { shape: LiteGraph.GRID_SHAPE } : {}
const nameKey = `${nodeKey(node)}.outputs.${output.index}.name`
const typeKey = `dataTypes.${normalizeI18nKey(type)}`
Expand Down