Skip to content

[feat] Add video help dialog to Upload Model flow #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-mino-altherr merged 6 commits into from
Dec 6, 2025
Merged

[feat] Add video help dialog to Upload Model flow #7177

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62daaaa
[feat] Add video help dialog to Upload Model flow
luke-mino-altherr Dec 5, 2025
77bb2f9
[feat] Add accessibility and robustness improvements to VideoHelpDialog
luke-mino-altherr Dec 5, 2025
c724c4c
[feat] Move upload model help button text to i18n
luke-mino-altherr Dec 5, 2025
a715b3d
[feat] Refactor VideoHelpDialog and UploadModelFooter components
luke-mino-altherr Dec 5, 2025
a8a7015
[feat] Improve VideoHelpDialog cleanup using onWatcherCleanup
luke-mino-altherr Dec 5, 2025
d2abe3b
Merge branch 'main' into feat/video-help-dialog-upload-model
luke-mino-altherr Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[feat] Improve VideoHelpDialog cleanup using onWatcherCleanup 
Use Vue 3.5+ onWatcherCleanup() for automatic event listener cleanup instead of relying on VueUse's internal cleanup. This provides more explicit control and follows Vue 3.5+ best practices.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
  • Loading branch information
@luke-mino-altherr @claude
luke-mino-altherr and claude committed Dec 5, 2025
commit a8a7015949e56672945237a525faa6e46dd72f0e
9 changes: 6 additions & 3 deletions src/platform/assets/components/VideoHelpDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<script setup lang="ts">
import { useEventListener } from '@vueuse/core'
import Dialog from 'primevue/dialog'
import { watch } from 'vue'
import { onWatcherCleanup, watch } from 'vue'

import IconButton from '@/components/button/IconButton.vue'

Expand All @@ -50,7 +50,7 @@ const { videoUrl, ariaLabel = 'Help video' } = defineProps<{
}>()

const handleEscapeKey = (event: KeyboardEvent) => {
if (event.key === 'Escape' && isVisible.value) {
if (event.key === 'Escape') {
event.stopImmediatePropagation()
event.stopPropagation()
event.preventDefault()
Expand All @@ -64,7 +64,10 @@ watch(
isVisible,
(visible) => {
if (visible) {
useEventListener(document, 'keydown', handleEscapeKey, { capture: true })
const stop = useEventListener(document, 'keydown', handleEscapeKey, {
capture: true
})
onWatcherCleanup(stop)
}
},
{ immediate: true }
Expand Down