Style: Font Consistency #7220
Merged
Style: Font Consistency #7220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning Rate limit exceeded@DrJKL has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 46 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (197)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughStandardizes typography by replacing or removing explicit font-family declarations (Arial, Tahoma, Satoshi, Roboto) and adopting Inter across CSS, Vue components, LiteGraph rendering constants, canvas text drawing, and test setup. Changes
Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/09/2025, 01:30:22 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 12/09/2025, 01:38:49 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.21 MB (baseline 3.21 MB) • 🔴 +36 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 978 kB (baseline 978 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 177 kB (baseline 177 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 BBundles that do not match a named category
Status: 17 added / 17 removed |
DrJKL
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
dosubot
bot
added
the
size:XS
benceruleanlu
requested changes
Dec 8, 2025
Member
benceruleanlu
left a comment
benceruleanlu
left a comment
There was a problem hiding this comment.
this breaks the readability of tab titles and flips some things into light theme counterparts, can we fix this? if its an underlying issue we can postpone this change perhaps.
DrJKL
force-pushed
the
drjkl/consistency-is-inter
branch
from
fd2ab84 to
d2ebe0f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/design-system/src/css/style.css (1)
20-20: Use the defined--font-interCSS variable in the body rule for consistency.The
--font-intercustom property is defined on line 20 but not used in the body rule (line 569). The font stacks differ:--font-interspecifies'Inter', sans-serif, while body hardcodesInter, Arial, sans-serif. This creates inconsistency and defeats the purpose of defining a reusable design token.Apply this fix to align the body rule with the CSS variable:
body { width: 100vw; height: 100vh; margin: 0; overflow: hidden; background: var(--bg-color) var(--bg-img); color: var(--fg-color); min-height: -webkit-fill-available; max-height: -webkit-fill-available; min-width: -webkit-fill-available; max-width: -webkit-fill-available; - font-family: Inter, Arial, sans-serif; + font-family: var(--font-inter); }Alternatively, if Arial is intentionally part of the fallback chain, update the
--font-intervariable on line 20 to match:- --font-inter: 'Inter', sans-serif; + --font-inter: 'Inter', Arial, sans-serif;Then use
var(--font-inter)in the body rule.Also applies to: 569-569
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (197)
browser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-light-red-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-obsidian-dark-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-obsidian-dark-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/default-color-palette-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-lightened-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-2-arc-theme-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-3-color-changed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-3-color-removed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-5-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-with-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/copied-widget-value-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/drag-copy-copied-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/no-node-copied-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/paste-in-text-area-with-node-previously-copied-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/domWidget.spec.ts-snapshots/focus-mode-on-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/graphCanvasMenu.spec.ts-snapshots/canvas-with-hidden-links-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/graphCanvasMenu.spec.ts-snapshots/canvas-with-visible-links-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/adjusted-widget-value-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/batch-disconnect-links-disconnected-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/batch-move-links-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/batch-move-links-moved-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/default-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/default-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/deleted-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/disconnected-edge-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/dragged-node1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/dragging-link1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/dragging-link2-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/group-fit-to-contents-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/group-selected-nodes-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/group-title-edited-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-alt-shift-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-click-node-select-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-left-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-middle-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/moved-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/node-title-edited-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-bypassed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-unbypassed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-unpinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-back-from-far-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-back-to-one-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-back-to-two-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-far-away-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-step-one-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-step-two-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panning-when-dragging-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/pinned-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-closed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-closed-text-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-opened-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-opened-text-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node1-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node2-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node2-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-fit-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-modified-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/snap-to-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/snap-to-slot-linked-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/snapped-highlighted-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-click-node-select-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-initial-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-left-drag-select-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-middle-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-shift-wheel-pan-center-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-shift-wheel-pan-left-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-shift-wheel-pan-right-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-space-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/string-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/string-node-id-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/text-encode-toggled-back-open-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/text-encode-toggled-off-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/unpinned-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-back-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-default-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-high-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-low-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-high-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-low-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-very-far-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/dropped-workflow-url-hidream-dev-example-png-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/edited-workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/large-workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/no-workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-m4v-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mov-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mp4-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-svg-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webm-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/lodThreshold.spec.ts-snapshots/lod-comparison-high-quality-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/lodThreshold.spec.ts-snapshots/lod-comparison-low-quality-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Hide-built-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-None-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Show-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-left-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-light-color-palette-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-multiple-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-unknown-color-palette-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/default-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/dynamically-added-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/force-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/missing-nodes-converted-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/optional-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-no-connection-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-batch-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-context-menu-search-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-release-context-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/noteNode.spec.ts-snapshots/note-nodes-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-connected-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-connected-dom-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/static-primitive-connected-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/recordAudio.spec.ts-snapshots/record-audio-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-0-5x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-context-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-delete-from-midpoint-context-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/reroute-inserted-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/add-group-group-added-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/add-node-node-added-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/node-pinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-bypassed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-collapsed-badge-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-collapsed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-group-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-pinned-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-unpinned-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-unpinned-node-moved-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-2-nodes-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-nodes-pinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-nodes-unpinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-single-node-no-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-single-selection-no-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/templates.spec.ts-snapshots/template-grid-varying-content-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-fit-to-contents-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-ctrl-alt-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-reuses-origin-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-input-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-output-shift-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.ts-snapshots/vue-nodes-upload-widgets-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/boolean-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/boolean-widget-toggled-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/empty-latent-resized-80-percent-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/image-preview-changed-by-combo-value-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/image-preview-drag-and-dropped-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/ksampler-resized-min-width-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/ksampler-widget-added-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/load-audio-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/load-checkpoint-resized-min-width-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/load-image-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/resized-to-original-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/seed-widget-dragged-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/slider-widget-dragged-chromium-linux.pngis excluded by!**/*.pngtests-ui/tests/litegraph/core/__snapshots__/litegraph.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (12)
packages/design-system/src/css/style.css(1 hunks)src/components/graph/NodeTooltip.vue(0 hunks)src/components/node/NodePreview.vue(0 hunks)src/components/sidebar/tabs/modelLibrary/ModelPreview.vue(0 hunks)src/extensions/core/groupNodeManage.css(0 hunks)src/lib/litegraph/public/css/litegraph.css(0 hunks)src/lib/litegraph/src/LiteGraphGlobal.ts(1 hunks)src/lib/litegraph/src/canvas/InputIndicators.ts(1 hunks)src/lib/litegraph/src/subgraph/SubgraphIONodeBase.ts(1 hunks)src/main.ts(1 hunks)src/platform/updates/components/ReleaseNotificationToast.vue(0 hunks)src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts(1 hunks)
💤 Files with no reviewable changes (6)
- src/extensions/core/groupNodeManage.css
- src/components/graph/NodeTooltip.vue
- src/platform/updates/components/ReleaseNotificationToast.vue
- src/lib/litegraph/public/css/litegraph.css
- src/components/sidebar/tabs/modelLibrary/ModelPreview.vue
- src/components/node/NodePreview.vue
🧰 Additional context used
📓 Path-based instructions (12)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/main.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/main.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/main.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/main.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript exclusively; no new JavaScript code
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/main.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,vue}: Use camelCase for variable and function names
Indent with 2 spaces (see.prettierrc)
Use single quotes for strings (see.prettierrc)
No trailing semicolons (see.prettierrc)
Maximum line width of 80 characters (see.prettierrc)
Sort and group imports by plugin (runpnpm formatbefore committing)
Never useanytype; use proper TypeScript types instead
Never useas anytype assertions; fix the underlying type issue instead
Avoid code comments unless absolutely necessary; write expressive, self-documenting code instead
When writing new code, ask if there is a simpler way to introduce the same functionality; if yes, choose the simpler approach
Use refactoring to make complex code simpler
Use es-toolkit for utility functions
Use Vite for fast development and building
Implement proper error handling
Write tests for all changes, especially bug fixes to catch future regressions
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/main.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
**/composables/**/use*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name composables with
useXyz.tspattern
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
src/lib/litegraph/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
src/lib/litegraph/**/*.{js,ts,jsx,tsx}: Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using thepnpm lint:fixcommand
Take advantage ofTypedArraysubarraywhen appropriate
Thesizeandposproperties ofRectangleshare the same array buffer (subarray); they may be used to set the rectangle's size and position
Prefer single lineifsyntax over adding curly braces, when the statement has a very concise expression and concise, single line statement
Do not replace&&=or||=with=when there is no reason to do so. If you do find a reason to remove either&&=or||=, leave a comment explaining why the removal occurred
When writing methods, prefer returning idiomatic JavaScriptundefinedovernull
Files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/lib/litegraph/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
🧠 Learnings (16)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T00:52:35.750Z
Learning: Applies to **/*.vue : Avoid new usage of PrimeVue components
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T00:52:35.750Z
Learning: Applies to **/*.vue : Never use the `dark:` Tailwind variant; use semantic values from the `style.css` theme instead (e.g., `bg-node-component-surface`)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T00:52:35.750Z
Learning: Applies to **/*.vue : Leverage VueUse functions for performance-enhancing styles
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup
Applied to files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : When writing tests for subgraph-related code, always import from the barrel export at `@/lib/litegraph/src/litegraph` to avoid circular dependency issues
Applied to files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Take advantage of `TypedArray` `subarray` when appropriate
Applied to files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.ts
📚 Learning: 2025-12-06T00:52:35.750Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T00:52:35.750Z
Learning: Applies to **/*.vue : Never use the `dark:` Tailwind variant; use semantic values from the `style.css` theme instead (e.g., `bg-node-component-surface`)
Applied to files:
src/main.ts
📚 Learning: 2025-12-06T00:52:35.750Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-06T00:52:35.750Z
Learning: Applies to **/*.vue : Avoid new usage of PrimeVue components
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/main.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{ts,tsx} : Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Applied to files:
src/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred
Applied to files:
src/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Applied to files:
packages/design-system/src/css/style.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (2)
src/main.ts (1)
68-79: The removal ofdarkModeSelectorfrom the PrimeVue theme configuration is an intentional change to rely on the Aura preset's built-in dark mode handling rather than an explicit selector. ComfyUIPreset extends Aura, which manages dark mode detection internally. No code in the application references the removed configuration option, so this change is safe.src/lib/litegraph/src/LiteGraphGlobal.ts (1)
62-62: Inter font is properly defined and loaded.The Inter font is correctly configured with
@font-facedeclarations inpackages/design-system/src/css/fonts.css, with font files available at/fonts/inter-latin-normal.woff2and/fonts/inter-latin-italic.woff2. The design system CSS is imported before LiteGraph initialization insrc/main.ts, and the font-display: swap strategy ensures text renders immediately with a fallback while the Inter font loads asynchronously. No action required; the current implementation is sound.
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
Outdated
Show resolved
Hide resolved
DrJKL
force-pushed
the
drjkl/consistency-is-inter
branch
from
d2ebe0f to
b702361
Compare
dosubot
bot
added
size:M
DrJKL
added
the
New Browser Test Expectations
Contributor
Author
This should be fixed now 🤞🏻 |
github-actions
bot
removed
the
New Browser Test Expectations
dosubot
bot
added
size:S
benceruleanlu
previously approved these changes
Dec 8, 2025
Member
benceruleanlu
left a comment
benceruleanlu
left a comment
There was a problem hiding this comment.
should we wait for this to go on 1.35?
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
Author
We can brand it as a Polish release :-D |
DrJKL
added
the
New Browser Test Expectations
DrJKL
force-pushed
the
drjkl/consistency-is-inter
branch
from
8871ea6 to
ec5db87
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/design-system/src/css/style.css (1)
556-571: Global body font now aligned with Inter
font-family: Inter, Arial, sans-serif;makes Inter the primary UI font with reasonable fallbacks and matches the PR’s goal of font unification. No issues from a styling or UX standpoint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (177)
browser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-light-red-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-obsidian-dark-all-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/custom-color-palette-obsidian-dark-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/default-color-palette-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-lightened-colors-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-2-arc-theme-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-3-color-changed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-3-color-removed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-5-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-with-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/copied-widget-value-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/drag-copy-copied-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/no-node-copied-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/copyPaste.spec.ts-snapshots/paste-in-text-area-with-node-previously-copied-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/domWidget.spec.ts-snapshots/focus-mode-on-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/graphCanvasMenu.spec.ts-snapshots/canvas-with-hidden-links-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/graphCanvasMenu.spec.ts-snapshots/canvas-with-visible-links-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/adjusted-widget-value-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/batch-disconnect-links-disconnected-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/batch-move-links-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/batch-move-links-moved-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/default-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/default-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/deleted-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/disconnected-edge-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/dragged-node1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/dragging-link1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/dragging-link2-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/group-fit-to-contents-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/group-selected-nodes-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/group-title-edited-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-alt-shift-drag-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-click-node-select-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-left-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-middle-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/moved-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/node-title-edited-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-bypassed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-unbypassed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/nodes-unpinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-back-from-far-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-back-to-one-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-back-to-two-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-far-away-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-step-one-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-step-two-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panned-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/panning-when-dragging-link-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/pinned-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-closed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-closed-text-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-opened-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/prompt-dialog-opened-text-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node1-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node1-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node2-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/selected-node2-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-fit-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/single-ksampler-modified-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/snap-to-slot-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/snap-to-slot-linked-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/snapped-highlighted-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-click-node-select-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-initial-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-left-drag-select-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-middle-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-shift-wheel-pan-center-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-shift-wheel-pan-left-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-shift-wheel-pan-right-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/standard-space-drag-pan-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/string-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/string-node-id-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/text-encode-toggled-back-open-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/text-encode-toggled-off-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/unpinned-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-back-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-default-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-high-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-low-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-ctrl-shift-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-high-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-low-zoom-speed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/interaction.spec.ts-snapshots/zoomed-very-far-out-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/dropped-workflow-url-hidream-dev-example-png-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/edited-workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/large-workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/no-workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-m4v-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mov-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mp4-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-svg-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webm-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webp-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/lodThreshold.spec.ts-snapshots/lod-comparison-high-quality-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/lodThreshold.spec.ts-snapshots/lod-comparison-low-quality-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Hide-built-in-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-None-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Show-all-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-left-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-light-color-palette-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-multiple-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-unknown-color-palette-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/default-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/dynamically-added-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/force-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/missing-nodes-converted-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/optional-input-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-no-connection-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-batch-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-context-menu-search-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/nodeSearchBox.spec.ts-snapshots/link-release-context-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/noteNode.spec.ts-snapshots/note-nodes-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-connected-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-connected-dom-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/primitiveNode.spec.ts-snapshots/static-primitive-connected-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/recordAudio.spec.ts-snapshots/record-audio-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-0-5x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-2x-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-context-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-delete-from-midpoint-context-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rerouteNode.spec.ts-snapshots/reroute-inserted-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/add-group-group-added-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/add-node-node-added-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/node-pinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-menu-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-bypassed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-collapsed-badge-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-collapsed-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-group-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-pinned-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-unpinned-node-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/right-click-unpinned-node-moved-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-2-nodes-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-nodes-pinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/rightClickMenu.spec.ts-snapshots/selected-nodes-unpinned-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-single-node-no-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-single-selection-no-border-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/templates.spec.ts-snapshots/template-grid-varying-content-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/boolean-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/boolean-widget-toggled-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/empty-latent-resized-80-percent-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/image-preview-changed-by-combo-value-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/image-preview-drag-and-dropped-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/ksampler-resized-min-width-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/ksampler-widget-added-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/load-audio-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/load-checkpoint-resized-min-width-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/load-image-widget-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/resized-to-original-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/seed-widget-dragged-chromium-linux.pngis excluded by!**/*.pngbrowser_tests/tests/widget.spec.ts-snapshots/slider-widget-dragged-chromium-linux.pngis excluded by!**/*.pngtests-ui/tests/litegraph/core/__snapshots__/litegraph.test.ts.snapis excluded by!**/*.snap
📒 Files selected for processing (12)
browser_tests/fixtures/ComfyPage.ts(0 hunks)packages/design-system/src/css/style.css(1 hunks)src/components/graph/NodeTooltip.vue(0 hunks)src/components/node/NodePreview.vue(0 hunks)src/components/sidebar/tabs/modelLibrary/ModelPreview.vue(0 hunks)src/extensions/core/groupNodeManage.css(0 hunks)src/lib/litegraph/public/css/litegraph.css(0 hunks)src/lib/litegraph/src/LiteGraphGlobal.ts(1 hunks)src/lib/litegraph/src/canvas/InputIndicators.ts(1 hunks)src/lib/litegraph/src/subgraph/SubgraphIONodeBase.ts(1 hunks)src/platform/updates/components/ReleaseNotificationToast.vue(0 hunks)src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts(1 hunks)
💤 Files with no reviewable changes (7)
- src/extensions/core/groupNodeManage.css
- src/components/node/NodePreview.vue
- browser_tests/fixtures/ComfyPage.ts
- src/components/graph/NodeTooltip.vue
- src/lib/litegraph/public/css/litegraph.css
- src/platform/updates/components/ReleaseNotificationToast.vue
- src/components/sidebar/tabs/modelLibrary/ModelPreview.vue
🧰 Additional context used
📓 Path-based instructions (12)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript exclusively; no new JavaScript code
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
**/*.{ts,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,vue}: Use camelCase for variable and function names
Indent with 2 spaces (see.prettierrc)
Use single quotes for strings (see.prettierrc)
No trailing semicolons (see.prettierrc)
Maximum line width of 80 characters (see.prettierrc)
Sort and group imports by plugin (runpnpm formatbefore committing)
Never useanytype; use proper TypeScript types instead
Never useas anytype assertions; fix the underlying type issue instead
Avoid code comments unless absolutely necessary; write expressive, self-documenting code instead
When writing new code, ask if there is a simpler way to introduce the same functionality; if yes, choose the simpler approach
Use refactoring to make complex code simpler
Use es-toolkit for utility functions
Use Vite for fast development and building
Implement proper error handling
Write tests for all changes, especially bug fixes to catch future regressions
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
**/composables/**/use*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name composables with
useXyz.tspattern
Files:
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts
src/lib/litegraph/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
src/lib/litegraph/**/*.{js,ts,jsx,tsx}: Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using thepnpm lint:fixcommand
Take advantage ofTypedArraysubarraywhen appropriate
Thesizeandposproperties ofRectangleshare the same array buffer (subarray); they may be used to set the rectangle's size and position
Prefer single lineifsyntax over adding curly braces, when the statement has a very concise expression and concise, single line statement
Do not replace&&=or||=with=when there is no reason to do so. If you do find a reason to remove either&&=or||=, leave a comment explaining why the removal occurred
When writing methods, prefer returning idiomatic JavaScriptundefinedovernull
Files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/lib/litegraph/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/canvas/InputIndicators.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
🧠 Learnings (7)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup
Applied to files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Take advantage of `TypedArray` `subarray` when appropriate
Applied to files:
src/lib/litegraph/src/subgraph/SubgraphIONodeBase.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Applied to files:
packages/design-system/src/css/style.css
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{ts,tsx} : Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Applied to files:
src/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred
Applied to files:
src/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : When writing tests for subgraph-related code, always import from the barrel export at `@/lib/litegraph/src/litegraph` to avoid circular dependency issues
Applied to files:
src/lib/litegraph/src/LiteGraphGlobal.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: collect
🔇 Additional comments (3)
src/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.ts (1)
182-219: Canvas button font update looks goodUsing
ctx.font = '12px Inter, sans-serif'gives a consistent UI font and adds a sane fallback for when Inter isn’t available. No behavioral issues here.src/lib/litegraph/src/canvas/InputIndicators.ts (1)
22-32: Input indicator font stack is consistent and resilient
fontString = 'bold 12px Inter, sans-serif'standardizes on Inter while providing a sensible fallback; this is safe and matches the rest of the typography work.src/lib/litegraph/src/subgraph/SubgraphIONodeBase.ts (1)
345-362: Subgraph slot label font change is safe and consistent
ctx.font = '12px Inter, sans-serif'brings subgraph slot labels in line with the new Inter-based typography and adds an appropriate fallback; nothing else indrawSlotsis affected.
DrJKL
force-pushed
the
drjkl/consistency-is-inter
branch
from
ec5db87 to
c3b0135
Compare
DrJKL
added
New Browser Test Expectations
github-actions
bot
removed
the
New Browser Test Expectations
style: More Inter replacing Arial Remove special fonts for tests
…reviewWidget.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
DrJKL
force-pushed
the
drjkl/consistency-is-inter
branch
from
b1f64a6 to
b7d26e9
Compare
christian-byrne
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce lower level font definitions in most places. Default to Inter.
See #6912
Review Focus
Comic Sans is still an option...
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito