Skip to content

When moving subgraphInput link, properly disconnect old link #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 3 commits into from
Dec 8, 2025
+59 −9
Merged

When moving subgraphInput link, properly disconnect old link #7229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
438d0fc
Fix disconnection of moved input links
AustinMroz Dec 8, 2025
500b0ce
Add test. Remove unneeded skips
AustinMroz Dec 8, 2025
6d705ef
Don't track connection changes during init
AustinMroz Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix disconnection of moved input links
  • Loading branch information
@AustinMroz
AustinMroz committed Dec 8, 2025
commit 438d0fc222a83e15f993da0c80770dd504a265a7
3 changes: 3 additions & 0 deletions src/lib/litegraph/src/canvas/ToInputFromIoNodeLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ export class ToInputFromIoNodeLink implements RenderLink {

if (existingLink) {
// Moving an existing link
const { input, inputNode } = existingLink.resolve(this.network)
if (inputNode && input)
this.node._disconnectNodeInput(inputNode, input, existingLink)
events.dispatch('input-moved', this)
} else {
// Creating a new link
Expand Down