-
Notifications
You must be signed in to change notification settings - Fork 448
fix: Refresh model dropdowns after upload #7232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c45ffef
fix: Refresh model dropdowns after upload
luke-mino-altherr b45f179
refactor: Use Pinia store instead of window events for model refresh
luke-mino-altherr 970e87c
refactor: Move cache refresh logic to caller
luke-mino-altherr 8598741
Merge branch 'main' into fix/model-dropdown-refresh-after-upload
DrJKL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: Use Pinia store instead of window events for model refresh
Replaced window event-based cache invalidation with direct Pinia store method calls for better type safety and encapsulation. Changes: - Added refreshModelsByType() to assetsStore to invalidate all node types for a given model category - Upload wizard now calls store method directly instead of dispatching window events - Removed event listener from useAssetWidgetData - no longer needed Benefits: - Better type safety (no CustomEvent casting) - More testable (no global window dependency) - Clearer data flow and dependencies 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Loading branch information
commit b45f1796d9d11d72a83bedd6ad779ef93b1ddfae
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.