Skip to content

fix: Vue Nodes 2.0 slot link drag not working on mobile/touch devices #7233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myestery merged 5 commits into from
Dec 8, 2025
Merged

fix: Vue Nodes 2.0 slot link drag not working on mobile/touch devices #7233

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95c4224
fix: use elementFromPoint for touch event target resolution in Vue nodes
Myestery Dec 8, 2025
f46fbf9
refactor: extract resolvePointerTarget helper for touch event handling
Myestery Dec 8, 2025
91011e5
test: use vi.spyOn for document.elementFromPoint mocking
Myestery Dec 8, 2025
b554fdb
Merge branch 'main' into fix/mobile-touch-slot-link-drag
Myestery Dec 8, 2025
a23ff49
Merge branch 'main' into fix/mobile-touch-slot-link-drag
Myestery Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,11 @@ export function useSlotLinkInteraction({

let hoveredSlotKey: string | null = null
let hoveredNodeId: NodeId | null = null
const target = data.target
// Use elementFromPoint to get the actual element under the pointer.
// On touch devices, event.target stays as the element where touch started
// due to implicit pointer capture, not the element currently under the pointer.
const target =
document.elementFromPoint(data.clientX, data.clientY) ?? data.target
if (target === dragContext.lastPointerEventTarget) {
hoveredSlotKey = dragContext.lastPointerTargetSlotKey
hoveredNodeId = dragContext.lastPointerTargetNodeId
Expand Down Expand Up @@ -501,9 +505,14 @@ export function useSlotLinkInteraction({
? state.candidate
: null

const hasConnected = connectByPriority(canvasEvent.target, snappedCandidate)
// Use elementFromPoint to get the actual element under the pointer.
// On touch devices, event.target stays as the element where touch started.
const dropTarget =
document.elementFromPoint(event.clientX, event.clientY) ??
canvasEvent.target
const hasConnected = connectByPriority(dropTarget, snappedCandidate)

if (!hasConnected && event.target === app.canvas?.canvas) {
if (!hasConnected && dropTarget === app.canvas?.canvas) {
activeAdapter?.dropOnCanvas(canvasEvent)
}

Expand Down
Loading