Skip to content

[backport core/1.33] Fix: Toolbox position desync #7241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 1 commit into from
Dec 8, 2025
Merged

[backport core/1.33] Fix: Toolbox position desync #7241

christian-byrne merged 1 commit into from
Dec 8, 2025

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Dec 8, 2025 •
edited by sync-by-unito bot
Loading

Backport of #6962 to core/1.33

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

@DrJKL @github-actions
Fix: Toolbox position desync (#6962)
5f0cc8b 
## Summary

Toggle the toolbox position check based on visibility, not just when
selection changes.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6962-Fix-Toolbox-position-desync-2b76d73d3650818da327c7adee6c1098)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 8, 2025
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner December 8, 2025 22:46
@comfy-pr-bot comfy-pr-bot mentioned this pull request Dec 8, 2025
Merged
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 12/08/2025, 11:00:27 PM UTC

📈 Summary

  • Total Tests: 495
  • Passed: 482 ✅
  • Failed: 1 ❌
  • Flaky: 3 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 473 / ❌ 1 / ⚠️ 3 / ⏭️ 9
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/08/2025, 10:48:04 PM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@christian-byrne christian-byrne merged commit 0e757b8 into core/1.33 Dec 8, 2025
63 of 67 checks passed
@christian-byrne christian-byrne deleted the backport-6962-to-core-1.33 branch December 9, 2025 02:42
@christian-byrne christian-byrne mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@comfy-pr-bot @christian-byrne @DrJKL