Skip to content

[backport core/1.33] fix: Add fraction digits props to number input widget (backport #7033) #7250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 1 commit into from
Dec 9, 2025
Merged

[backport core/1.33] fix: Add fraction digits props to number input widget (backport #7033) #7250

christian-byrne merged 1 commit into from
Dec 9, 2025

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Dec 8, 2025 •
edited by sync-by-unito bot
Loading

Summary

Backport of #7033 to core/1.33 branch.

  • Adds fraction digits props to number input widget

Conflicts Resolved

  • Screenshot snapshots updated to match the incoming version

Fixes the manual backport requested after auto-backport failed due to binary file conflicts.

┆Issue is synchronized with this Notion page by Unito

@Myestery @christian-byrne
[fix] Add fraction digits props to number input widget (#7033)
39386c4 
Add min-fraction-digits and max-fraction-digits props to InputNumber
component to allow typing decimal values. Without these props, users
could not manually type values like "0.8" even though the increment
buttons worked correctly.

This aligns the input-only variant with the slider variant which
already had these props configured.

fix #7016

https://github.com/user-attachments/assets/fa205023-13c4-45ac-874b-b241808cf56d

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7033-fix-Add-fraction-digits-props-to-number-input-widget-2b96d73d36508124ac65e466802bbb0c)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <[email protected]>
@christian-byrne christian-byrne requested a review from a team as a code owner December 8, 2025 23:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-7033-to-core-1.33

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/08/2025, 11:44:54 PM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 12/08/2025, 11:53:26 PM UTC

📈 Summary

  • Total Tests: 496
  • Passed: 484 ✅
  • Failed: 2 ❌
  • Flaky: 1 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 475 / ❌ 2 / ⚠️ 1 / ⏭️ 9
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne changed the title [fix] Add fraction digits props to number input widget (backport #7033) [backport core/1.33] fix: Add fraction digits props to number input widget (backport #7033) Dec 8, 2025
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 8, 2025
@christian-byrne christian-byrne merged commit 79cdd0c into core/1.33 Dec 9, 2025
31 of 33 checks passed
@christian-byrne christian-byrne deleted the backport-7033-to-core-1.33 branch December 9, 2025 00:12
@christian-byrne christian-byrne mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christian-byrne @Myestery