Remove queue overlay active state and filters #7336

benceruleanlu · 2025-12-11T02:43:45Z

Summary

remove queue progress overlay active view and hover handling
drop queue filters/sorting UI from overlay
simplify job list composable and tests to match removal

main <-- #7336 <-- #7338 <-- #7342

Please do not merge this PR by itself, it is meant to be followed by #7338

┆Issue is synchronized with this Notion page by Unito

coderabbitai · 2025-12-11T02:43:51Z

📝 Walkthrough

Walkthrough

This PR removes queue-related UI components and filtering functionality. It deletes QueueOverlayActive and JobFiltersBar components, simplifies QueueProgressOverlay by eliminating hover tracking and the 'active' state, removes filter/sort type definitions and state from useJobList, and removes menu-hover props from TopMenuSection and QueueProgressOverlay.

Changes

Cohort / File(s)	Summary
Component removals `src/components/queue/QueueOverlayActive.vue`, `src/components/queue/job/JobFiltersBar.vue`, `src/components/queue/QueueOverlayActive.test.ts`	Deleted QueueOverlayActive component with progress bars and action buttons, JobFiltersBar component with job tabs and filter controls, and associated test suite.
Component simplifications `src/components/TopMenuSection.vue`, `src/components/queue/QueueProgressOverlay.vue`	Removed hover tracking logic (`@mouseenter/`@Mouseleave handlers), hover state (isTopMenuHovered, isHovered), menu-hovered props, and related conditional rendering.
QueueOverlayExpanded refinement `src/components/queue/QueueOverlayExpanded.vue`	Removed JobFiltersBar usage, deleted selectedJobTab, selectedWorkflowFilter, and selectedSortMode props and corresponding update emits.
Composable cleanup `src/composables/queue/useJobList.ts`, `tests-ui/tests/composables/useJobList.test.ts`	Removed exported jobTabs, JobTab, jobSortModes, and JobSortMode types; eliminated workflow and tab-based filtering logic; simplified data derivation; removed related test cases and workflowStore mocking.

Possibly related PRs

cleanup: remove unused queue setting #7353: Removes unused Comfy.Queue.ImageFit setting tied to the Queue feature deletion in this PR.
Fix cloud queue cancel to target specific jobs #7176: Modifies QueueProgressOverlay's cancellation logic (interruptAll flow and isCloud handling) affected by this PR's overlay simplification.
[feat] Improve queue job item UX based on design feedback #6893: Introduced the menu-hover prop and hover-tracking logic that this PR removes from TopMenuSection and QueueProgressOverlay.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch queue-overlay-deletions

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 987dcb1 and f548af2.

📒 Files selected for processing (8)

src/components/TopMenuSection.vue (2 hunks)
src/components/queue/QueueOverlayActive.test.ts (0 hunks)
src/components/queue/QueueOverlayActive.vue (0 hunks)
src/components/queue/QueueOverlayExpanded.vue (1 hunks)
src/components/queue/QueueProgressOverlay.vue (3 hunks)
src/components/queue/job/JobFiltersBar.vue (0 hunks)
src/composables/queue/useJobList.ts (2 hunks)
tests-ui/tests/composables/useJobList.test.ts (1 hunks)

💤 Files with no reviewable changes (3)

src/components/queue/QueueOverlayActive.test.ts
src/components/queue/job/JobFiltersBar.vue
src/components/queue/QueueOverlayActive.vue

🧰 Additional context used

📓 Path-based instructions (17)

tests-ui/**/*.test.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (tests-ui/CLAUDE.md)

tests-ui/**/*.test.{js,ts,jsx,tsx}: Write tests for new features
Follow existing test patterns in the codebase
Use existing test utilities rather than writing custom utilities
Mock external dependencies in tests
Always prefer vitest mock functions over writing verbose manual mocks

Files:

tests-ui/tests/composables/useJobList.test.ts

**/*.{ts,tsx,js,jsx,vue,json}

📄 CodeRabbit inference engine (AGENTS.md)

Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see .prettierrc)

Files:

tests-ui/tests/composables/useJobList.test.ts
src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; run pnpm format before committing
Use TypeScript for type safety; never use any type - use proper TypeScript types
Never use as any type assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nested if or for statements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones

Files:

tests-ui/tests/composables/useJobList.test.ts
src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

**/*.test.ts

📄 CodeRabbit inference engine (AGENTS.md)

**/*.test.ts: Write tests for all changes, especially bug fixes to catch future regressions
Unit/component test files must be named **/*.test.ts or in tests-ui/ directory
Do not write change detector tests that just assert default values
Do not write tests dependent on non-behavioral features like utility classes or styles
Be parsimonious in testing; do not write redundant tests; see composable tests approach
Follow 'Don't Mock What You Don't Own' principle - avoid mocking external dependencies
Do not write tests that just test the mocks; ensure tests fail when code behaves unexpectedly
Leverage Vitest's mocking utilities where possible for test mocking
Keep module mocks contained in test files; do not use global mutable state within test files; use vi.hoisted() if necessary
For Component testing, use Vue Test Utils and follow advice about making components easy to test
Aim for behavioral coverage of critical and new features in unit tests

Files:

tests-ui/tests/composables/useJobList.test.ts

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue component file names must use PascalCase; for example, MenuHamburger.vue

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

**/*.vue

📄 CodeRabbit inference engine (AGENTS.md)

**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use <script setup lang="ts"> for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not use withDefaults or runtime props declaration
Prefer useModel to separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using <style> blocks in Vue components
Use semantic Tailwind values from style.css theme instead of the dark: variant; for example, use bg-node-component-surface instead of dark: prefixes
Always use cn() utility from @/utils/tailwindUtil to merge Tailwind class names; do not use :class="[]" syntax
Use ref for reactive state in Vue Composition API components
Implement computed properties with computed() from Vue; avoid using a ref with a watch if a computed would work instead
Use watch and watchEffect for side effects in Vue components
Implement lifecycle hooks using onMounted, onUpdated, and other Vue lifecycle functions
Use provide/inject for dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundant computed, and prefer computed over watch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries in src/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead

Files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Minimize the surface area (exported values) of each module and composable

Files:

src/composables/queue/useJobList.ts

src/**/{services,composables}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/{services,composables}/**/*.{ts,tsx}: Use api.apiURL() for backend endpoints instead of constructing URLs directly
Use api.fileURL() for static file access instead of constructing URLs directly

Files:

src/composables/queue/useJobList.ts

src/composables/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Composable files must follow the naming pattern useXyz.ts

Files:

src/composables/queue/useJobList.ts

🧠 Learnings (32)

📚 Learning: 2025-11-24T19:47:22.909Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Test user workflows in browser tests

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Use existing test utilities rather than writing custom utilities

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-12-09T20:22:23.620Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.test.ts : Be parsimonious in testing; do not write redundant tests; see composable tests approach

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Write tests for new features

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Follow existing test patterns in the codebase

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-12-09T20:22:23.620Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.test.ts : Write tests for all changes, especially bug fixes to catch future regressions

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-12-09T20:22:23.620Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.test.ts : Keep module mocks contained in test files; do not use global mutable state within test files; use `vi.hoisted()` if necessary

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Mock external dependencies in tests

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Always prefer vitest mock functions over writing verbose manual mocks

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-12-09T20:22:23.620Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.test.ts : Leverage Vitest's mocking utilities where possible for test mocking

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

tests-ui/tests/composables/useJobList.test.ts
src/composables/queue/useJobList.ts

📚 Learning: 2025-12-10T03:09:13.807Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7303
File: src/components/topbar/CurrentUserPopover.test.ts:199-205
Timestamp: 2025-12-10T03:09:13.807Z
Learning: In test files, prefer selecting or asserting on accessible properties (text content, aria-label, role, accessible name) over data-testid attributes. This ensures tests validate actual user-facing behavior and accessibility, reducing reliance on implementation details like test IDs.

Applied to files:

tests-ui/tests/composables/useJobList.test.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

tests-ui/tests/composables/useJobList.test.ts
src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/composables/queue/useJobList.ts
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use useIntersectionObserver for visibility detection instead of custom scroll handlers

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select

Applied to files:

src/components/TopMenuSection.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message

Applied to files:

src/components/TopMenuSection.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

src/components/TopMenuSection.vue
src/components/queue/QueueOverlayExpanded.vue
src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{composables,components}/**/*.{ts,tsx,vue} : Clean up subscriptions in state management to prevent memory leaks

Applied to files:

src/composables/queue/useJobList.ts

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use Teleport/Suspense when needed for component rendering

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-12-09T20:22:23.620Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Utilize Vue 3's Teleport component when needed

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API

Applied to files:

src/components/queue/QueueProgressOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings

Applied to files:

src/components/queue/QueueProgressOverlay.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Agent

🔇 Additional comments (6)

src/components/TopMenuSection.vue (1)

2-2: LGTM! Clean removal of hover tracking.

The removal of hover-related event handlers and the menu-hovered prop simplifies the component appropriately. The changes align with the PR objective to remove queue overlay active state and hover handling.

Also applies to: 51-51

src/composables/queue/useJobList.ts (1)

83-83: LGTM! Appropriate simplification of the composable.

The removal of filtering/sorting scaffolds and the direct aliasing of filteredTaskEntries to tasksWithJobState correctly reflects the elimination of tab/workflow filtering logic. The updated JSDoc comment accurately describes the streamlined purpose.

Also applies to: 201-203

src/components/queue/QueueOverlayExpanded.vue (1)

73-96: LGTM! Consistent removal of filter/sort UI surface.

The simplified props and emits correctly reflect the removal of JobFiltersBar and associated filtering/sorting controls. The component now focuses solely on displaying job groups and handling job actions.

src/components/queue/QueueProgressOverlay.vue (3)

63-67: LGTM! Clean simplification of overlay state model.

The removal of the 'active' overlay state and the menu-hovered prop appropriately streamlines the component. The props interface is now minimal and focused.

104-120: LGTM! Overlay state logic correctly updated.

The overlayState and showBackground computed properties correctly reflect the simplified state model without the 'active' state. The logic is consistent and correct.

135-137: LGTM! Destructuring updated to match simplified composable API.

The component now extracts only filteredTasks and groupedJobItems from useJobList, correctly aligning with the composable's simplified return contract.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-11T02:44:06Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/13/2025, 11:41:18 PM UTC

📈 Summary

Total Tests: 503
Passed: 490 ✅
Failed: 0
Flaky: 4 ⚠️
Skipped: 9 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 478 / ❌ 0 / ⚠️ 4 / ⏭️ 9
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

github-actions · 2025-12-11T02:44:07Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/13/2025, 11:32:38 PM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

github-actions · 2025-12-11T02:46:19Z

Bundle Size Report

Summary

Raw size: 17.1 MB baseline 17.1 MB — 🟢 -23.8 kB
Gzip: 3.39 MB baseline 3.39 MB — 🟢 -2.95 kB
Brotli: 2.6 MB baseline 2.6 MB — 🟢 -2.31 kB
Bundles: 98 current • 98 baseline • 40 added / 40 removed

Category Glance
Graph Workspace 🟢 -23.8 kB (962 kB) · Vendor & Third-Party ⚪ 0 B (8.56 MB) · Other ⚪ 0 B (3.82 MB) · App Entry Points ⚪ 0 B (3.25 MB) · Panels & Settings ⚪ 0 B (298 kB) · UI Components ⚪ 0 B (184 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.25 MB (baseline 3.25 MB) • ⚪ 0 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-BWJsF22y.js (new)	—	3.02 MB	🔴 +3.02 MB	🔴 +627 kB	🔴 +477 kB
~~assets/index-DcGx72Jn.js~~ (removed)	3.02 MB	—	🟢 -3.02 MB	🟢 -627 kB	🟢 -477 kB
assets/index-C88mjOUh.js (new)	—	227 kB	🔴 +227 kB	🔴 +48.6 kB	🔴 +39.8 kB
~~assets/index-ZU9cnxo4.js~~ (removed)	227 kB	—	🟢 -227 kB	🟢 -48.6 kB	🟢 -39.9 kB
~~assets/index-Bi4uRoRn.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -242 B	🟢 -231 B
assets/index-C4g0frLG.js (new)	—	345 B	🔴 +345 B	🔴 +246 B	🔴 +236 B

Status: 3 added / 3 removed

Graph Workspace — 962 kB (baseline 986 kB) • 🟢 -23.8 kB

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/GraphView-Ddp5bN2u.js~~ (removed)	986 kB	—	🟢 -986 kB	🟢 -191 kB	🟢 -146 kB
assets/GraphView-f0d1rtNa.js (new)	—	962 kB	🔴 +962 kB	🔴 +188 kB	🔴 +143 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-CgTLMnSE.js (new)	—	6.54 kB	🔴 +6.54 kB	🔴 +2.14 kB	🔴 +1.9 kB
~~assets/UserSelectView-CKiV3iFy.js~~ (removed)	6.54 kB	—	🟢 -6.54 kB	🟢 -2.14 kB	🟢 -1.89 kB

Status: 1 added / 1 removed

Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LegacyCreditsPanel-Bp41TvTg.js (new)	—	21.4 kB	🔴 +21.4 kB	🔴 +5.16 kB	🔴 +4.5 kB
~~assets/LegacyCreditsPanel-VslWqVwZ.js~~ (removed)	21.4 kB	—	🟢 -21.4 kB	🟢 -5.16 kB	🟢 -4.5 kB
assets/KeybindingPanel-_vXR5haB.js (new)	—	13.6 kB	🔴 +13.6 kB	🔴 +3.42 kB	🔴 +3.01 kB
~~assets/KeybindingPanel-DHxeIti8.js~~ (removed)	13.6 kB	—	🟢 -13.6 kB	🟢 -3.42 kB	🟢 -3.02 kB
~~assets/ExtensionPanel-0-bAKsPj.js~~ (removed)	10.8 kB	—	🟢 -10.8 kB	🟢 -2.58 kB	🟢 -2.26 kB
assets/ExtensionPanel-CawJHyN8.js (new)	—	10.8 kB	🔴 +10.8 kB	🔴 +2.57 kB	🔴 +2.25 kB
~~assets/AboutPanel-73kkCr7P.js~~ (removed)	9.16 kB	—	🟢 -9.16 kB	🟢 -2.46 kB	🟢 -2.21 kB
assets/AboutPanel-BlI4f22y.js (new)	—	9.16 kB	🔴 +9.16 kB	🔴 +2.46 kB	🔴 +2.21 kB
~~assets/ServerConfigPanel-48tnaooV.js~~ (removed)	6.56 kB	—	🟢 -6.56 kB	🟢 -1.83 kB	🟢 -1.63 kB
assets/ServerConfigPanel-Cy8saaV3.js (new)	—	6.56 kB	🔴 +6.56 kB	🔴 +1.83 kB	🔴 +1.63 kB
assets/UserPanel-B_vWVHLD.js (new)	—	6.23 kB	🔴 +6.23 kB	🔴 +1.72 kB	🔴 +1.51 kB
~~assets/UserPanel-hA8JKv9Q.js~~ (removed)	6.23 kB	—	🟢 -6.23 kB	🟢 -1.72 kB	🟢 -1.51 kB
assets/settings-B_sqawkt.js	27.3 kB	27.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BlDXT7wp.js	21.7 kB	21.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-Bz8HAvJu.js	21.1 kB	21.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C2vW8UNv.js	24.2 kB	24.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C9vsDM17.js	25.1 kB	25.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DWD49kQp.js	33.3 kB	33.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DZE27_Iz.js	25.9 kB	25.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-OXaZPcZF.js	26.6 kB	26.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-RbkKsnDG.js	25.2 kB	25.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 184 kB (baseline 184 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-BF7w5JYZ.js (new)	—	53.7 kB	🔴 +53.7 kB	🔴 +8.49 kB	🔴 +7.29 kB
~~assets/Load3D.vue_vue_type_script_setup_true_lang-BQvUKaXA.js~~ (removed)	53.7 kB	—	🟢 -53.7 kB	🟢 -8.49 kB	🟢 -7.29 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-B-oQWcC1.js~~ (removed)	48 kB	—	🟢 -48 kB	🟢 -10.3 kB	🟢 -8.98 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-szi7XdnH.js (new)	—	48 kB	🔴 +48 kB	🔴 +10.3 kB	🔴 +8.97 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-BDaoaD1G.js (new)	—	48 kB	🔴 +48 kB	🔴 +10.7 kB	🔴 +9.33 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-EWe7x7-s.js~~ (removed)	48 kB	—	🟢 -48 kB	🟢 -10.7 kB	🟢 -9.31 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DeP25klt.js~~ (removed)	19.5 kB	—	🟢 -19.5 kB	🟢 -5.04 kB	🟢 -4.46 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-TCd5NLIQ.js (new)	—	19.5 kB	🔴 +19.5 kB	🔴 +5.04 kB	🔴 +4.46 kB
~~assets/ComfyQueueButton-DpRasgMh.js~~ (removed)	8.44 kB	—	🟢 -8.44 kB	🟢 -2.48 kB	🟢 -2.21 kB
assets/ComfyQueueButton-Tq7ww03g.js (new)	—	8.44 kB	🔴 +8.44 kB	🔴 +2.48 kB	🔴 +2.22 kB
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-Ce2zbmds.js (new)	—	2.14 kB	🔴 +2.14 kB	🔴 +889 B	🔴 +768 B
~~assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-dAN2d4um.js~~ (removed)	2.14 kB	—	🟢 -2.14 kB	🟢 -890 B	🟢 -762 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CubTWWkF.js (new)	—	897 B	🔴 +897 B	🔴 +503 B	🔴 +429 B
~~assets/MediaTitle.vue_vue_type_script_setup_true_lang-p7J90VHw.js~~ (removed)	897 B	—	🟢 -897 B	🟢 -505 B	🟢 -438 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-Bjfb_hoW.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-Bm2lwPFd.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 7 added / 7 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-AHeEtwMV.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.58 kB
~~assets/keybindingService-w9IcQmX0.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.84 kB	🟢 -1.58 kB
~~assets/audioService-BtLaNJBp.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -961 B	🟢 -824 B
assets/audioService-DMCp_2OS.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +961 B	🔴 +827 B
assets/serverConfigStore-BP9UaJXd.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/audioUtils-Bkl8_2YW.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -653 B	🟢 -547 B
assets/audioUtils-CMKKsTa-.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +651 B	🔴 +542 B
assets/mathUtil-CD4DsosH.js	1.32 kB	1.32 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js	460 B	460 B	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-W_3Knk2t.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-BzuNIfYH.js	3.98 MB	3.98 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-CmhMHYBF.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-aR6ntw5X.js	1.37 MB	1.37 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-DCLYW5rb.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-C3MDzIsc.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BZLod3g9.js	407 kB	407 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.82 MB (baseline 3.82 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/WidgetRecordAudio-C7NI8v1Q.js (new)	—	20.4 kB	🔴 +20.4 kB	🔴 +5.24 kB	🔴 +4.63 kB
~~assets/WidgetRecordAudio-DwcVQQEB.js~~ (removed)	20.4 kB	—	🟢 -20.4 kB	🟢 -5.23 kB	🟢 -4.63 kB
assets/AudioPreviewPlayer-BYTaSTKf.js (new)	—	13.4 kB	🔴 +13.4 kB	🔴 +3.37 kB	🔴 +3.01 kB
~~assets/AudioPreviewPlayer-DbQmW3KY.js~~ (removed)	13.4 kB	—	🟢 -13.4 kB	🟢 -3.37 kB	🟢 -3.02 kB
assets/NumberControlPopover-CF9xOjtE.js (new)	—	7.49 kB	🔴 +7.49 kB	🔴 +2.16 kB	🔴 +1.9 kB
~~assets/NumberControlPopover-CllT3Pd4.js~~ (removed)	7.49 kB	—	🟢 -7.49 kB	🟢 -2.15 kB	🟢 -1.91 kB
~~assets/WidgetGalleria-B4YeQyrY.js~~ (removed)	4.1 kB	—	🟢 -4.1 kB	🟢 -1.45 kB	🟢 -1.3 kB
assets/WidgetGalleria-BmDAujtb.js (new)	—	4.1 kB	🔴 +4.1 kB	🔴 +1.44 kB	🔴 +1.3 kB
assets/WidgetColorPicker-DP5Eqhj7.js (new)	—	3.41 kB	🔴 +3.41 kB	🔴 +1.38 kB	🔴 +1.23 kB
~~assets/WidgetColorPicker-SxmYR6jk.js~~ (removed)	3.41 kB	—	🟢 -3.41 kB	🟢 -1.38 kB	🟢 -1.23 kB
assets/WidgetTextarea-00qXsNth.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.21 kB	🔴 +1.08 kB
~~assets/WidgetTextarea-COC6nhPr.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.21 kB	🟢 -1.08 kB
~~assets/WidgetMarkdown-BvIGO6Zy.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.28 kB	🟢 -1.13 kB
assets/WidgetMarkdown-DMk3uL0S.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.28 kB	🔴 +1.13 kB
assets/WidgetAudioUI-Bi4G3pEU.js (new)	—	2.86 kB	🔴 +2.86 kB	🔴 +1.16 kB	🔴 +1.06 kB
~~assets/WidgetAudioUI-RtMPe__2.js~~ (removed)	2.86 kB	—	🟢 -2.86 kB	🟢 -1.17 kB	🟢 -1.05 kB
assets/WidgetInputText-BzD2m871.js (new)	—	1.99 kB	🔴 +1.99 kB	🔴 +919 B	🔴 +829 B
~~assets/WidgetInputText-f4fdrVUd.js~~ (removed)	1.99 kB	—	🟢 -1.99 kB	🟢 -918 B	🟢 -848 B
~~assets/WidgetToggleSwitch-BLCfM2nH.js~~ (removed)	1.76 kB	—	🟢 -1.76 kB	🟢 -834 B	🟢 -732 B
assets/WidgetToggleSwitch-BXXqEbw6.js (new)	—	1.76 kB	🔴 +1.76 kB	🔴 +835 B	🔴 +732 B
assets/MediaImageBottom-DvWAVyg0.js (new)	—	1.55 kB	🔴 +1.55 kB	🔴 +737 B	🔴 +643 B
~~assets/MediaImageBottom-IMz2_ehw.js~~ (removed)	1.55 kB	—	🟢 -1.55 kB	🟢 -736 B	🟢 -646 B
~~assets/MediaAudioBottom-B2f1BXh5.js~~ (removed)	1.51 kB	—	🟢 -1.51 kB	🟢 -736 B	🟢 -654 B
assets/MediaAudioBottom-DvFFLr0C.js (new)	—	1.51 kB	🔴 +1.51 kB	🔴 +735 B	🔴 +653 B
~~assets/Media3DBottom-BEClWA0K.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -734 B	🟢 -655 B
assets/Media3DBottom-dZSDbnYZ.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +733 B	🔴 +655 B
~~assets/MediaVideoBottom-CZDlJk2B.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -735 B	🟢 -652 B
assets/MediaVideoBottom-Z9Moy-20.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +734 B	🔴 +652 B
~~assets/Media3DTop-B0kIBYfF.js~~ (removed)	1.49 kB	—	🟢 -1.49 kB	🟢 -765 B	🟢 -652 B
assets/Media3DTop-C10mbkam.js (new)	—	1.49 kB	🔴 +1.49 kB	🔴 +763 B	🔴 +651 B
assets/WidgetSelect-De6osiKm.js (new)	—	655 B	🔴 +655 B	🔴 +343 B	🔴 +288 B
~~assets/WidgetSelect-okOZr1ct.js~~ (removed)	655 B	—	🟢 -655 B	🟢 -341 B	🟢 -286 B
~~assets/WidgetInputNumber-bPPJ5u41.js~~ (removed)	595 B	—	🟢 -595 B	🟢 -328 B	🟢 -276 B
assets/WidgetInputNumber-DK_VwTga.js (new)	—	595 B	🔴 +595 B	🔴 +329 B	🔴 +277 B
assets/Load3D-CJ1_iwS2.js (new)	—	424 B	🔴 +424 B	🔴 +267 B	🔴 +225 B
~~assets/Load3D-DmpXEm0M.js~~ (removed)	424 B	—	🟢 -424 B	🟢 -268 B	🟢 -227 B
assets/WidgetLegacy-BlTN36Tn.js (new)	—	364 B	🔴 +364 B	🔴 +237 B	🔴 +194 B
~~assets/WidgetLegacy-rMKPvz47.js~~ (removed)	364 B	—	🟢 -364 B	🟢 -237 B	🟢 -194 B
assets/commands-_s-RvhJR.js	13.6 kB	13.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BuUILW6P.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BV4R6fLx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CLwPdnT6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CWMchBmd.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DazTQhtc.js	12.9 kB	12.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DmWrOe93.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwiH7Kr6.js	13.8 kB	13.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-mS3LCNPn.js	14.5 kB	14.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BMi-Aksj.js	99 kB	99 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CqR8skJT.js	73.1 kB	73.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DcRHAFEy.js	81.7 kB	81.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DdFdLxku.js	72.2 kB	72.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DJAtuVu5.js	84.3 kB	84.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DK8I9Rk3.js	114 kB	114 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-gP_ssnMb.js	83.4 kB	83.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-nxXY9vGp.js	94 kB	94 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Ycd3gqkA.js	86.5 kB	86.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-taU5Yj_Q.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-BoT3yC-l.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-Csf8f_9c.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-_qLI3Y-X.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BoBMp_wf.js	307 kB	307 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Ce9u3PlO.js	342 kB	342 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CgjGEDDp.js	285 kB	285 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CL3A8ieS.js	306 kB	306 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-DNUc-sw4.js	303 kB	303 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-DxUbhTnC.js	282 kB	282 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-i8mv_3Jj.js	369 kB	369 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-wCFicyab.js	310 kB	310 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-CWEwKtMY.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-DSf2ZEwg.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 19 added / 19 removed

Copilot

Pull request overview

This pull request removes the queue overlay active state and filtering/sorting UI features from the queue progress overlay, simplifying the codebase in preparation for follow-up PRs. The changes eliminate intermediate states and controls that are no longer needed.

Key changes:

Removed the "active" overlay state that showed progress bars with hover-to-reveal controls
Eliminated job filtering (All/Completed/Failed tabs) and workflow filtering (all/current) functionality
Removed job sorting options (most recent vs. total generation time)

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`tests-ui/tests/composables/useJobList.test.ts`	Removed workflow store mock, filter/sort tests; updated test expectations to reflect removal of sorting functionality
`src/composables/queue/useJobList.ts`	Removed filter/sort state management, workflow store import, and associated computed properties; simplified filteredTaskEntries to pass through all tasks
`src/components/queue/job/JobFiltersBar.vue`	Deleted entire component that provided filter/sort UI controls
`src/components/queue/QueueProgressOverlay.vue`	Removed active overlay state, hover handling, progress tracking, and interruptAll functionality; simplified overlay state to only 'hidden', 'empty', or 'expanded'
`src/components/queue/QueueOverlayExpanded.vue`	Removed filter/sort props and events; cleaned up component interface
`src/components/queue/QueueOverlayActive.vue`	Deleted entire component that showed active job progress with hover controls
`src/components/queue/QueueOverlayActive.test.ts`	Deleted test file for removed component
`src/components/TopMenuSection.vue`	Removed hover state tracking and menuHovered prop passing

## Summary - add Playwright queue list fixture and coverage for toggle/count display - update queue overlay unit tests plus storybook stories for inline progress and job item - adjust useJobList expectations for ordered tasks main <-- #7336 <-- #7338 <-- #7342 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7342-Add-queue-overlay-tests-and-stories-2c66d73d365081ae8e32d6e34f87e1d9) by [Unito](https://www.unito.io)

Remove queue overlay active state and filters

f548af2

benceruleanlu changed the title ~~Draft: Remove queue overlay active state and filters~~ Remove queue overlay active state and filters Dec 11, 2025

This was referenced Dec 11, 2025

Add queue overlay inline progress and controls #7338

Open

Add queue overlay tests and stories #7342

Merged

Refactor Queue UI: Inline Progress & Cleanups #7230

Closed

benceruleanlu marked this pull request as ready for review December 11, 2025 20:29

benceruleanlu requested a review from a team as a code owner December 11, 2025 20:29

Copilot AI review requested due to automatic review settings December 11, 2025 20:29

dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 11, 2025

Copilot started reviewing on behalf of benceruleanlu December 11, 2025 20:30 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Merge branch 'main' into queue-overlay-deletions

c673773

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove queue overlay active state and filters #7336

Remove queue overlay active state and filters #7336

Uh oh!

benceruleanlu commented Dec 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 11, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove queue overlay active state and filters #7336

Are you sure you want to change the base?

Remove queue overlay active state and filters #7336

Uh oh!

Conversation

benceruleanlu commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benceruleanlu commented Dec 11, 2025 •

edited

Loading

coderabbitai bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading