Skip to content

Add queue overlay inline progress and controls #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benceruleanlu wants to merge 17 commits into
base: queue-overlay-deletions
Choose a base branch
from
Open

Add queue overlay inline progress and controls #7338

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9863aa6
Add queue overlay inline progress and controls
benceruleanlu Dec 11, 2025
ee47684
Remove useless watcheffect
benceruleanlu Dec 11, 2025
4a8975a
Merge remote-tracking branch 'origin/queue-overlay-deletions' into qu…
benceruleanlu Dec 13, 2025
d7d03be
Remove unused i18n string
benceruleanlu Dec 14, 2025
24ab32d
[automated] Update test expectations
invalid-email-address Dec 14, 2025
73678e0
Restore Panel
benceruleanlu Dec 14, 2025
18303fa
Merge branch 'queue-overlay-additions' of https://github.com/Comfy-Or…
benceruleanlu Dec 14, 2025
53dbca9
Add queue overlay tests and stories (#7342)
benceruleanlu Dec 14, 2025
66f4dac
Simplify docked by using model macro
benceruleanlu Dec 14, 2025
b10e67f
Use usei18n
benceruleanlu Dec 14, 2025
fdaba3a
Merge branch 'queue-overlay-additions' of https://github.com/Comfy-Or…
benceruleanlu Dec 14, 2025
51d2046
Ensure don't round to 0 hours
benceruleanlu Dec 14, 2025
04de43f
Translate hours text in popover
benceruleanlu Dec 14, 2025
d48aabb
Fix aria for QIPS
benceruleanlu Dec 14, 2025
7c5859e
Cleanup listeners on unmount
benceruleanlu Dec 14, 2025
eb5327b
Remove unused allTasksSorted
benceruleanlu Dec 14, 2025
6f52357
Minor dry nit
benceruleanlu Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/queue-overlay-deletions' into qu… 
…eue-overlay-additions
  • Loading branch information
@benceruleanlu
benceruleanlu committed Dec 13, 2025
commit 4a8975ad27c07b3173af6a56367e904286750cfd
21 changes: 7 additions & 14 deletions src/components/actionbar/ComfyActionbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,7 @@
:style="style"
class="flex flex-col items-stretch"
>
<Panel
ref="panelRef"
:class="panelRootClass"
:pt="{
header: { class: 'hidden' },
content: { class: docked ? 'p-0' : 'p-1' }
}"
>
<div ref="panelRef" :class="cn(panelRootClass, docked ? 'p-0' : 'p-1')">
<div class="flex flex-col">
<div class="flex items-center select-none">
<span
Expand All @@ -35,7 +28,9 @@
"
/>

<ComfyRunButton />
<Suspense @resolve="comfyRunButtonResolved">
<ComfyRunButton />
</Suspense>
<IconButton
v-tooltip.bottom="cancelJobTooltipConfig"
type="transparent"
Expand Down Expand Up @@ -74,7 +69,7 @@
</IconTextButton>
</div>
</div>
</Panel>
</div>

<div v-if="isFloating" class="flex justify-end pt-1 pr-1">
<QueueInlineProgressSummary
Expand Down Expand Up @@ -103,9 +98,7 @@ import {
} from '@vueuse/core'
import { clamp } from 'es-toolkit/compat'
import { storeToRefs } from 'pinia'
import Panel from 'primevue/panel'
import type { ComponentPublicInstance } from 'vue'
import { computed, nextTick, onMounted, ref, watch } from 'vue'
import { computed, nextTick, ref, watch } from 'vue'

import IconButton from '@/components/button/IconButton.vue'
import IconTextButton from '@/components/button/IconTextButton.vue'
Expand Down Expand Up @@ -143,7 +136,7 @@ const visible = computed(() => position.value !== 'Disabled')

const tabContainer = document.querySelector('.workflow-tabs-container')
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable tabContainer is queried from the DOM at the module level (line 144), which means it's evaluated when the module is first imported. This may execute before the DOM is fully rendered, potentially resulting in null. Consider moving this query inside onMounted or using a computed property to ensure the element exists when it's accessed.

Suggested change
const tabContainer = document.querySelector('.workflow-tabs-container')
const tabContainer = ref<HTMLElement | null>(null)

Copilot uses AI. Check for mistakes.
const actionbarWrapperRef = ref<HTMLElement | null>(null)
const panelRef = ref<HTMLElement | ComponentPublicInstance | null>(null)
const panelRef = ref<HTMLElement | null>(null)
const dragHandleRef = ref<HTMLElement | null>(null)
const docked = computed({
get: () => props.docked ?? false,
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.