Skip to content

Fix: Flaky Playwright Tests: retry some assertions #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 7 commits into from
Dec 11, 2025
Merged

Fix: Flaky Playwright Tests: retry some assertions #7389

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbf560f
test: Add expectation retry for remoteWidgets
DrJKL Dec 11, 2025
f80027e
test: Same logic for the other flaky test.
DrJKL Dec 11, 2025
64d1e8b
test: Retrying for card count in templates test
DrJKL Dec 11, 2025
3f58010
Minimum with geq makes more sense
DrJKL Dec 11, 2025
6008529
fix: Use retrying assertion for backgroundImage check
DrJKL Dec 11, 2025
2f10868
fix: Retry expectations in nodeLibrary.spec
DrJKL Dec 11, 2025
1cfd3fa
fix: Retry check for the PreviewAsText values
DrJKL Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Retry expectations in nodeLibrary.spec
  • Loading branch information
@DrJKL
DrJKL committed Dec 11, 2025
commit 2f108680af4ea7dede5cb9efb7967f73f11d1e46
24 changes: 14 additions & 10 deletions browser_tests/tests/sidebar/nodeLibrary.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,16 +290,20 @@ test.describe('Node library sidebar', () => {
await comfyPage.page.keyboard.insertText('bar')
await comfyPage.page.keyboard.press('Enter')
await comfyPage.nextFrame()
expect(
await comfyPage.getSetting('Comfy.NodeLibrary.Bookmarks.V2')
).toEqual(['bar/'])
expect(
await comfyPage.getSetting('Comfy.NodeLibrary.BookmarksCustomization')
).toEqual({
'bar/': {
icon: 'pi-folder',
color: '#007bff'
}
await expect(async () => {
expect(
await comfyPage.getSetting('Comfy.NodeLibrary.Bookmarks.V2')
).toEqual(['bar/'])
expect(
await comfyPage.getSetting('Comfy.NodeLibrary.BookmarksCustomization')
).toEqual({
'bar/': {
icon: 'pi-folder',
color: '#007bff'
}
})
}).toPass({
timeout: 2_000
})
})

Expand Down