Skip to content

Feat: Remove the Nodes 2.0 Trial Banner #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DrJKL merged 4 commits into from
Dec 12, 2025
Merged

Feat: Remove the Nodes 2.0 Trial Banner #7390

DrJKL merged 4 commits into from
Dec 12, 2025

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Dec 11, 2025 •
edited by sync-by-unito bot
Loading

Summary

The option to try it out is still in the Menu if you're looking for it.

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested review from a team and pythongosssss as code owners December 11, 2025 21:56
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png is excluded by !**/*.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Removes Vue Nodes onboarding UI and related state: deletes the top banner and migration toast components, removes the shared localStorage dismissal composable, and strips migration-toast display/dismissal logic from the Vue Nodes lifecycle watcher; other lifecycle and layout sync behavior remains.

Changes

Cohort / File(s) Summary
Removed Onboarding UI Components
src/components/topbar/TryVueNodeBanner.vue, src/components/toast/VueNodesMigrationToast.vue		 Deleted the TryVueNodeBanner and VueNodesMigrationToast components including templates, imports, event handlers, feature-flag checks, localStorage dismissal logic, and toast display flows.
Component Usages Updated
src/components/graph/GraphCanvas.vue, src/views/GraphView.vue		 Removed imports and template references to the deleted banner/toast components.
Removed Shared State Composable
src/composables/useVueNodesMigrationDismissed.ts		 Deleted the exported composable that provided a localStorage-backed migration-dismissed flag.
Simplified Vue Nodes Lifecycle
src/composables/graph/useVueNodeLifecycle.ts		 Removed migration-toast-related state, imports, and the conditional toast display logic from the watcher on Vue Nodes enablement; preserved remaining lifecycle and layout sync logic.
Package manifest
package.json		 (Listed in manifest) No code changes described; included in PR manifest metadata.

Possibly related PRs

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drjkl/banner-go-bye-bye

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025 •
edited
Loading

🎭 Playwright Test Results

🕵🏻 No test results found

⏰ Completed at: 12/12/2025, 12:48:41 AM UTC

📊 Test Reports by Browser

  • ❌ chromium: Deployment failed
  • ❌ chromium-2x: Deployment failed
  • ❌ chromium-0.5x: Deployment failed
  • ❌ mobile-chrome: Deployment failed

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/12/2025, 12:49:08 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 11, 2025 •
edited
Loading

Bundle Size Report

Summary

  • Raw size: 17.1 MB baseline 17.1 MB — 🟢 -5.86 kB
  • Gzip: 3.39 MB baseline 3.39 MB — 🟢 -1.06 kB
  • Brotli: 2.6 MB baseline 2.6 MB — 🟢 -884 B
  • Bundles: 97 current • 97 baseline • 39 added / 39 removed

Category Glance
Graph Workspace 🟢 -5.86 kB (981 kB) · Vendor & Third-Party ⚪ 0 B (8.56 MB) · Other ⚪ 0 B (3.81 MB) · App Entry Points ⚪ 0 B (3.23 MB) · Panels & Settings ⚪ 0 B (298 kB) · UI Components ⚪ 0 B (178 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.23 MB (baseline 3.23 MB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-Bicr9SPo.js (new) — 3.01 MB 🔴 +3.01 MB 🔴 +625 kB 🔴 +476 kB
assets/index-mxeuW8kg.js (removed) 3.01 MB — 🟢 -3.01 MB 🟢 -625 kB 🟢 -476 kB
assets/index-BIqp2Aoh.js (new) — 224 kB 🔴 +224 kB 🔴 +47.8 kB 🔴 +39.4 kB
assets/index-DckKyltn.js (removed) 224 kB — 🟢 -224 kB 🟢 -47.8 kB 🟢 -39.4 kB
assets/index-BGicejOP.js (removed) 345 B — 🟢 -345 B 🟢 -242 B 🟢 -208 B
assets/index-BkOLn1pk.js (new) — 345 B 🔴 +345 B 🔴 +242 B 🔴 +201 B

Status: 3 added / 3 removed

Graph Workspace — 981 kB (baseline 987 kB) • 🟢 -5.86 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-D5rRi3p1.js (removed) 987 kB — 🟢 -987 kB 🟢 -191 kB 🟢 -146 kB
assets/GraphView-DhhHBt0s.js (new) — 981 kB 🔴 +981 kB 🔴 +190 kB 🔴 +145 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-Dofobcn0.js (new) — 6.54 kB 🔴 +6.54 kB 🔴 +2.14 kB 🔴 +1.9 kB
assets/UserSelectView-hOjXjQIO.js (removed) 6.54 kB — 🟢 -6.54 kB 🟢 -2.14 kB 🟢 -1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LegacyCreditsPanel-C_dL6iBr.js (new) — 21.4 kB 🔴 +21.4 kB 🔴 +5.15 kB 🔴 +4.5 kB
assets/LegacyCreditsPanel-DhdBpxAM.js (removed) 21.4 kB — 🟢 -21.4 kB 🟢 -5.15 kB 🟢 -4.5 kB
assets/KeybindingPanel-BC-I9Q31.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.42 kB 🔴 +3.01 kB
assets/KeybindingPanel-DBLBUWns.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.42 kB 🟢 -3.01 kB
assets/ExtensionPanel-Bs5kyNSM.js (removed) 10.8 kB — 🟢 -10.8 kB 🟢 -2.57 kB 🟢 -2.26 kB
assets/ExtensionPanel-CwEyHiDf.js (new) — 10.8 kB 🔴 +10.8 kB 🔴 +2.57 kB 🔴 +2.26 kB
assets/AboutPanel-xeATxg2h.js (removed) 9.16 kB — 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/AboutPanel-Ysulo8fx.js (new) — 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.21 kB
assets/ServerConfigPanel-CPvRgLyF.js (new) — 6.56 kB 🔴 +6.56 kB 🔴 +1.83 kB 🔴 +1.63 kB
assets/ServerConfigPanel-gtsAYh9Y.js (removed) 6.56 kB — 🟢 -6.56 kB 🟢 -1.83 kB 🟢 -1.63 kB
assets/UserPanel-CoqWi0MO.js (new) — 6.23 kB 🔴 +6.23 kB 🔴 +1.72 kB 🔴 +1.51 kB
assets/UserPanel-DC3_5fJ8.js (removed) 6.23 kB — 🟢 -6.23 kB 🟢 -1.72 kB 🟢 -1.5 kB
assets/settings-BhbWhsRg.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BXTtSH4O.js 33.3 kB 33.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C9Pzn-NG.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CCy2fA_h.js 27.3 kB 27.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CQpqEFfl.js 26.6 kB 26.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DHcnxypw.js 21.7 kB 21.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DhFTK9fY.js 25.1 kB 25.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DlT4t_ui.js 25.9 kB 25.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DRgSrIdD.js 24.2 kB 24.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-tjkeqiZq.js 21.1 kB 21.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 178 kB (baseline 178 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-Bt7pS-s2.js (removed) 53.7 kB — 🟢 -53.7 kB 🟢 -8.48 kB 🟢 -7.28 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-CsHBDvd9.js (new) — 53.7 kB 🔴 +53.7 kB 🔴 +8.48 kB 🔴 +7.29 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-C4CauD5v.js (removed) 48.1 kB — 🟢 -48.1 kB 🟢 -10.4 kB 🟢 -8.98 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-odWxFxJW.js (new) — 48.1 kB 🔴 +48.1 kB 🔴 +10.4 kB 🔴 +8.98 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-BRebaQx4.js (new) — 48 kB 🔴 +48 kB 🔴 +10.6 kB 🔴 +9.32 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-DYtTd1_h.js (removed) 48 kB — 🟢 -48 kB 🟢 -10.6 kB 🟢 -9.31 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DanXSXQw.js (removed) 12.9 kB — 🟢 -12.9 kB 🟢 -3.37 kB 🟢 -2.97 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-S-VtnNUk.js (new) — 12.9 kB 🔴 +12.9 kB 🔴 +3.37 kB 🔴 +2.97 kB
assets/ComfyQueueButton-CS-rRT7m.js (removed) 8.44 kB — 🟢 -8.44 kB 🟢 -2.47 kB 🟢 -2.21 kB
assets/ComfyQueueButton-Mle5u9Vc.js (new) — 8.44 kB 🔴 +8.44 kB 🔴 +2.47 kB 🔴 +2.21 kB
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-bU8OGViF.js (new) — 2.47 kB 🔴 +2.47 kB 🔴 +935 B 🔴 +806 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-BZyN_w2P.js (removed) 2.47 kB — 🟢 -2.47 kB 🟢 -935 B 🟢 -803 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-DIQvtXTF.js (removed) 897 B — 🟢 -897 B 🟢 -502 B 🟢 -442 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-G8cutQ1f.js (new) — 897 B 🔴 +897 B 🔴 +501 B 🔴 +441 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DROonty0.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-CK5wnnsh.js 2.04 kB 2.04 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 7 added / 7 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-_FOp8MAC.js (removed) 7.51 kB — 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/keybindingService-Cfx2Rl6m.js (new) — 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.58 kB
assets/audioService-D0IEjwVF.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -960 B 🟢 -822 B
assets/audioService-OIPg2_Ff.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +960 B 🔴 +821 B
assets/serverConfigStore-C8zDWJOU.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-C2FsesvA.js (removed) 1.41 kB — 🟢 -1.41 kB 🟢 -649 B 🟢 -544 B
assets/audioUtils-i1tUkM8X.js (new) — 1.41 kB 🔴 +1.41 kB 🔴 +650 B 🔴 +578 B
assets/mathUtil-CD4DsosH.js 1.32 kB 1.32 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js 460 B 460 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-QtHvZroj.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-Es5IU4iT.js 3.98 MB 3.98 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-DRta5A0j.js 1.96 MB 1.96 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-aR6ntw5X.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-1u_V6HbC.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-30uFjOtU.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/WidgetRecordAudio-CZL9Mlhd.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.23 kB 🟢 -4.62 kB
assets/WidgetRecordAudio-SYAm0cnD.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.23 kB 🔴 +4.62 kB
assets/AudioPreviewPlayer-_AbNGjKq.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.37 kB 🟢 -3.01 kB
assets/AudioPreviewPlayer-CRaov6mK.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.37 kB 🔴 +3.01 kB
assets/WidgetGalleria-B9DlNC0K.js (new) — 4.1 kB 🔴 +4.1 kB 🔴 +1.44 kB 🔴 +1.3 kB
assets/WidgetGalleria-CKaew-56.js (removed) 4.1 kB — 🟢 -4.1 kB 🟢 -1.44 kB 🟢 -1.31 kB
assets/WidgetColorPicker-C0Oz7RBL.js (new) — 3.41 kB 🔴 +3.41 kB 🔴 +1.38 kB 🔴 +1.23 kB
assets/WidgetColorPicker-CbBNmL8A.js (removed) 3.41 kB — 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.23 kB
assets/WidgetTextarea-BE_Up7kb.js (new) — 3.08 kB 🔴 +3.08 kB 🔴 +1.22 kB 🔴 +1.07 kB
assets/WidgetTextarea-gBV616J9.js (removed) 3.08 kB — 🟢 -3.08 kB 🟢 -1.22 kB 🟢 -1.07 kB
assets/WidgetMarkdown-BAJ00i9N.js (removed) 3.08 kB — 🟢 -3.08 kB 🟢 -1.28 kB 🟢 -1.12 kB
assets/WidgetMarkdown-C8G1zw6-.js (new) — 3.08 kB 🔴 +3.08 kB 🔴 +1.28 kB 🔴 +1.12 kB
assets/WidgetAudioUI-CIwNJF8T.js (new) — 2.85 kB 🔴 +2.85 kB 🔴 +1.16 kB 🔴 +1.05 kB
assets/WidgetAudioUI-CQ3l4sWV.js (removed) 2.85 kB — 🟢 -2.85 kB 🟢 -1.16 kB 🟢 -1.05 kB
assets/WidgetInputText-BRwocPJ6.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +918 B 🔴 +847 B
assets/WidgetInputText-Dguilinf.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -917 B 🟢 -851 B
assets/WidgetToggleSwitch-BgXgGjUb.js (new) — 1.76 kB 🔴 +1.76 kB 🔴 +833 B 🔴 +733 B
assets/WidgetToggleSwitch-hO8MOUjk.js (removed) 1.76 kB — 🟢 -1.76 kB 🟢 -834 B 🟢 -726 B
assets/MediaImageBottom-BD7INtu-.js (removed) 1.55 kB — 🟢 -1.55 kB 🟢 -731 B 🟢 -638 B
assets/MediaImageBottom-CUxguxBc.js (new) — 1.55 kB 🔴 +1.55 kB 🔴 +733 B 🔴 +639 B
assets/MediaAudioBottom-CM31msN7.js (new) — 1.51 kB 🔴 +1.51 kB 🔴 +732 B 🔴 +647 B
assets/MediaAudioBottom-esHyzH8q.js (removed) 1.51 kB — 🟢 -1.51 kB 🟢 -731 B 🟢 -646 B
assets/Media3DBottom-DFKujdMc.js (new) — 1.5 kB 🔴 +1.5 kB 🔴 +730 B 🔴 +645 B
assets/Media3DBottom-fAJhmx4N.js (removed) 1.5 kB — 🟢 -1.5 kB 🟢 -733 B 🟢 -645 B
assets/MediaVideoBottom-EFqbdASk.js (new) — 1.5 kB 🔴 +1.5 kB 🔴 +730 B 🔴 +647 B
assets/MediaVideoBottom-WIyYTna-.js (removed) 1.5 kB — 🟢 -1.5 kB 🟢 -731 B 🟢 -647 B
assets/Media3DTop-8qvGQ2pU.js (new) — 1.49 kB 🔴 +1.49 kB 🔴 +765 B 🔴 +647 B
assets/Media3DTop-8TNEbH32.js (removed) 1.49 kB — 🟢 -1.49 kB 🟢 -765 B 🟢 -651 B
assets/WidgetSelect-Bgw1lVpY.js (removed) 655 B — 🟢 -655 B 🟢 -342 B 🟢 -308 B
assets/WidgetSelect-JYLO1f_V.js (new) — 655 B 🔴 +655 B 🔴 +342 B 🔴 +287 B
assets/WidgetInputNumber-CUS6DriS.js (new) — 595 B 🔴 +595 B 🔴 +327 B 🔴 +277 B
assets/WidgetInputNumber-EDNR2W2B.js (removed) 595 B — 🟢 -595 B 🟢 -330 B 🟢 -273 B
assets/Load3D-BaH2_xy-.js (new) — 424 B 🔴 +424 B 🔴 +266 B 🔴 +223 B
assets/Load3D-CEgFsjFk.js (removed) 424 B — 🟢 -424 B 🟢 -267 B 🟢 -222 B
assets/WidgetLegacy-ChncR7gH.js (new) — 364 B 🔴 +364 B 🔴 +237 B 🔴 +193 B
assets/WidgetLegacy-cQkCdZSf.js (removed) 364 B — 🟢 -364 B 🟢 -238 B 🟢 -193 B
assets/commands-_s-RvhJR.js 13.6 kB 13.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BuUILW6P.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BV4R6fLx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BWp4HdfU.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CLwPdnT6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CWMchBmd.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DazTQhtc.js 12.9 kB 12.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DmWrOe93.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiH7Kr6.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-mS3LCNPn.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BMi-Aksj.js 99 kB 99 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CqR8skJT.js 73.1 kB 73.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cw9RZWRY.js 89 B 89 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DcRHAFEy.js 81.7 kB 81.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DdFdLxku.js 72.2 kB 72.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DJAtuVu5.js 84.3 kB 84.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DK8I9Rk3.js 114 kB 114 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-gP_ssnMb.js 83.4 kB 83.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-nxXY9vGp.js 94 kB 94 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Ycd3gqkA.js 86.5 kB 86.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-DPi7DMtd.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-BixOCGRS.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-DM7ksxDd.js 2.65 kB 2.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BC3OlaIn.js 342 kB 342 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BsqN8-W1.js 285 kB 285 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CK2saYDx.js 307 kB 307 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Cm5kR4Hi.js 306 kB 306 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CMrh-uxB.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DlUIOit1.js 369 kB 369 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DNu_xoP2.js 282 kB 282 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DpcvlpZe.js 303 kB 303 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-IyjOYIl-.js 317 kB 317 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-B6jx9bUF.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-D6EQY_DK.js 2.21 kB 2.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 18 added / 18 removed

@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Updating Playwright Expectations

@DrJKL DrJKL added the Design Used to request Product feedback on design decisions label Dec 11, 2025
@benceruleanlu
Copy link
Member

benceruleanlu commented Dec 11, 2025

@codex review

benceruleanlu
benceruleanlu previously approved these changes Dec 11, 2025
View reviewed changes
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 11, 2025

To use Codex here, create a Codex account and connect to github.

@benceruleanlu
Copy link
Member

benceruleanlu commented Dec 11, 2025

@codex review

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 11, 2025

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

AustinMroz
AustinMroz previously approved these changes Dec 11, 2025
View reviewed changes
@DrJKL DrJKL added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Dec 11, 2025
@github-actions github-actions bot dismissed stale reviews from AustinMroz and benceruleanlu via 07ac745 December 11, 2025 23:30
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 11, 2025
@DrJKL DrJKL force-pushed the drjkl/banner-go-bye-bye branch from 07ac745 to 370eb02 Compare December 11, 2025 23:38
@DrJKL DrJKL force-pushed the drjkl/banner-go-bye-bye branch from 370eb02 to 63a848b Compare December 12, 2025 00:47
@DrJKL DrJKL added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 12, 2025
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 12, 2025
@DrJKL DrJKL merged commit 03e9dd4 into main Dec 12, 2025
3 checks passed
@DrJKL DrJKL deleted the drjkl/banner-go-bye-bye branch December 12, 2025 01:13
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.34 Backport PRs for core 1.34 labels Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

@DrJKL Backport to core/1.34 failed: Merge conflicts detected.

Please manually cherry-pick commit 03e9dd4789842b847b7861d3d8f337f3295f12bd to the core/1.34 branch.

Conflicting files
  • browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png
  • browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png
  • browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

@DrJKL Backport to core/1.34 failed: Merge conflicts detected.

Please manually cherry-pick commit 03e9dd4789842b847b7861d3d8f337f3295f12bd to the core/1.34 branch.

Conflicting files
  • browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png
  • browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png
  • browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png
  • browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png
  • browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png

@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.34 Backport PRs for core 1.34 and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.34 Backport PRs for core 1.34 labels Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

⚠️ Backport to core/1.34 failed

Reason: Merge conflicts detected during cherry-pick of 03e9dd4

📄 Conflicting files 
browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png
browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png
browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png
browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png
🤖 Prompt for AI Agents 
Backport PR #7390 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/7390) to core/1.34.
Cherry-pick merge commit 03e9dd4789842b847b7861d3d8f337f3295f12bd onto new branch
backport-7390-to-core-1.34 from origin/core/1.34.
Resolve conflicts in: browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.34] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @DrJKL

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

⚠️ Backport to core/1.34 failed

Reason: Merge conflicts detected during cherry-pick of 03e9dd4

📄 Conflicting files 
browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png
browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png
browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png
browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png
browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png
🤖 Prompt for AI Agents 
Backport PR #7390 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/7390) to core/1.34.
Cherry-pick merge commit 03e9dd4789842b847b7861d3d8f337f3295f12bd onto new branch
backport-7390-to-core-1.34 from origin/core/1.34.
Resolve conflicts in: browser_tests/tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-create-group-chromium-linux.png browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-after-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-widget-overlapped-before-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-chromium-linux.png browser_tests/tests/vueNodes/interactions/node/move.spec.ts-snapshots/vue-node-moved-node-touch-mobile-chrome-linux.png browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.34] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @DrJKL

@christian-byrne
Copy link
Contributor

christian-byrne commented Dec 15, 2025

Doing the backport

christian-byrne pushed a commit that referenced this pull request Dec 15, 2025
@DrJKL @christian-byrne
Feat: Remove the Nodes 2.0 Trial Banner (#7390)
69b02a4 
The option to try it out is still in the Menu if you're looking for it.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7390-Feat-Remove-the-Nodes-2-0-Trial-Banner-2c66d73d365081c3817ad5c89dd4029b)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <[email protected]>
@christian-byrne christian-byrne mentioned this pull request Dec 15, 2025
Merged
christian-byrne added a commit that referenced this pull request Dec 15, 2025
@christian-byrne @DrJKL
[backport core/1.34] Feat: Remove the Nodes 2.0 Trial Banner (#7522)
ea94d4e 
## Summary
Backport of #7390 to core/1.34

The option to try it out is still in the Menu if you're looking for it.

## Conflicts Resolved
- All test snapshot conflicts: accepted PR version (banner removal
changes snapshots)
- 4 bringToFront snapshots: re-added (deleted in target, modified in PR)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Alexander Brown <[email protected]>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AustinMroz AustinMroz AustinMroz left review comments

@benceruleanlu benceruleanlu benceruleanlu left review comments

@pythongosssss pythongosssss Awaiting requested review from pythongosssss pythongosssss is a code owner

@PabloWiedemann PabloWiedemann Awaiting requested review from PabloWiedemann

@snomiao snomiao Awaiting requested review from snomiao

Assignees

No one assigned

Labels

core/1.34 Backport PRs for core 1.34 Design Used to request Product feedback on design decisions needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DrJKL @benceruleanlu @christian-byrne @AustinMroz