Skip to content

fix: loading api-format workflow that contains "parameters" string #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 8 commits into from
Dec 13, 2025
Merged

fix: loading api-format workflow that contains "parameters" string #7411

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
429d242
fix api format workflow loading with parameters
christian-byrne Dec 12, 2025
767f141
Handle prompt parsing errors before A1111 fallback
christian-byrne Dec 12, 2025
d18a9c7
make type gaurd syntax
christian-byrne Dec 13, 2025
2c76be9
Drop redundant ComfyApiWorkflow cast
christian-byrne Dec 13, 2025
2546bcc
Ensure API prompt inputs are plain objects
christian-byrne Dec 13, 2025
4c83edc
[automated] Update test expectations
invalid-email-address Dec 13, 2025
d562423
Update src/scripts/app.ts
christian-byrne Dec 13, 2025
8eb36fb
Update src/scripts/app.ts
christian-byrne Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make type gaurd syntax
  • Loading branch information
@christian-byrne
christian-byrne committed Dec 13, 2025
commit d18a9c73a3a3968c100e96d63c74b54cc651acac
15 changes: 13 additions & 2 deletions src/scripts/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,8 +1499,19 @@ export class ComfyApp {
}

// @deprecated
isApiJson(data: unknown) {
return _.isObject(data) && Object.values(data).every((v) => v.class_type)
isApiJson(data: unknown): data is ComfyApiWorkflow {
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Remove @deprecated tag or provide migration path.

The method is marked as deprecated but is actively used in the new prompt-handling code (line 1475). Either remove the deprecation tag if the method is still needed, or provide an alternative and update the calling code.

🤖 Prompt for AI Agents 
In src/scripts/app.ts around line 1502, the type-guard method isApiJson is
marked @deprecated but is still used by the new prompt-handling code (caller at
~line 1475); remove the @deprecated annotation if this API is intended to
remain, or instead add/implement the recommended replacement function and update
the caller(s) to use that new API; ensure the signature/behavior matches the
caller expectations (or adjust the caller) and update any JSDoc/tsdoc to reflect
the chosen migration path.

if (!_.isObject(data) || Array.isArray(data)) {
return false
}

return Object.values(data).every((node) => {
if (!node || typeof node !== 'object' || Array.isArray(node)) {
return false
}

const { class_type: classType, inputs } = node as Record<string, unknown>
return typeof classType === 'string' && _.isObject(inputs)
})
}

loadApiJson(apiData: ComfyApiWorkflow, fileName: string) {
Expand Down
Loading