Component: Button migration 1: TextButton #7537
Conversation
📝 WalkthroughWalkthroughReplaces a legacy slot-less TextButton with a new slot-based Button component across the codebase, adds a CVA-based button variants module and Storybook stories for Button, and introduces the Changes
Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
💤 Files with no reviewable changes (2)
🧰 Additional context used📓 Path-based instructions (13)src/**/*.vue📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/{composables,components}/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/{components,composables}/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/components/**/*.vue📄 CodeRabbit inference engine (src/components/CLAUDE.md)
Files:
src/components/**/*.{vue,css}📄 CodeRabbit inference engine (src/components/CLAUDE.md)
Files:
src/components/**/*.{vue,ts,js}📄 CodeRabbit inference engine (src/components/CLAUDE.md)
Files:
src/**/*.{js,ts,tsx,vue}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/**/*.{ts,tsx,vue,js}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/**/*.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (65)📓 Common learnings📚 Learning: 2025-12-16T22:21:59.236ZApplied to files:
📚 Learning: 2025-12-09T03:50:03.127ZApplied to files:
📚 Learning: 2025-12-11T12:25:24.164ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-05T06:11:09.383ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-11-24T19:47:34.324ZApplied to files:
📚 Learning: 2025-12-16T17:30:24.744ZApplied to files:
📚 Learning: 2025-12-09T21:40:19.792ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-09T03:49:52.828ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-16T22:26:49.463ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:34.324ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-09T21:40:12.361ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-04T21:43:49.363ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-05T08:52:50.787ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-01T23:42:30.894ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T00:40:09.635ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-09T03:39:54.501ZApplied to files:
📚 Learning: 2025-12-13T11:03:11.264ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-04T21:47:07.812ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-17T01:01:03.597ZApplied to files:
📚 Learning: 2025-12-16T17:41:58.455ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2025-12-16T22:26:49.463ZApplied to files:
🧬 Code graph analysis (1)src/components/ui/button/Button.stories.ts (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (27)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/17/2025, 03:30:50 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 12/17/2025, 03:39:35 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
DrJKL
force-pushed
the
drjkl/button-button
branch
from
434303a to
0ac1b78
Compare
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.21 MB (baseline 3.2 MB) • 🔴 +1.19 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 992 kB (baseline 992 kB) • 🔴 +230 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 184 kB (baseline 183 kB) • 🔴 +424 BReusable component library chunks
Status: 10 added / 10 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.45 MB (baseline 8.45 MB) • 🔴 +3.35 kBExternal libraries and shared vendor chunks
Status: 5 added / 5 removed Other — 3.41 MB (baseline 3.41 MB) • ⚪ 0 BBundles that do not match a named category
Status: 24 added / 24 removed |
DrJKL
force-pushed
the
drjkl/button-button
branch
3 times, most recently
from
70395ba to
00de47f
Compare
DrJKL
changed the title
dosubot
bot
added
the
size:XL
DrJKL
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 11
♻️ Duplicate comments (1)
src/components/input/MultiSelect.vue (1)
115-122: Verify prop name:subtypevsvariant.Similar to
ConfirmFooter.vue, this file usessubtype="textonly"butbutton.variants.tsdefines avariantprop with "textonly" as a value. Please verify whethersubtypeis the correct prop name or if it should bevariant.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
package.json(1 hunks)pnpm-workspace.yaml(1 hunks)src/components/button/TextButton.stories.ts(0 hunks)src/components/button/TextButton.vue(0 hunks)src/components/dialog/confirm/ConfirmFooter.vue(1 hunks)src/components/dialog/content/MissingNodesFooter.vue(2 hunks)src/components/input/MultiSelect.vue(3 hunks)src/components/queue/QueueOverlayActive.vue(2 hunks)src/components/queue/dialogs/QueueClearHistoryDialog.vue(2 hunks)src/components/queue/job/JobFiltersBar.vue(2 hunks)src/components/queue/job/QueueJobItem.vue(2 hunks)src/components/sidebar/tabs/AssetsSidebarTab.vue(3 hunks)src/components/ui/button/Button.stories.ts(1 hunks)src/components/ui/button/Button.vue(1 hunks)src/components/ui/button/button.variants.ts(1 hunks)src/platform/assets/components/UploadModelFooter.vue(3 hunks)src/platform/assets/components/UploadModelUpgradeModalFooter.vue(1 hunks)
💤 Files with no reviewable changes (2)
- src/components/button/TextButton.stories.ts
- src/components/button/TextButton.vue
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsVue component file names must use PascalCase; for example,
MenuHamburger.vue
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use<script setup lang="ts">for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
PreferuseModelto separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using<style>blocks in Vue components
Use semantic Tailwind values fromstyle.csstheme instead of thedark:variant; for example, usebg-node-component-surfaceinstead ofdark:prefixes
Always usecn()utility from@/utils/tailwindUtilto merge Tailwind class names; do not use:class="[]"syntax
Usereffor reactive state in Vue Composition API components
Implement computed properties withcomputed()from Vue; avoid using arefwith awatchif acomputedwould work instead
UsewatchandwatchEffectfor side effects in Vue components
Implement lifecycle hooks usingonMounted,onUpdated, and other Vue lifecycle functions
Useprovide/injectfor dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundantcomputed, and prefercomputedoverwatch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries insrc/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
**/*.{ts,tsx,js,jsx,vue,json}
📄 CodeRabbit inference engine (AGENTS.md)
Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see
.prettierrc)
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vuepackage.json
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; runpnpm formatbefore committing
Use TypeScript for type safety; never useanytype - use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nestediforforstatements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safetyMinimize the surface area (exported values) of each module and composable
Files:
src/components/ui/button/Button.stories.tssrc/components/ui/button/button.variants.ts
🧠 Learnings (43)
📓 Common learnings
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-04T21:47:07.812Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use Teleport/Suspense when needed for component rendering
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/ui/button/Button.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/ui/button/Button.stories.tssrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/ui/button/button.variants.tssrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/components/input/MultiSelect.vuesrc/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Calendar component with DatePicker
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/components/input/MultiSelect.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Vue components must use `<script setup lang="ts">` for component logic
Applied to files:
src/components/input/MultiSelect.vuesrc/components/ui/button/Button.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use VueUse functions for performance-enhancing styles
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Applied to files:
src/components/input/MultiSelect.vuesrc/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Applied to files:
src/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use vue-i18n in composition API for any string literals; place new translation entries in `src/locales/en/main.json`
Applied to files:
src/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use `ref` for reactive state in Vue Composition API components
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use ref/reactive for state management in Vue 3 Composition API
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Be judicious with addition of new refs or other state: prefer props, avoid redundant `computed`, and prefer `computed` over `watch`
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Implement computed properties with `computed()` from Vue; avoid using a `ref` with a `watch` if a `computed` would work instead
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.test.ts : For Component testing, use Vue Test Utils and follow advice about making components easy to test
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not use `withDefaults` or runtime props declaration
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
src/components/ui/button/Button.vuesrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use vue 3.5 style of default prop declaration
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Applied to files:
src/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T03:50:03.127Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-16T17:30:24.744Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7559
File: .storybook/preview.ts:61-61
Timestamp: 2025-12-16T17:30:24.744Z
Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/components/ui/button/Button.stories.tssrc/components/ui/button/button.variants.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/components/ui/button/Button.stories.tssrc/components/ui/button/button.variants.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Prefer emit/event-name for state changes over other communication patterns
Applied to files:
src/platform/assets/components/UploadModelUpgradeModalFooter.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Applied to files:
src/components/queue/QueueOverlayActive.vue
🧬 Code graph analysis (1)
src/components/ui/button/Button.stories.ts (1)
src/components/ui/button/button.variants.ts (1)
FOR_STORIES(49-49)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: playwright-tests-chromium-sharded (7, 8)
- GitHub Check: playwright-tests-chromium-sharded (8, 8)
- GitHub Check: playwright-tests-chromium-sharded (6, 8)
- GitHub Check: playwright-tests-chromium-sharded (4, 8)
- GitHub Check: playwright-tests-chromium-sharded (1, 8)
- GitHub Check: playwright-tests-chromium-sharded (5, 8)
- GitHub Check: playwright-tests-chromium-sharded (3, 8)
- GitHub Check: playwright-tests-chromium-sharded (2, 8)
- GitHub Check: playwright-tests (mobile-chrome)
- GitHub Check: playwright-tests (chromium-0.5x)
🔇 Additional comments (8)
package.json (1)
164-164: LGTM! CVA dependency added correctly.The catalog-based dependency addition for
cvaaligns with the new Button component's variant system.src/components/ui/button/button.variants.ts (1)
1-49: LGTM! Well-structured variant definitions with good TypeScript practices.The CVA configuration is clean and uses semantic tokens from the design system. The type safety with
satisfiesand theFOR_STORIESexport for Storybook are excellent practices.src/platform/assets/components/UploadModelUpgradeModalFooter.vue (1)
12-17: LGTM! Clean migration to the new Button component.The migration correctly uses the
variantprop and slot-based content rendering, aligning with the new Button API.Also applies to: 22-22
src/components/queue/QueueOverlayActive.vue (1)
83-90: LGTM! Correct usage of the new Button component.The Button correctly uses
variant="secondary"andsize="sm"props that match the variant definitions inbutton.variants.ts.Also applies to: 100-100
src/components/sidebar/tabs/AssetsSidebarTab.vue (1)
115-128: LGTM! Clean migration with proper class merging.The Button correctly uses
variant="secondary"andsize="lg", and thecn()helper properly merges conditional classes. All imports are correct.Also applies to: 184-184, 195-195, 208-210
src/components/input/MultiSelect.vue (1)
162-166: LGTM! Appropriate use of PrimeVue Button for internal rendering.Using
PVButton(PrimeVue Button) for option label rendering is appropriate here, as it maintains compatibility with PrimeVue's internal slot requirements while the header action uses the newButtoncomponent.Also applies to: 175-175, 182-182
src/components/queue/job/QueueJobItem.vue (1)
157-164: LGTM: Button migration is correct.The migration from TextButton to Button is implemented correctly with proper variant, size props and slot-based label content using i18n.
src/components/dialog/content/MissingNodesFooter.vue (1)
21-23: LGTM: Button usage is correct.This Button migration uses properly defined props (variant, size) with slot-based content.
dosubot
bot
added
size:L
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/components/ui/button/Button.stories.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/components/ui/button/Button.stories.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safetyMinimize the surface area (exported values) of each module and composable
Files:
src/components/ui/button/Button.stories.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/components/ui/button/Button.stories.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/ui/button/Button.stories.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/ui/button/Button.stories.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/ui/button/Button.stories.ts
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/ui/button/Button.stories.ts
**/*.{ts,tsx,js,jsx,vue,json}
📄 CodeRabbit inference engine (AGENTS.md)
Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see
.prettierrc)
Files:
src/components/ui/button/Button.stories.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; runpnpm formatbefore committing
Use TypeScript for type safety; never useanytype - use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nestediforforstatements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/components/ui/button/Button.stories.ts
🧠 Learnings (10)
📓 Common learnings
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: pnpm-workspace.yaml:50-50
Timestamp: 2025-12-16T22:21:59.236Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, the project uses cva1.0.0-beta.4 (beta version) by deliberate choice. Do not suggest replacing it with class-variance-authority or flagging it as a beta dependency concern.
📚 Learning: 2025-12-09T21:40:19.792Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:19.792Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, inline Tailwind CSS class strings, even when long, are acceptable and preferred over extracting them to computed properties when the classes are static. This is a common Tailwind pattern and doesn't need to be flagged as a readability issue.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-16T17:30:24.744Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7559
File: .storybook/preview.ts:61-61
Timestamp: 2025-12-16T17:30:24.744Z
Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use Tailwind 4 utility classes for styling; avoid using `<style>` blocks in Vue components
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-01T23:42:30.894Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7084
File: src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue:23-26
Timestamp: 2025-12-01T23:42:30.894Z
Learning: In the ComfyUI frontend codebase, Tailwind CSS is configured with Preflight enabled (default), which automatically provides `content: ''` for pseudo-elements when using `after:` or `before:` variants - no need to explicitly add `after:content-['']`.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T03:50:03.127Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/ui/button/Button.stories.ts
🧬 Code graph analysis (1)
src/components/ui/button/Button.stories.ts (2)
src/components/ui/button/button.variants.ts (1)
FOR_STORIES(49-49)src/components/input/SingleSelect.stories.ts (1)
Story(40-40)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Socket Security: Pull Request Alerts
🔇 Additional comments (2)
src/components/ui/button/Button.stories.ts (2)
1-4: LGTM: Imports are properly structured.The imports follow TypeScript best practices with separate type imports and correct module paths.
38-43: LGTM: Standard Storybook story pattern.The SingleButton story is correctly structured with appropriate args.
DrJKL
force-pushed
the
drjkl/button-button
branch
from
46242f2 to
d29b5ab
Compare
[automated] Apply ESLint and Prettier fixes
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (17)
package.json(1 hunks)pnpm-workspace.yaml(1 hunks)src/components/button/TextButton.stories.ts(0 hunks)src/components/button/TextButton.vue(0 hunks)src/components/dialog/confirm/ConfirmFooter.vue(1 hunks)src/components/dialog/content/MissingNodesFooter.vue(2 hunks)src/components/input/MultiSelect.vue(3 hunks)src/components/queue/QueueOverlayActive.vue(2 hunks)src/components/queue/dialogs/QueueClearHistoryDialog.vue(2 hunks)src/components/queue/job/JobFiltersBar.vue(2 hunks)src/components/queue/job/QueueJobItem.vue(2 hunks)src/components/sidebar/tabs/AssetsSidebarTab.vue(3 hunks)src/components/ui/button/Button.stories.ts(1 hunks)src/components/ui/button/Button.vue(1 hunks)src/components/ui/button/button.variants.ts(1 hunks)src/platform/assets/components/UploadModelFooter.vue(3 hunks)src/platform/assets/components/UploadModelUpgradeModalFooter.vue(1 hunks)
💤 Files with no reviewable changes (2)
- src/components/button/TextButton.vue
- src/components/button/TextButton.stories.ts
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsVue component file names must use PascalCase; for example,
MenuHamburger.vue
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use<script setup lang="ts">for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
PreferuseModelto separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using<style>blocks in Vue components
Use semantic Tailwind values fromstyle.csstheme instead of thedark:variant; for example, usebg-node-component-surfaceinstead ofdark:prefixes
Always usecn()utility from@/utils/tailwindUtilto merge Tailwind class names; do not use:class="[]"syntax
Usereffor reactive state in Vue Composition API components
Implement computed properties withcomputed()from Vue; avoid using arefwith awatchif acomputedwould work instead
UsewatchandwatchEffectfor side effects in Vue components
Implement lifecycle hooks usingonMounted,onUpdated, and other Vue lifecycle functions
Useprovide/injectfor dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundantcomputed, and prefercomputedoverwatch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries insrc/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
**/*.{ts,tsx,js,jsx,vue,json}
📄 CodeRabbit inference engine (AGENTS.md)
Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see
.prettierrc)
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tspackage.jsonsrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; runpnpm formatbefore committing
Use TypeScript for type safety; never useanytype - use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nestediforforstatements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safetyMinimize the surface area (exported values) of each module and composable
Files:
src/components/ui/button/button.variants.tssrc/components/ui/button/Button.stories.ts
🧠 Learnings (66)
📓 Common learnings
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
📚 Learning: 2025-12-16T22:21:59.236Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: pnpm-workspace.yaml:50-50
Timestamp: 2025-12-16T22:21:59.236Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, the project uses cva1.0.0-beta.4 (beta version) by deliberate choice. Do not suggest replacing it with class-variance-authority or flagging it as a beta dependency concern.
Applied to files:
pnpm-workspace.yamlpackage.json
📚 Learning: 2025-12-09T03:50:03.127Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:50:03.127Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, when avoiding PrimeVue components, prefer using the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) rather than plain HTML buttons. These components wrap PrimeVue with custom design system styling.
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vue
📚 Learning: 2025-12-11T12:25:24.164Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:24.164Z
Learning: The project has CI automation that handles code formatting (pnpm format) automatically, so manual formatting suggestions should not be provided in code reviews for the Comfy-Org/ComfyUI_frontend repository.
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-12-05T06:11:09.383Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/Button.vuesrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-16T17:30:24.744Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7559
File: .storybook/preview.ts:61-61
Timestamp: 2025-12-16T17:30:24.744Z
Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/button.variants.tssrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Be judicious with addition of new refs or other state: prefer props, avoid redundant `computed`, and prefer `computed` over `watch`
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/Button.vuesrc/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T21:40:19.792Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:19.792Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, inline Tailwind CSS class strings, even when long, are acceptable and preferred over extracting them to computed properties when the classes are static. This is a common Tailwind pattern and doesn't need to be flagged as a readability issue.
Applied to files:
pnpm-workspace.yamlsrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not use `withDefaults` or runtime props declaration
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Vue components must use `<script setup lang="ts">` for component logic
Applied to files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Destructure props using Vue 3.5 style in Vue components
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-12-04T21:43:49.363Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/rightSidePanel/parameters/TabParameters.vue:10-0
Timestamp: 2025-12-04T21:43:49.363Z
Learning: Vue 3.5+ supports reactive props destructure in <script setup>. Destructuring props directly (e.g., `const { nodes } = defineProps<{ nodes: LGraphNode[] }>()`) maintains reactivity through compiler transformation. This is the recommended modern approach and does not require using `props.x` or `toRef`/`toRefs`.
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use vue 3.5 style of default prop declaration
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : In Vue Components, implement proper props and emits definitions
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement proper props and emits definitions
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Define proper props and emits definitions in Vue components
Applied to files:
src/components/ui/button/Button.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Prefer `useModel` to separately defining a prop and emit
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use setup() function in Vue 3 Composition API
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Prefer emit/event-name for state changes over other communication patterns
Applied to files:
src/components/ui/button/Button.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use setup() function for component logic
Applied to files:
src/components/ui/button/Button.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Applied to files:
src/components/ui/button/Button.vuesrc/components/queue/QueueOverlayActive.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/ui/button/Button.vuesrc/components/input/MultiSelect.vuesrc/components/ui/button/button.variants.tssrc/components/dialog/content/MissingNodesFooter.vuesrc/components/ui/button/Button.stories.tssrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Calendar component with DatePicker
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/QueueOverlayActive.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/platform/assets/components/UploadModelUpgradeModalFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/confirm/ConfirmFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/platform/assets/components/UploadModelFooter.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/components/input/MultiSelect.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings
Applied to files:
src/components/input/MultiSelect.vuesrc/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use VueUse functions for performance-enhancing styles
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with `<script setup>`, when using `defineProps<Props>()` with partial destructuring (e.g., `const { as = 'button', class: customClass = '' } = defineProps<Props>()`), props that are NOT destructured (like `variant` and `size` in this example) remain accessible by name in the template scope. It's valid to destructure only some props for convenience while accessing others directly in expressions.
Applied to files:
src/components/ui/button/button.variants.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/components/ui/button/button.variants.tssrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/components/ui/button/button.variants.tssrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/components/ui/button/button.variants.tssrc/components/ui/button/Button.stories.ts
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Applied to files:
src/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Applied to files:
src/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use vue-i18n in composition API for any string literals; place new translation entries in `src/locales/en/main.json`
Applied to files:
src/components/dialog/content/MissingNodesFooter.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use Tailwind 4 utility classes for styling; avoid using `<style>` blocks in Vue components
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-01T23:42:30.894Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7084
File: src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue:23-26
Timestamp: 2025-12-01T23:42:30.894Z
Learning: In the ComfyUI frontend codebase, Tailwind CSS is configured with Preflight enabled (default), which automatically provides `content: ''` for pseudo-elements when using `after:` or `before:` variants - no need to explicitly add `after:content-['']`.
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.{ts,tsx,vue} : Minimize nesting in code (e.g., deeply nested `if` or `for` statements); apply the Arrow Anti-Pattern principle
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.{ts,tsx,vue} : Keep functions short and functional
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.{ts,tsx,vue} : Favor pure functions, especially testable ones
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.{ts,tsx,vue} : Avoid mutable state; prefer immutability and assignment at point of declaration
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Always use `cn()` utility from `@/utils/tailwindUtil` to merge Tailwind class names; do not use `:class="[]"` syntax
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use Tailwind CSS for styling
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use semantic Tailwind values from `style.css` theme instead of the `dark:` variant; for example, use `bg-node-component-surface` instead of `dark:` prefixes
Applied to files:
src/components/ui/button/Button.stories.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/components/dialog/confirm/ConfirmFooter.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/queue/QueueOverlayActive.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Applied to files:
src/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/JobFiltersBar.vuesrc/components/queue/QueueOverlayActive.vuesrc/components/queue/job/QueueJobItem.vue
📚 Learning: 2025-12-04T21:47:07.812Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.
Applied to files:
src/components/sidebar/tabs/AssetsSidebarTab.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use `ref` for reactive state in Vue Composition API components
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use ref/reactive for state management in Vue 3 Composition API
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Implement computed properties with `computed()` from Vue; avoid using a `ref` with a `watch` if a `computed` would work instead
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.test.ts : For Component testing, use Vue Test Utils and follow advice about making components easy to test
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/platform/assets/components/UploadModelFooter.vue
🧬 Code graph analysis (1)
src/components/ui/button/Button.stories.ts (2)
src/components/ui/button/button.variants.ts (1)
FOR_STORIES(49-49)src/components/input/SingleSelect.stories.ts (1)
Story(40-40)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: test
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: collect
🔇 Additional comments (13)
src/components/sidebar/tabs/AssetsSidebarTab.vue (1)
115-128: LGTM! Clean migration to Button component.The Button replacement correctly uses variant/size props, moves label content to the slot with proper i18n integration, and applies conditional styling via
cn(). The implementation follows the project's migration pattern consistently.src/platform/assets/components/UploadModelUpgradeModalFooter.vue (1)
12-17: LGTM! Button migration properly implemented.Both buttons correctly use the new Button API with appropriate variants (textonly/secondary), proper event emission, and i18n labels in slots. The implementation is clean and consistent with the migration pattern.
src/components/ui/button/Button.vue (1)
1-28: LGTM! Well-designed Button component.The implementation is clean and follows all coding guidelines:
- Uses reka-ui Primitive (avoiding PrimeVue as per guidelines)
- Proper TypeScript types with extends PrimitiveProps
- Correct Vue 3.5 props destructuring pattern (partial destructuring valid per learning)
- Integrates buttonVariants for consistent styling
- Simple, focused component with slot-based content
src/components/queue/job/QueueJobItem.vue (1)
157-164: LGTM! Button migration correctly implemented.The View button properly uses the textonly variant with sm size, maintains custom styling, and correctly emits the 'view' event. The i18n label is properly placed in the slot. Implementation is consistent with the migration pattern.
src/components/input/MultiSelect.vue (1)
115-122: LGTM! Clear button migration is correct.The clear action properly uses the new Button component with textonly variant and md size. The i18n label is correctly placed in the slot, and the click handler is preserved. Implementation follows the migration pattern.
src/components/queue/dialogs/QueueClearHistoryDialog.vue (1)
34-44: LGTM! Dialog buttons correctly migrated.Both buttons properly implement the new Button API:
- Cancel uses muted-textonly variant (confirmed valid in past review)
- Clear uses secondary variant with proper disabled state binding
- Event handlers correctly maintained
- i18n labels properly placed in slots
The implementation is clean and consistent with the migration pattern.
src/components/dialog/confirm/ConfirmFooter.vue (1)
3-13: LGTM! Button migration correctly implemented.Both cancel and confirm buttons now use the correct
variant="textonly"prop, with labels properly rendered as slot content. The disabled state and event emissions are preserved correctly.src/components/queue/QueueOverlayActive.vue (1)
83-90: LGTM! Button migration correctly implemented.The "View All Jobs" button correctly uses
variant="secondary"andsize="sm", with the label properly rendered as slot content using vue-i18n.src/components/ui/button/Button.stories.ts (1)
1-68: LGTM! Storybook configuration is well-structured.The story configuration correctly:
- Defines argTypes with proper controls for variant and size
- Uses a pure function declaration for
generateVariants()- Renders all variant/size combinations in a static grid layout
- Leverages
FOR_STORIESfrom the variants module for type safetysrc/components/ui/button/button.variants.ts (1)
4-49: LGTM! Variant configuration is well-designed.The CVA-based button variants correctly:
- Define comprehensive base styles with focus-visible, disabled, and SVG styling
- Provide six semantic variants (secondary, primary, inverted, destructive, textonly, muted-textonly) using theme tokens
- Define four size options (sm, md, lg, icon) with appropriate dimensions
- Export type-safe arrays for Storybook consumption via
FOR_STORIES- Use
satisfiesoperator for compile-time type checkingsrc/platform/assets/components/UploadModelFooter.vue (1)
16-25: LGTM! Button migrations correctly implemented.All three buttons (cancel, back, finish) now use the correct Button component with:
- Proper
variantprops (muted-textonly for cancel/back, secondary for finish)- Appropriate
sizeprops where specified- Labels correctly rendered as slot content with vue-i18n
- Disabled states and event emissions preserved
Also applies to: 26-35, 70-77
src/components/queue/job/JobFiltersBar.vue (1)
5-14: LGTM! Button migration correctly implemented with dynamic variant.The job filter tabs correctly:
- Use conditional
variantprop (secondary when selected, muted-textonly otherwise)- Apply consistent
size="sm"andclass="px-3"- Render tab labels as slot content with proper i18n via
tabLabel(tab)- Emit update events on click
src/components/dialog/content/MissingNodesFooter.vue (1)
21-23: LGTM! Button migrations correctly implemented.Both buttons (Cloud "Got It" and OSS "Open Manager") now use the correct Button component with:
- Proper
variantprops (secondary for Cloud mode, textonly for OSS mode)- Appropriate
sizeprops (md and sm respectively)- Labels correctly rendered as slot content with vue-i18n
Also applies to: 28-30
DrJKL
force-pushed
the
drjkl/button-button
branch
from
d29b5ab to
e88c84d
Compare
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
There is definitely going to be some things diverging very slightly from designs, but for the better in the long run mostly likely + a lot of these things were implemented a long time ago.
src/components/input/MultiSelect.vue
Outdated
| import { useFuse } from '@vueuse/integrations/useFuse' | ||
| import type { UseFuseOptions } from '@vueuse/integrations/useFuse' | ||
| import Button from 'primevue/button' | ||
| import PVButton from 'primevue/button' |
There was a problem hiding this comment.
Ever better to use as so the alias is explicit?
There was a problem hiding this comment.
Gave it another look, I think it was just being used to get a pointer cursor. If you check the new behavior of MultiSelect in Storybook we shouldn't need the primevue/button anymore.
dosubot
bot
added
size:XL
Summary
Setup the variants and migrate existing uses of TextButton/TextIconButton/IconButton to a single Button component.
Still a work in progress.
Changes
Review Focus
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito