[feat] Add HuggingFace model import support #7540
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,29 @@ | ||
| <template> | ||
| <div class="flex items-center gap-2 p-4 font-bold"> | ||
| <img | ||
| v-if="!flags.huggingfaceModelImportEnabled" | ||
| src="/assets/images/civitai.svg" | ||
| class="size-4" | ||
| /> | ||
| <span>{{ $t(titleKey) }}</span> | ||
| <span | ||
| class="rounded-full bg-white px-1.5 py-0 text-xxs font-inter font-semibold uppercase text-black" | ||
| > | ||
| {{ $t('g.beta') }} | ||
| </span> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { computed } from 'vue' | ||
|
|
||
| import { useFeatureFlags } from '@/composables/useFeatureFlags' | ||
|
|
||
| const { flags } = useFeatureFlags() | ||
|
|
||
| const titleKey = computed(() => { | ||
| return flags.huggingfaceModelImportEnabled | ||
| ? 'assetBrowser.uploadModelGeneric' | ||
| : 'assetBrowser.uploadModelFromCivitai' | ||
| }) | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <template> | ||
| <div class="flex flex-col gap-6 text-sm text-muted-foreground"> | ||
| <div class="flex flex-col gap-2"> | ||
| <p class="m-0"> | ||
| {{ $t('assetBrowser.uploadModelDescription1') }} | ||
| </p> | ||
| <ul class="list-disc space-y-1 pl-5 mt-0"> | ||
| <li v-html="$t('assetBrowser.uploadModelDescription2')" /> | ||
| <li v-html="$t('assetBrowser.uploadModelDescription3')" /> | ||
| </ul> | ||
| </div> | ||
|
|
||
| <div class="flex flex-col gap-2"> | ||
| <label class="mb-0" v-html="$t('assetBrowser.civitaiLinkLabel')"> </label> | ||
| <InputText | ||
| v-model="url" | ||
| autofocus | ||
| :placeholder="$t('assetBrowser.civitaiLinkPlaceholder')" | ||
| class="w-full bg-secondary-background border-0 p-4" | ||
| data-attr="upload-model-step1-url-input" | ||
| /> | ||
| <p v-if="error" class="text-xs text-error"> | ||
| {{ error }} | ||
| </p> | ||
| <p v-else v-html="$t('assetBrowser.civitaiLinkExample')"></p> | ||
| </div> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import InputText from 'primevue/inputtext' | ||
| import { computed } from 'vue' | ||
| const props = defineProps<{ | ||
| modelValue: string | ||
| error?: string | ||
| }>() | ||
| const emit = defineEmits<{ | ||
| 'update:modelValue': [value: string] | ||
| }>() | ||
| const url = computed({ | ||
|
Member
There was a problem hiding this comment. nit: could use defineModel here |
||
| get: () => props.modelValue, | ||
| set: (value: string) => emit('update:modelValue', value) | ||
| }) | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid embedded HTML in i18n strings.
Line 2308 contains embedded HTML markup in the translation string:
This pattern was previously flagged and marked as addressed (commits 6e291e6 to ae03cc9), but has reappeared in the new keys. Embedding HTML in translations breaks i18n best practices because:
Refactor to use template parameters:
Then apply the styling in the Vue component that uses this string. For example:
Or use i18n's built-in formatting to inject styled content.
🤖 Prompt for AI Agents