Skip to content

Fix: Restore assets API short-circuit in WidgetSelectDropdown #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DrJKL merged 1 commit into from
Dec 16, 2025
Merged

Fix: Restore assets API short-circuit in WidgetSelectDropdown #7563

DrJKL merged 1 commit into from
Dec 16, 2025
+3 −0

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Dec 16, 2025 •
edited by sync-by-unito bot
Loading

Summary

Removed in #6985, but breaks the dropdown loading on Cloud.

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested a review from a team as a code owner December 16, 2025 19:13
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 16, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

A dropdown widget component's allItems property now conditionally returns precomputed asset dropdown items when asset mode is active, otherwise falls back to concatenating input and output items.

Changes

Cohort / File(s) Summary
Widget dropdown asset mode
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue		 Modified allItems computed property to prioritize assetData.dropdownItems.value when isAssetMode is active, with fallback to concatenated input/output items
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drjkl/fix/assets-dropdown
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6391bd8 and 9c484fc.

📒 Files selected for processing (1)
  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue (1 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
**/*.vue

📄 CodeRabbit inference engine (AGENTS.md)

**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use <script setup lang="ts"> for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not use withDefaults or runtime props declaration
Prefer useModel to separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using <style> blocks in Vue components
Use semantic Tailwind values from style.css theme instead of the dark: variant; for example, use bg-node-component-surface instead of dark: prefixes
Always use cn() utility from @/utils/tailwindUtil to merge Tailwind class names; do not use :class="[]" syntax
Use ref for reactive state in Vue Composition API components
Implement computed properties with computed() from Vue; avoid using a ref with a watch if a computed would work instead
Use watch and watchEffect for side effects in Vue components
Implement lifecycle hooks using onMounted, onUpdated, and other Vue lifecycle functions
Use provide/inject for dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundant computed, and prefer computed over watch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries in src/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
**/*.{ts,tsx,js,jsx,vue,json}

📄 CodeRabbit inference engine (AGENTS.md)

Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see .prettierrc)

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; run pnpm format before committing
Use TypeScript for type safety; never use any type - use proper TypeScript types
Never use as any type assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nested if or for statements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones

Files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
🧠 Learnings (5)
📚 Learning: 2025-11-24T19:47:45.616Z 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-09T03:49:52.828Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-09T21:40:12.361Z 
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-11T03:55:51.755Z 
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-11T12:25:15.470Z 
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

  • src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: lint-and-format
  • GitHub Check: test
  • GitHub Check: setup
  • GitHub Check: collect
🔇 Additional comments (1)
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue (1)

149-151: Restore the asset mode short-circuit in the allItems computed property.

The property path assetData.dropdownItems.value is correct—useAssetWidgetData returns a computed ref, and the defensive check for both props.isAssetMode and assetData existence is appropriate. This restoration properly fixes the Cloud dropdown loading regression from #6985 and falls back correctly to the combined input/output items when asset mode is inactive.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/16/2025, 07:15:33 PM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/16/2025, 07:36:43 PM UTC

📈 Summary

  • Total Tests: 506
  • Passed: 495 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 483 / ❌ 0 / ⚠️ 2 / ⏭️ 9
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@DrJKL DrJKL enabled auto-merge (squash) December 16, 2025 19:15
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Bundle Size Report

Summary

  • Raw size: 17.1 MB baseline 17.1 MB — 🔴 +98 B
  • Gzip: 3.39 MB baseline 3.39 MB — 🟢 -43 B
  • Brotli: 2.6 MB baseline 2.6 MB — 🔴 +335 B
  • Bundles: 98 current • 98 baseline • 40 added / 40 removed

Category Glance
UI Components 🔴 +98 B (184 kB) · Vendor & Third-Party ⚪ 0 B (8.56 MB) · Other ⚪ 0 B (3.75 MB) · App Entry Points ⚪ 0 B (3.25 MB) · Graph Workspace ⚪ 0 B (992 kB) · Panels & Settings ⚪ 0 B (299 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.25 MB (baseline 3.25 MB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BQBLYm5V.js (removed) 3.02 MB — 🟢 -3.02 MB 🟢 -628 kB 🟢 -478 kB
assets/index-R1wRoN1c.js (new) — 3.02 MB 🔴 +3.02 MB 🔴 +628 kB 🔴 +478 kB
assets/index-BiDGXtBJ.js (removed) 227 kB — 🟢 -227 kB 🟢 -48.6 kB 🟢 -39.8 kB
assets/index-DCHDTBX9.js (new) — 227 kB 🔴 +227 kB 🔴 +48.6 kB 🔴 +39.9 kB
assets/index-B_fH6Kf6.js (new) — 345 B 🔴 +345 B 🔴 +245 B 🔴 +231 B
assets/index-D1d4SRPu.js (removed) 345 B — 🟢 -345 B 🟢 -246 B 🟢 -235 B

Status: 3 added / 3 removed

Graph Workspace — 992 kB (baseline 992 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BsX7VlBL.js (removed) 992 kB — 🟢 -992 kB 🟢 -192 kB 🟢 -147 kB
assets/GraphView-DlPG243a.js (new) — 992 kB 🔴 +992 kB 🔴 +192 kB 🔴 +147 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-CbW0zwwH.js (removed) 6.54 kB — 🟢 -6.54 kB 🟢 -2.14 kB 🟢 -1.89 kB
assets/UserSelectView-D5uJ_SL2.js (new) — 6.54 kB 🔴 +6.54 kB 🔴 +2.13 kB 🔴 +1.89 kB

Status: 1 added / 1 removed

Panels & Settings — 299 kB (baseline 299 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/LegacyCreditsPanel-BYdYzx7k.js (new) — 21.4 kB 🔴 +21.4 kB 🔴 +5.15 kB 🔴 +4.49 kB
assets/LegacyCreditsPanel-hfvgLNg_.js (removed) 21.4 kB — 🟢 -21.4 kB 🟢 -5.15 kB 🟢 -4.5 kB
assets/KeybindingPanel-BX5QdBKO.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.42 kB 🟢 -3.02 kB
assets/KeybindingPanel-CArpfV3q.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.42 kB 🔴 +3.01 kB
assets/ExtensionPanel-BS6OEaCW.js (removed) 10.8 kB — 🟢 -10.8 kB 🟢 -2.57 kB 🟢 -2.26 kB
assets/ExtensionPanel-lsev16Zz.js (new) — 10.8 kB 🔴 +10.8 kB 🔴 +2.57 kB 🔴 +2.25 kB
assets/AboutPanel-CwF8DvxH.js (new) — 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.21 kB
assets/AboutPanel-DJV3xLDW.js (removed) 9.16 kB — 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/ServerConfigPanel-BjdsyDPK.js (removed) 7.07 kB — 🟢 -7.07 kB 🟢 -1.98 kB 🟢 -1.77 kB
assets/ServerConfigPanel-Bv3GGSQ2.js (new) — 7.07 kB 🔴 +7.07 kB 🔴 +1.98 kB 🔴 +1.77 kB
assets/UserPanel-BNls0kE3.js (removed) 6.23 kB — 🟢 -6.23 kB 🟢 -1.72 kB 🟢 -1.51 kB
assets/UserPanel-IuIyJpFc.js (new) — 6.23 kB 🔴 +6.23 kB 🔴 +1.72 kB 🔴 +1.51 kB
assets/settings-B_sqawkt.js 27.3 kB 27.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BhbWhsRg.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BlDXT7wp.js 21.7 kB 21.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-Bz8HAvJu.js 21.1 kB 21.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C2vW8UNv.js 24.2 kB 24.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-C9vsDM17.js 25.1 kB 25.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DWD49kQp.js 33.3 kB 33.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DZE27_Iz.js 25.9 kB 25.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-OXaZPcZF.js 26.6 kB 26.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-RbkKsnDG.js 25.2 kB 25.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 6 added / 6 removed

UI Components — 184 kB (baseline 184 kB) • 🔴 +98 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-BacQJP5R.js (new) — 53.7 kB 🔴 +53.7 kB 🔴 +8.49 kB 🔴 +7.29 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-CXWBIw7M.js (removed) 53.7 kB — 🟢 -53.7 kB 🟢 -8.49 kB 🟢 -7.29 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DxabNJN1.js (new) — 48.1 kB 🔴 +48.1 kB 🔴 +10.4 kB 🔴 +8.99 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-B3cUrDh7.js (removed) 48 kB — 🟢 -48 kB 🟢 -10.4 kB 🟢 -8.99 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-BjwcuGtg.js (new) — 48 kB 🔴 +48 kB 🔴 +10.6 kB 🔴 +9.32 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-rZAitgl8.js (removed) 48 kB — 🟢 -48 kB 🟢 -10.6 kB 🟢 -9.32 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DaLX0VfE.js (new) — 19.5 kB 🔴 +19.5 kB 🔴 +5.04 kB 🔴 +4.48 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DNQO38pg.js (removed) 19.5 kB — 🟢 -19.5 kB 🟢 -5.04 kB 🟢 -4.48 kB
assets/ComfyQueueButton-CEYssptl.js (new) — 8.44 kB 🔴 +8.44 kB 🔴 +2.48 kB 🔴 +2.21 kB
assets/ComfyQueueButton-Dx-JiQJL.js (removed) 8.44 kB — 🟢 -8.44 kB 🟢 -2.48 kB 🟢 -2.21 kB
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-DJoFluEF.js (new) — 2.14 kB 🔴 +2.14 kB 🔴 +888 B 🔴 +766 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-DMrWDFGS.js (removed) 2.14 kB — 🟢 -2.14 kB 🟢 -891 B 🟢 -766 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-BLqKEJkr.js (new) — 897 B 🔴 +897 B 🔴 +501 B 🔴 +436 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-BRU0yzKt.js (removed) 897 B — 🟢 -897 B 🟢 -502 B 🟢 -447 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-CiSnQExp.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-CUWIT83D.js 2.04 kB 2.04 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 7 added / 7 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-BbW5R-Bc.js (removed) 7.51 kB — 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/keybindingService-Bh1B7nsU.js (new) — 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.58 kB
assets/audioService-CeFVX8mi.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -961 B 🟢 -823 B
assets/audioService-CmhDQ40g.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +960 B 🔴 +823 B
assets/serverConfigStore-Bwn3ENCR.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-BMsuc4jA.js (removed) 1.41 kB — 🟢 -1.41 kB 🟢 -652 B 🟢 -550 B
assets/audioUtils-DS_oA-s8.js (new) — 1.41 kB 🔴 +1.41 kB 🔴 +649 B 🔴 +547 B
assets/mathUtil-CD4DsosH.js 1.32 kB 1.32 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js 460 B 460 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-Cqf0KagN.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-S7nymsLT.js 3.98 MB 3.98 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-BzWEaXhK.js 1.96 MB 1.96 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-aR6ntw5X.js 1.37 MB 1.37 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-BIIubbA1.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-BPEtaHlw.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BZLod3g9.js 407 kB 407 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.75 MB (baseline 3.75 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/WidgetRecordAudio-Bal3dIBu.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.24 kB 🟢 -4.63 kB
assets/WidgetRecordAudio-BtUj24--.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.23 kB 🔴 +4.63 kB
assets/AudioPreviewPlayer-0nWRKdJ3.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.37 kB 🔴 +3.01 kB
assets/AudioPreviewPlayer-CWT5l1UA.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.37 kB 🟢 -3.01 kB
assets/NumberControlPopover-B8dyKWtV.js (new) — 6.31 kB 🔴 +6.31 kB 🔴 +1.93 kB 🔴 +1.7 kB
assets/NumberControlPopover-CUcES56V.js (removed) 6.31 kB — 🟢 -6.31 kB 🟢 -1.93 kB 🟢 -1.71 kB
assets/WidgetGalleria-CmPUw-CC.js (new) — 4.1 kB 🔴 +4.1 kB 🔴 +1.44 kB 🔴 +1.31 kB
assets/WidgetGalleria-DCl3iXWP.js (removed) 4.1 kB — 🟢 -4.1 kB 🟢 -1.45 kB 🟢 -1.31 kB
assets/WidgetColorPicker-DCP-1M1N.js (new) — 3.41 kB 🔴 +3.41 kB 🔴 +1.38 kB 🔴 +1.23 kB
assets/WidgetColorPicker-M7VtXvEV.js (removed) 3.41 kB — 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.23 kB
assets/WidgetTextarea-_pDZDt0u.js (new) — 3.08 kB 🔴 +3.08 kB 🔴 +1.21 kB 🔴 +1.07 kB
assets/WidgetTextarea-BPVSOQwy.js (removed) 3.08 kB — 🟢 -3.08 kB 🟢 -1.21 kB 🟢 -1.07 kB
assets/WidgetMarkdown-aOArw3pw.js (removed) 3.08 kB — 🟢 -3.08 kB 🟢 -1.28 kB 🟢 -1.12 kB
assets/WidgetMarkdown-CFRz6Sn1.js (new) — 3.08 kB 🔴 +3.08 kB 🔴 +1.28 kB 🔴 +1.12 kB
assets/WidgetAudioUI-D_a9f8Yq.js (removed) 2.86 kB — 🟢 -2.86 kB 🟢 -1.17 kB 🟢 -1.05 kB
assets/WidgetAudioUI-O1a6ZmdR.js (new) — 2.86 kB 🔴 +2.86 kB 🔴 +1.16 kB 🔴 +1.05 kB
assets/WidgetInputText-d7-aE6PW.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +917 B 🔴 +842 B
assets/WidgetInputText-DfIe2jwT.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -917 B 🟢 -828 B
assets/WidgetToggleSwitch-C70Kt7n8.js (new) — 1.76 kB 🔴 +1.76 kB 🔴 +833 B 🔴 +732 B
assets/WidgetToggleSwitch-k83GxhDb.js (removed) 1.76 kB — 🟢 -1.76 kB 🟢 -834 B 🟢 -731 B
assets/MediaImageBottom-BVx_3VA-.js (removed) 1.55 kB — 🟢 -1.55 kB 🟢 -735 B 🟢 -640 B
assets/MediaImageBottom-yNIoWf2k.js (new) — 1.55 kB 🔴 +1.55 kB 🔴 +735 B 🔴 +640 B
assets/MediaAudioBottom-B7_A0p09.js (removed) 1.51 kB — 🟢 -1.51 kB 🟢 -731 B 🟢 -650 B
assets/MediaAudioBottom-CGBu7JZA.js (new) — 1.51 kB 🔴 +1.51 kB 🔴 +733 B 🔴 +650 B
assets/Media3DBottom-CbccVHnG.js (new) — 1.5 kB 🔴 +1.5 kB 🔴 +730 B 🔴 +650 B
assets/Media3DBottom-CqAHix31.js (removed) 1.5 kB — 🟢 -1.5 kB 🟢 -731 B 🟢 -650 B
assets/MediaVideoBottom-Bj92RolH.js (new) — 1.5 kB 🔴 +1.5 kB 🔴 +731 B 🔴 +649 B
assets/MediaVideoBottom-BqRfINOU.js (removed) 1.5 kB — 🟢 -1.5 kB 🟢 -735 B 🟢 -654 B
assets/Media3DTop-CJThM2pe.js (removed) 1.49 kB — 🟢 -1.49 kB 🟢 -766 B 🟢 -652 B
assets/Media3DTop-DuNrkYxr.js (new) — 1.49 kB 🔴 +1.49 kB 🔴 +763 B 🔴 +653 B
assets/WidgetSelect-B8gur_Qb.js (removed) 655 B — 🟢 -655 B 🟢 -341 B 🟢 -287 B
assets/WidgetSelect-C-niCAU0.js (new) — 655 B 🔴 +655 B 🔴 +340 B 🔴 +289 B
assets/WidgetInputNumber-DpXUPEhE.js (removed) 595 B — 🟢 -595 B 🟢 -330 B 🟢 -275 B
assets/WidgetInputNumber-zOO_TZRM.js (new) — 595 B 🔴 +595 B 🔴 +329 B 🔴 +275 B
assets/Load3D-BRgPMAHS.js (new) — 424 B 🔴 +424 B 🔴 +268 B 🔴 +225 B
assets/Load3D-DItiRGhk.js (removed) 424 B — 🟢 -424 B 🟢 -269 B 🟢 -225 B
assets/WidgetLegacy-C3eZCYEp.js (new) — 364 B 🔴 +364 B 🔴 +237 B 🔴 +196 B
assets/WidgetLegacy-wU1fVEIK.js (removed) 364 B — 🟢 -364 B 🟢 -236 B 🟢 -195 B
assets/commands-_s-RvhJR.js 13.6 kB 13.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BuUILW6P.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BV4R6fLx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BWp4HdfU.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CLwPdnT6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CWMchBmd.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DazTQhtc.js 12.9 kB 12.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DmWrOe93.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwiH7Kr6.js 13.8 kB 13.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-mS3LCNPn.js 14.5 kB 14.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-6nlVHpc-.js 73.1 kB 73.1 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-B_3IONzJ.js 113 kB 113 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BqRsXvrH.js 72.2 kB 72.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BZ-vlW9L.js 94 kB 94 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C3etCTkn.js 83.4 kB 83.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CG-hMOv1.js 84.2 kB 84.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-ChsXwF7G.js 86.5 kB 86.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cw9RZWRY.js 89 B 89 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-DjVXiGQX.js 99 kB 99 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Xp7hXzT2.js 81.7 kB 81.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-FQz4Thvl.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-B3anU6gM.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-DhI-keBK.js 2.65 kB 2.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-B1kKcnvT.js 303 kB 303 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BoX8ObAh.js 300 kB 300 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BZQ0wolS.js 360 kB 360 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CHUJIOIF.js 310 kB 310 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DAU0PVOW.js 297 kB 297 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Db5kOxDZ.js 299 kB 299 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DgiIrZvP.js 276 kB 276 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-DU4sfqO1.js 334 kB 334 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Dw-Pdf3f.js 279 kB 279 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-CtDKuluF.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-DDdUO9Q8.js 2.21 kB 2.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 19 added / 19 removed

@DrJKL DrJKL merged commit d448421 into main Dec 16, 2025
31 checks passed
@DrJKL DrJKL deleted the drjkl/fix/assets-dropdown branch December 16, 2025 19:34
@luke-mino-altherr luke-mino-altherr added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.35 Backport PRs for cloud 1.35 labels Dec 16, 2025
github-actions bot pushed a commit that referenced this pull request Dec 16, 2025
@DrJKL @github-actions
Fix: Restore assets API short-circuit in WidgetSelectDropdown (#7563)
f69277a 
## Summary

Removed in #6985, but breaks the dropdown loading on Cloud.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7563-Fix-Restore-assets-API-short-circuit-in-WidgetSelectDropdown-2cb6d73d365081778a8dc65418d9f6be)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot mentioned this pull request Dec 16, 2025
Merged
@comfy-pr-bot
Copy link
Member

comfy-pr-bot commented Dec 16, 2025

@DrJKL Successfully backported to #7568

@github-actions github-actions bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Dec 16, 2025
luke-mino-altherr pushed a commit that referenced this pull request Dec 16, 2025
@comfy-pr-bot @DrJKL
[backport cloud/1.35] Fix: Restore assets API short-circuit in Widget…
a5d7a96 
…SelectDropdown (#7568)

Backport of #7563 to `cloud/1.35`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7568-backport-cloud-1-35-Fix-Restore-assets-API-short-circuit-in-WidgetSelectDropdown-2cb6d73d3650811bb2e7dc9c3f914600)
by [Unito](https://www.unito.io)

Co-authored-by: Alexander Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AustinMroz AustinMroz AustinMroz approved these changes

Assignees

@AustinMroz AustinMroz

@christian-byrne christian-byrne

Labels

cloud/1.35 Backport PRs for cloud 1.35 size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DrJKL @comfy-pr-bot @AustinMroz @luke-mino-altherr @christian-byrne