docs: update docs and workflows for change to 2-week release cycle (from 1-week) #7564
+46
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
added
the
documentation
dosubot
bot
added
the
size:M
Contributor
📝 WalkthroughWalkthroughThe pull request converts the ComfyUI release workflow from a weekly to a bi-weekly schedule. Changes include adding a check-release-week job to determine release-eligible weeks, updating job dependencies and conditions to run conditionally, and documenting the extended development and feature-freeze phases in the README. Changes
Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results⏰ Completed at: 12/16/2025, 07:34:05 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/16/2025, 07:25:14 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.25 MB (baseline 3.25 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 992 kB (baseline 992 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 299 kB (baseline 299 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.75 MB (baseline 3.75 MB) • ⚪ 0 BBundles that do not match a named category
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/release-biweekly-comfyui.yaml(5 hunks)README.md(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.455Z
Learning: Consider updates to docs.comfy.org during development workflow
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:24.164Z
Learning: The project has CI automation that handles code formatting (pnpm format) automatically, so manual formatting suggestions should not be provided in code reviews for the Comfy-Org/ComfyUI_frontend repository.
Learnt from: Myestery
Repo: Comfy-Org/ComfyUI_frontend PR: 7422
File: .github/workflows/pr-update-playwright-expectations.yaml:131-135
Timestamp: 2025-12-12T23:02:37.473Z
Learning: In the `.github/workflows/pr-update-playwright-expectations.yaml` workflow in the Comfy-Org/ComfyUI_frontend repository, the snapshot update process is intentionally scoped to only add and update snapshot images. Deletions of snapshot files are handled explicitly outside this workflow and should not be suggested as part of this automation.
📚 Learning: 2025-12-16T17:41:58.455Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.455Z
Learning: Consider updates to docs.comfy.org during development workflow
Applied to files:
README.md
📚 Learning: 2025-12-12T23:02:37.473Z
Learnt from: Myestery
Repo: Comfy-Org/ComfyUI_frontend PR: 7422
File: .github/workflows/pr-update-playwright-expectations.yaml:131-135
Timestamp: 2025-12-12T23:02:37.473Z
Learning: In the `.github/workflows/pr-update-playwright-expectations.yaml` workflow in the Comfy-Org/ComfyUI_frontend repository, the snapshot update process is intentionally scoped to only add and update snapshot images. Deletions of snapshot files are handled explicitly outside this workflow and should not be suggested as part of this automation.
Applied to files:
.github/workflows/release-biweekly-comfyui.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: collect
- GitHub Check: test
🔇 Additional comments (5)
README.md (2)
36-47: Documentation correctly reflects the 2-week release cycle.The updated development phase (2 weeks) and feature freeze (2 weeks) durations are consistent and clearly documented.
59-68: Example release cycle table accurately demonstrates the bi-weekly cadence.The table correctly shows:
- 2-week groupings (1-2, 3-4, etc.)
- Overlapping version development/freeze cycles
- ~4 weeks total from merge to stable release per the description
Based on learnings, consider whether docs.comfy.org should also be updated to reflect this release cycle change for consistency across documentation sources.
.github/workflows/release-biweekly-comfyui.yaml (3)
49-51: Correct conditional logic for release-week gating.The job correctly runs only during release weeks or when manually triggered, consistent with the comment on line 9.
165-167: Proper use ofalways()with success check.The condition correctly uses
always()combined with an explicit success check onresolve-versionto handle cases wheretrigger-release-if-neededis skipped (when no release is needed). The redundant release-week check adds defensive consistency.
266-284: Clear documentation of intentional force-push behavior.The comments on lines 278-280 appropriately warn that force-pushing overwrites previous branch history, requiring re-application of any review comments or manual commits.
Comment on lines
+27
to
+40
| # Anchor date: first bi-weekly release Monday | ||
| ANCHOR="2025-12-22" | ||
| ANCHOR_EPOCH=$(date -d "$ANCHOR" +%s) | ||
| NOW_EPOCH=$(date +%s) | ||
| WEEKS_SINCE=$(( (NOW_EPOCH - ANCHOR_EPOCH) / 604800 )) | ||
| if [ $((WEEKS_SINCE % 2)) -eq 0 ]; then | ||
| echo "Release week (week $WEEKS_SINCE since anchor $ANCHOR)" | ||
| echo "is_release_week=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "Not a release week (week $WEEKS_SINCE since anchor $ANCHOR)" | ||
| echo "is_release_week=false" >> $GITHUB_OUTPUT | ||
| fi |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider explicitly handling dates before the anchor.
When the workflow runs before the anchor date (2025-12-22), WEEKS_SINCE will be negative. While bash's modulo with negative numbers will result in -1 % 2 = -1 (not 0), effectively skipping releases, this implicit behavior could be confusing for future maintainers.
Consider making this explicit:
if [ $((WEEKS_SINCE % 2)) -eq 0 ]; then
+ if [ $WEEKS_SINCE -lt 0 ]; then
+ echo "Before anchor date, skipping release"
+ echo "is_release_week=false" >> $GITHUB_OUTPUT
+ elif [ $((WEEKS_SINCE % 2)) -eq 0 ]; then
echo "Release week (week $WEEKS_SINCE since anchor $ANCHOR)"
echo "is_release_week=true" >> $GITHUB_OUTPUT
elseCommittable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In .github/workflows/release-biweekly-comfyui.yaml around lines 27 to 40, the
script currently computes WEEKS_SINCE which can be negative for runs before the
anchor date; explicitly detect when NOW_EPOCH < ANCHOR_EPOCH and immediately
emit a clear message and set is_release_week=false (and write to
$GITHUB_OUTPUT), otherwise proceed with the existing weeks calculation and
modulo logic; this makes pre-anchor behavior explicit and easier to maintain.
DrJKL
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates all documentation regarding the release cycle to reflect new 2-week cycles.
┆Issue is synchronized with this Notion page by Unito