Update viewjobhistorycommand #7911

kaili-yang · 2026-01-08T22:36:34Z

Summary

Add the key binding to the schema and mark the setting as hidden.
#7805 (review)

Changes

What:

Added a new shortcuts field to the user settings database model.
Marked the shortcuts field as hidden in the API/Schema to ensure it remains internal for now, as suggested by the reviewer @benceruleanlu .
Migrated shortcut storage logic from frontend-only (store) to persistent backend storage.
Breaking: None
Dependencies: None

┆Issue is synchronized with this Notion page by Unito

coderabbitai · 2026-01-08T22:36:49Z

📝 Walkthrough

Walkthrough

Added a hidden boolean setting Comfy.Queue.History.Expanded (default false, versionAdded 1.37.0) and updated useQueueUIStore to proxy isOverlayExpanded to the persistent settings store instead of a local ref.

Changes

Cohort / File(s)	Summary
Setting Definition `src/platform/settings/constants/coreSettings.ts`, `src/schemas/apiSchema.ts`	Added `Comfy.Queue.History.Expanded` to `CORE_SETTINGS` (`type: 'hidden'`, `defaultValue: false`, `versionAdded: '1.37.0'`) and to `zSettings` as `z.boolean()`.
Queue Store Integration `src/stores/queueStore.ts`	Replaced local `isOverlayExpanded` `ref` with a `ComputedRef` that reads/writes `Comfy.Queue.History.Expanded` via `useSettingStore`; added import of `useSettingStore`; `toggleOverlay` now updates the setting-backed computed value.

Sequence Diagram(s)

sequenceDiagram
    participant UI as Queue UI
    participant Store as useQueueUIStore
    participant Settings as SettingStore
    UI->>Store: read isOverlayExpanded (computed)
    Store->>Settings: get('Comfy.Queue.History.Expanded')
    UI->>Store: toggleOverlay() / set expanded
    Store->>Settings: set('Comfy.Queue.History.Expanded', value)

Possibly related PRs

feat: add Comfy.Queue.ToggleOverlay command for job history panel #7805: Modified useQueueUIStore and isOverlayExpanded; related to persisting/centralizing the overlay state.

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9835b9b and cef0530.

📒 Files selected for processing (3)

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

🧰 Additional context used

📓 Path-based instructions (8)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

src/**/stores/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/stores/**/*.{ts,tsx}: Maintain clear public interfaces and restrict extension access in stores
Use TypeScript for type safety in state management stores

Files:

src/stores/queueStore.ts

src/stores/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Name Pinia stores as *Store.ts (e.g., nodeStore.ts)

Files:

src/stores/queueStore.ts

🧠 Learnings (8)

📓 Common learnings

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:38.162Z
Learning: In Pinia setup stores, when accessing reactive properties directly via `useStore().property` pattern (e.g., `useQueueUIStore().isOverlayExpanded`), Pinia automatically unwraps refs and returns the primitive value. The `.value` accessor is only needed when destructuring store properties or using `storeToRefs()`.

📚 Learning: 2025-12-05T06:11:09.383Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.

Applied to files:

src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/stores/queueStore.ts
src/schemas/apiSchema.ts

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/stores/**/*.{ts,tsx} : Maintain clear public interfaces and restrict extension access in stores

Applied to files:

src/stores/queueStore.ts

🧬 Code graph analysis (1)

src/stores/queueStore.ts (1)

src/platform/settings/settingStore.ts (1)

useSettingStore (46-252)

🔇 Additional comments (4)

src/platform/settings/constants/coreSettings.ts (1)

820-826: LGTM! Clean setting definition.

The new hidden setting for queue history expansion state is correctly structured and appropriately placed with other queue-related settings. The default value of false (collapsed) is sensible, and version tracking is properly maintained.

src/schemas/apiSchema.ts (1)

470-470: LGTM! Schema correctly reflects the new setting.

The Zod schema entry properly validates the new boolean setting and maintains logical grouping with other queue-related settings.

src/stores/queueStore.ts (2)

7-7: LGTM! Correct import addition.

The import of useSettingStore is appropriately added to support the persistent settings integration.

624-629: Excellent migration to persistent settings!

The migration from local ephemeral state to settings-backed persistent storage is cleanly implemented. The computed property with getter/setter correctly proxies to the settings store, and the public API change from Ref<boolean> to ComputedRef<boolean> is transparent to consumers thanks to Pinia's auto-unwrapping.

The pattern ensures that overlay expansion state now persists across sessions, which improves UX.

Based on learnings: Pinia auto-unwraps refs when accessed directly, so useQueueUIStore().isOverlayExpanded returns the primitive boolean value without needing .value.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-08T22:36:59Z

🎭 Playwright Test Results

Tests are starting...

⏰ Started at: 01/10/2026, 07:52:52 AM UTC

🚀 Running Tests

🧪 chromium: Running tests...
🧪 chromium-0.5x: Running tests...
🧪 chromium-2x: Running tests...
🧪 mobile-chrome: Running tests...

⏱️ Please wait while tests are running...

github-actions · 2026-01-08T22:37:03Z

🎨 Storybook Build Status

Build is starting...

⏰ Started at: 01/10/2026, 07:52:53 AM UTC

🚀 Building Storybook

📦 Installing dependencies...
🔧 Building Storybook components...
🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @src/platform/settings/constants/coreSettings.ts:
- Around line 820-825: Add a versionAdded field to the setting object with id
'Comfy.Queue.History.Expanded' to match the other settings' structure; update
the object to include versionAdded: '<current-release-version>' (replace with
the actual current release version string) so the entry reads: { id:
'Comfy.Queue.History.Expanded', name: 'Queue history expanded', type: 'hidden',
defaultValue: false, versionAdded: '<current-release-version>' }.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 405e756 and 4addf37.

📒 Files selected for processing (3)

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

🧰 Additional context used

📓 Path-based instructions (10)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: TypeScript files must use exclusive TypeScript; no new JavaScript files
Use VueUse functions for performance-enhancing styles
Use es-toolkit for utility functions
Implement proper error handling in Vue components and async code

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,vue}: Use separate import type statements; avoid inline type imports mixed with value imports
ESLint rules must enforce Vue + TypeScript rules, no floating promises, no unused imports, and i18n raw text restrictions in templates
Never use any type or as any type assertions; use proper TypeScript types
Keep functions short and functional; minimize nesting with early returns and reduce arrow anti-patterns
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions over function expressions; use function declarations when possible
Write expressive, self-documenting code; minimize unnecessary comments and avoid redundant comments
Ask 'is there a simpler way?' when writing code; use refactoring to make complex code simpler
Watch out for Code Smells and refactor to avoid them

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

**/*.{ts,tsx,vue,js,jsx,json,css,md}

📄 CodeRabbit inference engine (AGENTS.md)

Format code with Prettier using 2-space indent, single quotes, no trailing semicolons, 80-character width

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

{src/**/*.{ts,tsx,vue},**/*.test.ts}

📄 CodeRabbit inference engine (AGENTS.md)

Use vue-i18n in Composition API for string literals; place translation entries in src/locales/en/main.json and use i18n plurals system

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Minimize surface area (exported values) of each module and composable

Files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

src/**/stores/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/stores/**/*.{ts,tsx}: Maintain clear public interfaces and restrict extension access in stores
Use TypeScript for type safety in state management stores

Files:

src/stores/queueStore.ts

src/stores/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Pinia store files must be named *Store.ts

Files:

src/stores/queueStore.ts

🧠 Learnings (6)

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/schemas/apiSchema.ts
src/stores/queueStore.ts
src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/stores/**/*.{ts,tsx} : Maintain clear public interfaces and restrict extension access in stores

Applied to files:

src/stores/queueStore.ts

🧬 Code graph analysis (1)

src/stores/queueStore.ts (1)

src/platform/settings/settingStore.ts (1)

useSettingStore (46-252)

🔇 Additional comments (2)

src/stores/queueStore.ts (1)

624-629: LGTM! Clean migration to persistent settings.

The refactor from local reactive state to a computed property backed by the settings store is well-implemented. The get/set pattern correctly delegates to settingStore.get() and settingStore.set(), and the public API remains unchanged.

src/schemas/apiSchema.ts (1)

470-470: LGTM! Schema addition is correct.

The boolean schema for the new setting key is properly defined and logically positioned alongside other queue-related settings.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @src/platform/settings/constants/coreSettings.ts:
- Around line 820-826: The 'Comfy.Queue.History.Expanded' setting object
includes an ambiguous inline comment "// or current version"; remove that
comment and ensure the single authoritative version is set in the versionAdded
field (e.g., '1.36.0' or the actual release that introduced it) so migrations
and feature-gates read a single unambiguous value; update the object literal for
id 'Comfy.Queue.History.Expanded' to contain only the versionAdded string
without any trailing comment.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4addf37 and f840d97.

📒 Files selected for processing (1)

src/platform/settings/constants/coreSettings.ts

🧰 Additional context used

📓 Path-based instructions (5)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Leverage VueUse functions for performance-enhancing utilities

Files:

src/platform/settings/constants/coreSettings.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Minimize the surface area (exported values) of each module and composable
Use es-toolkit for utility functions

Files:

src/platform/settings/constants/coreSettings.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements; do not mix inline type imports in the same statement
Sort and group imports by plugin; run pnpm format before committing
Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Code should be well-designed with clear names for everything; write code that is expressive and self-documenting
Avoid redundant comments and clean up code as you go; comments should explain why, not what
Ask if there is a simpler way to implement functionality; refactor complex code to simplify it
Minimize nesting depth (e.g., if () { ... } or for () { ... }); watch for arrow anti-pattern
Watch out for code smells and refactor to avoid them
Never use any type; use proper TypeScript types
Never use as any type assertions; fix the underlying type issue instead
Indent with 2 spaces; use single quotes; no trailing semicolons; max line width 80 (per .prettierrc)
Complex type definitions used in multiple related places should be extracted and named for reuse
Implement proper error handling

Files:

src/platform/settings/constants/coreSettings.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/platform/settings/constants/coreSettings.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional; use function declarations instead of function expressions when possible
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones

Files:

src/platform/settings/constants/coreSettings.ts

🧠 Learnings (5)

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/platform/settings/constants/coreSettings.ts

src/platform/settings/constants/coreSettings.ts

DrJKL · 2026-01-10T03:49:18Z

That's so many merges... 👀

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

src/schemas/apiSchema.ts (1)
138-148: Critical: Duplicate asset_id property in Zod schema.

The asset_id property is defined twice:

Line 140: asset_id: z.string() (required)

Line 146: asset_id: z.string().optional() (optional)

In JavaScript objects, the later definition overwrites the earlier one, so only the optional version at line 146 takes effect. This appears unintentional based on the static analysis hint.
🐛 Proposed fix: Remove duplicate property

If asset_id should be required:
 const zAssetDownloadWsMessage = z.object({
   task_id: z.string(),
   asset_id: z.string(),
   asset_name: z.string(),
   bytes_total: z.number(),
   bytes_downloaded: z.number(),
   progress: z.number(),
   status: z.enum(['created', 'running', 'completed', 'failed']),
-  asset_id: z.string().optional(),
   error: z.string().optional()
 })
If asset_id should be optional:
 const zAssetDownloadWsMessage = z.object({
   task_id: z.string(),
-  asset_id: z.string(),
   asset_name: z.string(),
   bytes_total: z.number(),
   bytes_downloaded: z.number(),
   progress: z.number(),
   status: z.enum(['created', 'running', 'completed', 'failed']),
   asset_id: z.string().optional(),
   error: z.string().optional()
 })
src/stores/queueStore.ts (1)
623-635: Add void to silence the unawaited async call in the computed setter.

The computed setter calls settingStore.set(), which is async, but doesn't await or explicitly mark it as a fire-and-forget operation with void. Throughout the codebase, settingStore.set() calls are consistently either awaited (in composables) or explicitly marked with void (in watch callbacks with debounce). Mark this as void settingStore.set(...) to be consistent with the established pattern.
Current code:
const isOverlayExpanded = computed({
  get: () => settingStore.get('Comfy.Queue.History.Expanded'),
  set: (value) => settingStore.set('Comfy.Queue.History.Expanded', value)
})

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a828084 and 4280eff.

📒 Files selected for processing (3)

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

🧰 Additional context used

📓 Path-based instructions (8)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

src/**/stores/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/stores/**/*.{ts,tsx}: Maintain clear public interfaces and restrict extension access in stores
Use TypeScript for type safety in state management stores

Files:

src/stores/queueStore.ts

src/stores/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Name Pinia stores as *Store.ts (e.g., nodeStore.ts)

Files:

src/stores/queueStore.ts

🧠 Learnings (8)

📚 Learning: 2025-12-05T06:11:09.383Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.

Applied to files:

src/platform/settings/constants/coreSettings.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/platform/settings/constants/coreSettings.ts
src/schemas/apiSchema.ts
src/stores/queueStore.ts

📚 Learning: 2026-01-06T19:20:56.167Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7746
File: src/platform/assets/services/assetService.ts:484-491
Timestamp: 2026-01-06T19:20:56.167Z
Learning: In `src/platform/assets/services/assetService.ts`, prefer using `schema.safeParse()` over `schema.parse()` for validating API responses to avoid throwing ZodError with internal schema details; follow the existing pattern: call `safeParse()`, check `result.success`, and use `fromZodError(result.error)` to format error messages for logging while throwing user-friendly errors.

Applied to files:

src/schemas/apiSchema.ts

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/stores/**/*.{ts,tsx} : Maintain clear public interfaces and restrict extension access in stores

Applied to files:

src/stores/queueStore.ts

🧬 Code graph analysis (1)

src/stores/queueStore.ts (1)

src/platform/settings/settingStore.ts (1)

useSettingStore (46-252)

🪛 Biome (2.1.2)

src/schemas/apiSchema.ts

[error] 140-140: This property is later overwritten by an object member with the same name.

Overwritten with this property.

If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property.

(lint/suspicious/noDuplicateObjectKeys)

🔇 Additional comments (3)

src/schemas/apiSchema.ts (1)

471-471: LGTM!

The new setting key 'Comfy.Queue.History.Expanded': z.boolean() correctly reflects the hidden boolean setting added in coreSettings.ts.

src/platform/settings/constants/coreSettings.ts (1)

820-826: LGTM!

The new hidden setting for persisting queue history expansion state is well-defined:

type: 'hidden' keeps it internal as intended

defaultValue: false (collapsed) is a sensible default

versionAdded: '1.36.0' properly tracks the introduction

src/stores/queueStore.ts (1)

7-7: LGTM!

Import follows repository conventions with type imports on separate lines.

kaili-yang requested a review from a team as a code owner January 8, 2026 22:36

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2026

coderabbitai bot reviewed Jan 8, 2026

View reviewed changes

jtydhr88 requested a review from benceruleanlu January 9, 2026 01:39

coderabbitai bot reviewed Jan 9, 2026

View reviewed changes

src/platform/settings/constants/coreSettings.ts Show resolved Hide resolved

DrJKL assigned benceruleanlu Jan 10, 2026

kaili-yang force-pushed the update-viewjobhistorycommand branch 2 times, most recently from 4280eff to 9835b9b Compare January 10, 2026 07:43

coderabbitai bot reviewed Jan 10, 2026

View reviewed changes

update user settings

cef0530

kaili-yang force-pushed the update-viewjobhistorycommand branch from 9835b9b to cef0530 Compare January 10, 2026 07:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update viewjobhistorycommand #7911

Update viewjobhistorycommand #7911

kaili-yang commented Jan 8, 2026 •

edited by sync-by-unito bot

Loading

Uh oh!

coderabbitai bot commented Jan 8, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Uh oh!

github-actions bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

DrJKL commented Jan 10, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update viewjobhistorycommand #7911

Are you sure you want to change the base?

Update viewjobhistorycommand #7911

Conversation

kaili-yang commented Jan 8, 2026 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

coderabbitai bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Uh oh!

github-actions bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

🚀 Running Tests

Uh oh!

github-actions bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🚀 Building Storybook

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DrJKL commented Jan 10, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kaili-yang commented Jan 8, 2026 •

edited by sync-by-unito bot

Loading

coderabbitai bot commented Jan 8, 2026 •

edited

Loading

github-actions bot commented Jan 8, 2026 •

edited

Loading

github-actions bot commented Jan 8, 2026 •

edited

Loading