fix: restore strictExecutionOrder for Storybook Chromatic builds#9038
Merged
fix: restore strictExecutionOrder for Storybook Chromatic builds#9038
Conversation
Rolldown requires strictExecutionOrder to guarantee Storybook's internal module globals (__STORYBOOK_MODULE_*) are defined before they are referenced. Without it, Chromatic fails with: Error: __STORYBOOK_MODULE_CORE_EVENTS_PREVIEW_ERRORS__ is not defined Accidentally removed in #8834 as a merge artifact. Amp-Thread-ID: https://ampcode.com/threads/T-019c7dd0-e214-731a-b7de-ec7b524eb7fc
dosubot
bot
added
the
size:XS
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/21/2026, 02:49:11 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Playwright: ✅ 528 passed, 0 failed · 3 flaky 📊 Browser Reports
|
Contributor
📝 WalkthroughWalkthroughA Rollup bundling option ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 4.32 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 21.5 kB (baseline 21.5 kB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 926 kB (baseline 926 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 68.8 kB (baseline 68.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 430 kB (baseline 430 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Editors & Dialogs — 738 B (baseline 738 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
UI Components — 43.2 kB (baseline 43.2 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 2.5 MB (baseline 2.5 MB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 57.6 kB (baseline 57.6 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 8.86 MB (baseline 8.86 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.39 MB (baseline 7.39 MB) • ⚪ 0 BBundles that do not match a named category
|
DrJKL
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
strictExecutionOrder: truein.storybook/main.tsrolldownOptions, accidentally removed in #8834 as a merge artifact.Problem
Chromatic visual regression tests fail on
version-bump-*release branches with:Rolldown without
strictExecutionOrderdoesn't guarantee module execution order. Storybook's internal module system defines__STORYBOOK_MODULE_*globals during initialization — without strict ordering, downstream code references them before they're defined.Only
version-bump-*branches are affected because thechromatic-deploymentCI job (which actually loads and extracts stories at runtime) is gated to those branches.Changes
strictExecutionOrder: truein.storybook/main.tsrolldownOptions output config┆Issue is synchronized with this Notion page by Unito