Skip to content

fix 'unsaved' value when closing workflows #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcmonkey4eva wants to merge 6 commits into from
Closed

fix 'unsaved' value when closing workflows #999

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59c3a80
fix 'unsaved' value when closing workflows
mcmonkey4eva Sep 26, 2024
6559621
experimental playwright test
mcmonkey4eva Oct 2, 2024
3aaf5c1
mark the new test as skipped
mcmonkey4eva Oct 2, 2024
93bc724
Merge branch 'main' into fix-unsaved-value
mcmonkey4eva Oct 3, 2024
d638083
remove untested test
mcmonkey4eva Oct 7, 2024
5838f2f
Merge branch 'main' into fix-unsaved-value
mcmonkey4eva Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
experimental playwright test
  • Loading branch information
@mcmonkey4eva
mcmonkey4eva committed Oct 2, 2024
commit 65596216aaf7da1262abffc462b4bd77cfa4860e
37 changes: 37 additions & 0 deletions browser_tests/menu.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,43 @@ test.describe('Menu', () => {
])
})

test('Can save, load, and delete workflows', async ({ comfyPage }) => {
const tab = comfyPage.menu.workflowsTab
expect(await tab.getOpenedWorkflowNames()).toEqual([
'*Unsaved Workflow.json'
])
await tab.newBlankWorkflowButton.click()
expect(await tab.getOpenedWorkflowNames()).toEqual([
'*Unsaved Workflow.json',
'*Unsaved Workflow (2).json'
])
await comfyPage.menu.saveWorkflow('test-save-workflow')
expect(await tab.getOpenedWorkflowNames()).toEqual([
'*Unsaved Workflow.json',
'test-save-workflow.json'
])
const labels = comfyPage.page.locator(
'.comfyui-workflows-open .node-label'
)
await labels.first().click()
await comfyPage.nextFrame()
await labels.last().click()
await comfyPage.nextFrame()
// Verify no '*' prefix on the saved one after reopening it
expect(await tab.getOpenedWorkflowNames()).toEqual([
'*Unsaved Workflow.json',
'test-save-workflow.json'
])
await labels.last().click({ button: 'right' })
await comfyPage.page
.locator('.p-contextmenu-item-label:has-text("Delete")')
.click()
await comfyPage.nextFrame()
expect(await tab.getOpenedWorkflowNames()).toEqual([
'*Unsaved Workflow.json'
])
})

test('Does not report warning when switching between opened workflows', async ({
comfyPage
}) => {
Expand Down