-
Notifications
You must be signed in to change notification settings - Fork 147
Updating to aspire 13 stable #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the project to Aspire 13 stable, which renamed the Node.js hosting package from Aspire.Hosting.NodeJS to Aspire.Hosting.JavaScript. The changes systematically refactor the codebase to align with this new package name while maintaining backward compatibility.
- Renamed all
NodeJSreferences toJavaScriptin namespaces, types, and file names - Updated package references from
Aspire.Hosting.NodeJStoAspire.Hosting.JavaScript - Removed workarounds for Aspire issue #7779 in SqlServer extensions
- Added a comprehensive Turborepo demo example application
Reviewed Changes
Copilot reviewed 26 out of 118 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.JavaScript.Extensions.Tests/*.cs | Updated namespace from NodeJS to JavaScript in test files |
| tests/CommunityToolkit.Aspire.Hosting.JavaScript.Extensions.Tests/*.csproj | New test project file referencing JavaScript examples |
| src/CommunityToolkit.Aspire.Hosting.SqlServer.Extensions/*.csproj | Removed workaround for Aspire issue #7779 |
| src/CommunityToolkit.Aspire.Hosting.JavaScript.Extensions/*.cs | Renamed resource classes and updated namespaces from NodeJS to JavaScript |
| src/CommunityToolkit.Aspire.Hosting.JavaScript.Extensions/*.csproj | Updated package reference to Aspire.Hosting.JavaScript |
| src/CommunityToolkit.Aspire.Hosting.McpInspector/*.cs | Updated using statement to JavaScript namespace |
| src/CommunityToolkit.Aspire.Hosting.McpInspector/*.csproj | Updated package reference to Aspire.Hosting.JavaScript |
| examples/javascript-ext/turborepo-demo/** | Added new comprehensive Turborepo demo example with Next.js apps |
| nuget.config | Removed pre-release Aspire package source |
| global.json | Added trailing newline |
Minimum allowed line rate is |
Had to move to
Aspire.Hosting.JavaScriptas that's the new package name, so refactored everything to align with that.