Fix MCP Inspector to support HTTPS endpoints #993
Merged
+85
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aaronpowell <[email protected]>
Copilot
AI
changed the title
[WIP] Fix MCP Inspector to support https endpoints
Fix MCP Inspector to support HTTPS endpoints
Nov 23, 2025
aaronpowell
approved these changes
Nov 23, 2025
Contributor
Minimum allowed line rate is |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the MCP Inspector integration fails when MCP servers expose only HTTPS endpoints. The fix enables HTTPS endpoint support while maintaining backward compatibility with HTTP-only servers.
- Updates endpoint resolution logic to prefer HTTPS over HTTP with a fallback chain
- Improves error messaging to reflect support for both HTTPS and HTTP endpoints
- Adds comprehensive test coverage for HTTPS-only, HTTP-only, and mixed endpoint scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResource.cs | Updated endpoint resolution to check for "https" first, then fall back to "http", following the pattern used in JavaScriptHostingExtensions.cs. Also updated error message to accurately reflect support for both endpoint types. |
| tests/CommunityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs | Added three new test methods to verify HTTPS endpoint support, HTTPS preference when both endpoints exist, and proper endpoint selection behavior across different configurations. |
| // Arrange | ||
| var appBuilder = DistributedApplication.CreateBuilder(); | ||
|
|
||
| // AddProject creates both http and https endpoints by default |
There was a problem hiding this comment.
The comment states "AddProject creates both http and https endpoints by default", but this is inconsistent with the comment in the test above (line 450) which states "AddProject creates 'http' by default". This creates confusion about the actual behavior. Please verify the behavior and update comments consistently. Based on the code context, AddProject typically creates an HTTP endpoint by default, and HTTPS needs to be added explicitly with WithHttpsEndpoint().
Suggested change
| // AddProject creates both http and https endpoints by default | |
| // AddProject creates "http" endpoint by default |
| .WithHttpsEndpoint(name: "https"); | ||
|
|
||
| // Act | ||
| var inspector = appBuilder.AddMcpInspector("inspector") |
There was a problem hiding this comment.
Call to obsolete method AddMcpInspector.
Suggested change
| var inspector = appBuilder.AddMcpInspector("inspector") | |
| var inspector = appBuilder.AddMcpInspectorResource("inspector") |
| .WithHttpsEndpoint(name: "https"); | ||
|
|
||
| // Act | ||
| var inspector = appBuilder.AddMcpInspector("inspector") |
There was a problem hiding this comment.
Call to obsolete method AddMcpInspector.
| var mockServer = appBuilder.AddProject<Projects.CommunityToolkit_Aspire_Hosting_McpInspector_McpServer>("mcpServer"); | ||
|
|
||
| // Act | ||
| var inspector = appBuilder.AddMcpInspector("inspector") |
There was a problem hiding this comment.
Call to obsolete method AddMcpInspector.
| .WithHttpsEndpoint(name: "https"); | ||
|
|
||
| // Act | ||
| var inspector = appBuilder.AddMcpInspector("inspector") |
| .WithHttpsEndpoint(name: "https"); | ||
|
|
||
| // Act | ||
| var inspector = appBuilder.AddMcpInspector("inspector") |
| var mockServer = appBuilder.AddProject<Projects.CommunityToolkit_Aspire_Hosting_McpInspector_McpServer>("mcpServer"); | ||
|
|
||
| // Act | ||
| var inspector = appBuilder.AddMcpInspector("inspector") |
davidfowl
reviewed
Nov 23, 2025
| McpServerMetadata item = new( | ||
| mcpServer.Name, | ||
| mcpServer.GetEndpoint("http") ?? throw new InvalidOperationException($"The MCP server {mcpServer.Name} must have a 'http' endpoint defined."), | ||
| mcpServer.GetEndpoint("https") ?? mcpServer.GetEndpoint("http") ?? throw new InvalidOperationException($"The MCP server {mcpServer.Name} must have an 'https' or 'http' endpoint defined."), |
Member
There was a problem hiding this comment.
What happens if there's no registered HTTPS endpoint though?
This was referenced Nov 26, 2025
Closed
This was referenced Dec 5, 2025
This was referenced Dec 8, 2025
This was referenced Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP Inspector integration fails when MCP servers only expose HTTPS endpoints, throwing
InvalidOperationExceptionbecause it only checks for HTTP.Changes
McpInspectorResource.cs: Prefer HTTPS over HTTP when resolving endpoints
Tests: Added coverage for HTTPS-only, HTTP-only, and both endpoints scenarios
Follows the existing pattern in
JavaScriptHostingExtensions.csfor endpoint resolution.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.