Skip to content

Conversation

@skendrot
Copy link
Contributor

Issue: #

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

instruction link is not correct in PR template

What is the new behavior?

link now works properly

@skendrot skendrot requested a review from nmetulev October 25, 2018 22:12
@Bmartin2013
Copy link

After looking into the .md file, I noticed that there's a typo on ln (6,6). It shoud say 'one or more...'. Could you fix it please?. Thanks

image

@michael-hawker
Copy link
Member

ping @skendrot

@windowstoolkitbot
Copy link

This PR seems inactive. @skendrot Do you need help to complete this issue?

2 similar comments
@windowstoolkitbot
Copy link

This PR seems inactive. @skendrot Do you need help to complete this issue?

@windowstoolkitbot
Copy link

This PR seems inactive. @skendrot Do you need help to complete this issue?

@michael-hawker
Copy link
Member

I've figured out the solution finally! I had no idea about testing this until now, didn't think about creating a new PR and copying changes in for links... :(

I've also noticed that we need absolute links for these as there are multiple paths to get to the PR template depending on how you create a PR, so relative links won't work.

First we should finish PR #3115 as that'll change the link to the info about SDKs I believe. Then we should have the stable links we need to grab?

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We merged #3115, made suggestions here for the correct absolute links. We'll clean-up some documentation guidance inconsistencies as part of other PRs. Thanks @skendrot, sorry for having this hang for so long!

Co-Authored-By: Michael Hawker MSFT (XAML Llama) <[email protected]>
@ghost ghost added the no-recent-activity 📉 Open Issues that require attention label Apr 2, 2020
@ghost
Copy link

ghost commented Apr 2, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment.

@ghost ghost closed this May 17, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants