-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix link for doc instructions #2607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link for doc instructions #2607
Conversation
|
ping @skendrot |
|
This PR seems inactive. @skendrot Do you need help to complete this issue? |
2 similar comments
|
This PR seems inactive. @skendrot Do you need help to complete this issue? |
|
This PR seems inactive. @skendrot Do you need help to complete this issue? |
Fix typoe
Co-Authored-By: skendrot <[email protected]>
|
I've figured out the solution finally! I had no idea about testing this until now, didn't think about creating a new PR and copying changes in for links... :( I've also noticed that we need absolute links for these as there are multiple paths to get to the PR template depending on how you create a PR, so relative links won't work. First we should finish PR #3115 as that'll change the link to the info about SDKs I believe. Then we should have the stable links we need to grab? |
michael-hawker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Michael Hawker MSFT (XAML Llama) <[email protected]>
Co-Authored-By: Michael Hawker MSFT (XAML Llama) <[email protected]>
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |

Issue: #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
instruction link is not correct in PR template
What is the new behavior?
link now works properly