Skip to content

RadialGauge UIA improvements #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
11 commits merged into from
Oct 29, 2020
Merged

RadialGauge UIA improvements #3544

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
052b3ee
Fix crash when using narrator and RadialGauge not working
marcelwgn Oct 22, 2020
59bda79
Update UIA value behavior and add test
marcelwgn Oct 23, 2020
361c553
Add license header
marcelwgn Oct 23, 2020
0cc9536
Update comment
marcelwgn Oct 23, 2020
eef44f7
Merge branch 'master' into dev/uia-improvements
Kyaa-dost Oct 26, 2020
b73f6a5
Merge branch 'master' into dev/uia-improvements
Kyaa-dost Oct 27, 2020
dcc8cfc
Update header
marcelwgn Oct 27, 2020
b67e3ce
Update automation peer to hide base members
marcelwgn Oct 27, 2020
b29ee78
Update test file again
marcelwgn Oct 27, 2020
5716df9
Update listener handling
marcelwgn Oct 28, 2020
3d79d7b
Merge branch 'master' into dev/uia-improvements
Kyaa-dost Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update listener handling
  • Loading branch information
@marcelwgn
marcelwgn committed Oct 28, 2020
commit 5716df913b0707f660bfbef82cac6bd0387c2093
5 changes: 3 additions & 2 deletions Microsoft.Toolkit.Uwp.UI.Controls/RadialGauge/RadialGauge.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,10 @@ protected override void OnValueChanged(double oldValue, double newValue)
{
OnValueChanged(this);
base.OnValueChanged(oldValue, newValue);
if (FrameworkElementAutomationPeer.CreatePeerForElement(this) is RadialGaugeAutomationPeer peer)
if (AutomationPeer.ListenerExists(AutomationEvents.LiveRegionChanged))
{
peer.RaiseValueChangedEvent(oldValue, newValue);
var peer = FrameworkElementAutomationPeer.FromElement(this) as RadialGaugeAutomationPeer;
peer?.RaiseValueChangedEvent(oldValue, newValue);
}
}

Expand Down