Skip to content

Conversation

@Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Apr 6, 2021

Fixes

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Apr 6, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from Kyaa-dost, azchohfi and michael-hawker April 6, 2021 19:35
@michael-hawker
Copy link
Member

Dependent on #3926

@XAML-Knight
Copy link
Contributor

Dependent on #3926

Looks like #3926 made it in. @RosarioPulella, is this PR ready for review?

@Rosuavio
Copy link
Contributor Author

Closing, this was a long time ago and I wont be able to update it. This work would be better off in a new PR.

@Rosuavio Rosuavio closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants