Skip to content

Conversation

@supermartzin
Copy link
Contributor

Fixes #3955

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Unit test added

What is the current behavior?

Issue #3955

What is the new behavior?

Text on Wide tile is correctly set without throwing NullReferenceException.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

…e only via TileContentBuilder

+ added appropriate unit test to cover this problem for all tile sizes
@ghost
Copy link

ghost commented Apr 24, 2021

Thanks supermartzin for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi and michael-hawker April 24, 2021 10:50
@net-foundation-cla
Copy link

net-foundation-cla bot commented Apr 24, 2021

CLA assistant check
All CLA requirements met.

@net-foundation-cla
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ supermartzin sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost ghost requested review from Kyaa-dost and Rosuavio April 24, 2021 10:51
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Apr 24, 2021
@Kyaa-dost Kyaa-dost modified the milestone: 7.1 Apr 26, 2021
@michael-hawker
Copy link
Member

Thanks @supermartzin! @andrewleader want to take a quick look?

Copy link
Contributor

@andrewleader andrewleader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @supermartzin!

@ghost
Copy link

ghost commented Apr 28, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added this to the 7.1 milestone Apr 28, 2021
@ghost ghost merged commit 8fb123f into CommunityToolkit:master Apr 28, 2021
@michael-hawker michael-hawker modified the milestones: 7.1, 7.0.2 May 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶 notifications 🔔

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TileContentBuilder - exception adding text on Wide tile

4 participants