-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fixed NRE when setting text on Wide tile only via TileContentBuilder #3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed NRE when setting text on Wide tile only via TileContentBuilder #3994
Conversation
…e only via TileContentBuilder + added appropriate unit test to cover this problem for all tile sizes
|
Thanks supermartzin for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
|
|
Thanks @supermartzin! @andrewleader want to take a quick look? |
andrewleader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you @supermartzin!
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes #3955
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue #3955
What is the new behavior?
Text on Wide tile is correctly set without throwing
NullReferenceException.PR Checklist
Please check if your PR fulfills the following requirements:
Other information