-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fixed ExpressionNode.EnsureReferenceInfo() crash with .NET Native #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ExpressionNode.EnsureReferenceInfo() crash with .NET Native #4014
Conversation
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
@vgromfeld want to try the PR package and confirm this resolves your issue? Thanks! |
|
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 53 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge when @vgromfeld approves |
|
Hello @michael-hawker! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
The fix is working on my side too. Thanks @Sergio0694 ! |
Closes #4011
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Crash with .NET Native, documented in the related issue.
What is the new behavior?
The logic has been changed to not rely on APIs that might have a behavioral change under .NET Native.
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates