Skip to content

Conversation

@Sergio0694
Copy link
Member

Closes #4011

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Crash with .NET Native, documented in the related issue.

What is the new behavior?

The logic has been changed to not rely on APIs that might have a behavioral change under .NET Native.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@ghost
Copy link

ghost commented May 4, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from Kyaa-dost, Rosuavio, azchohfi and michael-hawker May 4, 2021 22:36
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶 priority 🚩 labels May 4, 2021
@Sergio0694 Sergio0694 added animations 🏮 priority 🚩 and removed bug 🐛 An unexpected issue that highlights incorrect behavior priority 🚩 labels May 4, 2021
@michael-hawker
Copy link
Member

@vgromfeld want to try the PR package and confirm this resolves your issue? Thanks!

@ghost
Copy link

ghost commented May 5, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 53 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added this to the 7.1 milestone May 5, 2021
@michael-hawker
Copy link
Member

@msftbot merge when @vgromfeld approves

@ghost
Copy link

ghost commented May 5, 2021

Hello @michael-hawker!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @vgromfeld

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@vgromfeld
Copy link
Contributor

The fix is working on my side too. Thanks @Sergio0694 !

@ghost ghost merged commit 529624c into CommunityToolkit:main May 5, 2021
@michael-hawker michael-hawker modified the milestones: 7.1, 7.0.2 May 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidArgumentException raised by ExpressionNode in _release_ mode

3 participants