Skip to content

Fixed generated properties within regions #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 16, 2021
Merged

Fixed generated properties within regions #4227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf74cf
Fixed [ObservableProperty] within regions
Sergio0694 Sep 4, 2021
28bcbaf
Added test region in [ICommand] tests
Sergio0694 Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added test region in [ICommand] tests
  • Loading branch information
@Sergio0694
Sergio0694 committed Sep 4, 2021
commit 28bcbafa25a55d9e0b5629f5f78387b50b77009d
6 changes: 6 additions & 0 deletions UnitTests/UnitTests.NetCore/Mvvm/Test_ICommandAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
using Microsoft.Toolkit.Mvvm.Input;
using Microsoft.VisualStudio.TestTools.UnitTesting;

#pragma warning disable SA1124

namespace UnitTests.Mvvm
{
[SuppressMessage("StyleCop.CSharp.DocumentationRules", "SA1601", Justification = "Type only used for testing")]
Expand Down Expand Up @@ -78,6 +80,8 @@ private async Task DelayAndIncrementCounterAsync()
Counter += 1;
}

#region Test region

/// <summary>
/// This is multi line with also other stuff below
/// </summary>
Expand All @@ -100,6 +104,8 @@ private async Task DelayAndIncrementCounterWithValueAsync(int count)
Counter += count;
}

#endregion

[ICommand]
private async Task DelayAndIncrementCounterWithValueAndTokenAsync(int count, CancellationToken token)
{
Expand Down