Skip to content

Add more analyzers, enable unit tests for partial properties #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 14 commits into from
Dec 3, 2024
Merged

Add more analyzers, enable unit tests for partial properties #1010

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e094757
Skip generation for more invalid cases
Sergio0694 Nov 29, 2024
1b51b6c
Add 'TryGetConstructorArgument' extension
Sergio0694 Nov 29, 2024
da6527e
Add 'InvalidPartialPropertyLevelObservablePropertyAttributeAnalyzer'
Sergio0694 Nov 29, 2024
59a9f4a
Add more unit tests
Sergio0694 Nov 29, 2024
3d2a6a2
Minor formatting fixes to analyzers
Sergio0694 Nov 29, 2024
3717a6f
Add MVVM Toolkit test project for Roslyn 4.12
Sergio0694 Nov 29, 2024
29ae95d
Port '[ObservableProperty]' tests for partial properties
Sergio0694 Nov 29, 2024
9b508c5
Ignore broken test
Sergio0694 Nov 30, 2024
4020c03
Update global.json to .NET 9.0.100 SDK
Sergio0694 Nov 30, 2024
633f32e
Remove 'Span<T>' reference for NETFX test
Sergio0694 Nov 30, 2024
2f3c842
Fixup message for 'MVVMTK0052' diagnostic
Sergio0694 Nov 30, 2024
f080c60
Stop after first invalid property diagnostic
Sergio0694 Nov 30, 2024
aa9df8a
Fixed reporting for 'MVVMTK0052'
Sergio0694 Nov 30, 2024
889cc08
Fix consistency for 'new()' for diagnostics/suppressions
Sergio0694 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore broken test
  • Loading branch information
@Sergio0694
Sergio0694 committed Nov 30, 2024
commit 9b508c5699e16e5c9e748e49336261291eb9b4d2
1 change: 1 addition & 0 deletions ...ityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_SourceGeneratorsDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,7 @@ public partial string Name
}

[TestMethod]
[Ignore("The symbol callback is not being triggered correctly (see https://github.com/dotnet/roslyn/issues/76166)")]
public async Task InvalidPartialPropertyLevelObservablePropertyAttributeAnalyzer_OnImplementedProperty_GeneratedByAnotherGenerator_Warns()
{
const string source = """
Expand Down
Loading