Skip to content

Add code fixer for semi-auto property to '[ObservableProperty]' partial property #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 14 commits into from
Dec 11, 2024
Merged

Add code fixer for semi-auto property to '[ObservableProperty]' partial property #1020

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fc42924
Add 'UseObservablePropertyOnSemiAutoPropertyAnalyzer'
Sergio0694 Dec 10, 2024
7c6eeb6
Add unit tests for new analyzer
Sergio0694 Dec 10, 2024
162ae4f
Add 'UsePartialPropertyForSemiAutoPropertyCodeFixer'
Sergio0694 Dec 10, 2024
450fb9f
Add unit test for code fixer
Sergio0694 Dec 10, 2024
71aeda8
Fix failing test
Youssef1313 Dec 10, 2024
46cd488
Add more unit tests for code fixer
Sergio0694 Dec 10, 2024
5e3d65f
Improve handling of attribute lists, fix tests
Sergio0694 Dec 10, 2024
e348906
Only remove leading trivia, add tests
Sergio0694 Dec 10, 2024
da89014
Fix leading trivia in accessors, add tests
Sergio0694 Dec 10, 2024
df714ea
Add support for 'get;' accessors too
Sergio0694 Dec 11, 2024
a91e7a8
Handle adding using directives if needed
Sergio0694 Dec 11, 2024
76c41aa
Move MVVMTK0056 to 8.4.0 release
Sergio0694 Dec 11, 2024
a1bfe3d
Port 'ObjectPool<T>' type from Roslyn
Sergio0694 Dec 11, 2024
5766465
Enable pooling for objects in new analyzer
Sergio0694 Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit tests for new analyzer
  • Loading branch information
@Sergio0694
Sergio0694 committed Dec 11, 2024
commit 7c6eeb6f7fb07692fd343155029242cdf24f01f0
206 changes: 206 additions & 0 deletions ...ityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_SourceGeneratorsDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,4 +1243,210 @@ public unsafe partial class SampleViewModel : ObservableObject

await CSharpAnalyzerWithLanguageVersionTest<InvalidPointerTypeObservablePropertyAttributeAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_NormalProperty_DoesNotWarn()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public string Name { get; set; }
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_SimilarProperty_NotObservableObject_DoesNotWarn()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : MyBaseViewModel
{
public string Name
{
get => field;
set => SetProperty(ref field, value);
}
}

public abstract class MyBaseViewModel
{
protected void SetProperty<T>(ref T location, T value, string propertyName = null)
{
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_NoGetter_DoesNotWarn()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public string Name
{
set => SetProperty(ref field, value);
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_NoSetter_DoesNotWarn()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public string Name
{
get => field;
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_OtherLocation_DoesNotWarn()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public string Name
{
get => field;
set
{
string test = field;

SetProperty(ref test, value);
}
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_OtherValue_DoesNotWarn()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public string Name
{
get => field;
set
{
string test = "Bob";

SetProperty(ref field, test);
}
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_ValidProperty_Warns()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public string {|MVVMTK0056:Name|}
{
get => field;
set => SetProperty(ref field, value);
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_ValidProperty_WithModifiers_Warns()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public new string {|MVVMTK0056:Name|}
{
get => field;
private set => SetProperty(ref field, value);
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}

[TestMethod]
public async Task UseObservablePropertyOnSemiAutoPropertyAnalyzer_ValidProperty_WithBlocks_Warns()
{
const string source = """
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

public partial class SampleViewModel : ObservableObject
{
public new string {|MVVMTK0056:Name|}
{
get
{
return field;
}
private set
{
SetProperty(ref field, value);
}
}
}
""";

await CSharpAnalyzerWithLanguageVersionTest<UseObservablePropertyOnSemiAutoPropertyAnalyzer>.VerifyAnalyzerAsync(source, LanguageVersion.Preview);
}
}