Skip to content

Fix C# language version checks for [ObservableProperty] #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 11 commits into from
Nov 24, 2025
Merged

Fix C# language version checks for [ObservableProperty] #1140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8b54ba5
Add C# 14.0 support for ObservableProperty on partial properties
Sergio0694 Nov 11, 2025
c62a264
Add Roslyn5000 source generator project to solution
Sergio0694 Nov 11, 2025
55f39c2
Update Roslyn 5.0 support in source generators
Sergio0694 Nov 11, 2025
8f23f79
Update summary for DiagnosticsExtensions class
Sergio0694 Nov 11, 2025
6ae2439
Add Roslyn 5.0 source generator and code fixer support
Sergio0694 Nov 11, 2025
272a974
Update analyzer for C# 14.0 language version support
Sergio0694 Nov 11, 2025
3d97ed2
Add Roslyn 5.0.0 unit test project
Sergio0694 Nov 12, 2025
dffc56d
Add Roslyn5000 unit test project and fix project reference
Sergio0694 Nov 12, 2025
ea014da
Add C# 14 partial property tests and fix formatting
Sergio0694 Nov 12, 2025
ab4e3c2
Remove Roslyn 5.0.0 workaround and update test dependency
Sergio0694 Nov 24, 2025
27d43c1
Update C# language version to 14.0 in test project
Sergio0694 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Roslyn 5.0 support in source generators 
Refactored the Roslyn 5000 project to import shared props and projitems files. Added support for the ROSLYN_5_0_0_OR_GREATER constant, updated NoWarn conditions for RS2003, and introduced a temporary workaround for Roslyn 5.0.0 versioning in the props file.
  • Loading branch information
@Sergio0694
Sergio0694 committed Nov 24, 2025
commit 55f39c2d75b7613877f3e2ff8678c303d67a660d
7 changes: 3 additions & 4 deletions ...Mvvm.SourceGenerators.Roslyn5000/CommunityToolkit.Mvvm.SourceGenerators.Roslyn5000.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<Import Project="..\CommunityToolkit.Mvvm.SourceGenerators\CommunityToolkit.Mvvm.SourceGenerators.props" />
<Import Project="..\CommunityToolkit.Mvvm.SourceGenerators\CommunityToolkit.Mvvm.SourceGenerators.projitems" Label="Shared" />

</Project>
</Project>
6 changes: 5 additions & 1 deletion src/CommunityToolkit.Mvvm.SourceGenerators/CommunityToolkit.Mvvm.SourceGenerators.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@
<!-- Also define "ROSLYN_<MAJOR>_<MINOR>_OR_GREATER" build constants, so the generator code can multi-target whenever needed and add any required polyfills -->
<DefineConstants Condition="$([MSBuild]::VersionGreaterThanOrEquals($(MvvmToolkitSourceGeneratorRoslynVersion), 4.3.1))">$(DefineConstants);ROSLYN_4_3_1_OR_GREATER</DefineConstants>
<DefineConstants Condition="$([MSBuild]::VersionGreaterThanOrEquals($(MvvmToolkitSourceGeneratorRoslynVersion), 4.12.0))">$(DefineConstants);ROSLYN_4_12_0_OR_GREATER</DefineConstants>
<DefineConstants Condition="$([MSBuild]::VersionGreaterThanOrEquals($(MvvmToolkitSourceGeneratorRoslynVersion), 5.0.0))">$(DefineConstants);ROSLYN_5_0_0_OR_GREATER</DefineConstants>

<!-- Disable the removed rules analyzer for older Roslyn versions (as we might not support all diagnostics) -->
<NoWarn Condition="$([MSBuild]::VersionLessThan($(MvvmToolkitSourceGeneratorRoslynVersion), 4.12.0))">$(NoWarn);RS2003</NoWarn>
<NoWarn Condition="$([MSBuild]::VersionLessThan($(MvvmToolkitSourceGeneratorRoslynVersion), 5.0.0))">$(NoWarn);RS2003</NoWarn>

<!-- Temporary workaround before GA -->
<MvvmToolkitSourceGeneratorRoslynVersion Condition="$([MSBuild]::VersionEquals($(MvvmToolkitSourceGeneratorRoslynVersion), 5.0.0))">5.0.0-2.final</MvvmToolkitSourceGeneratorRoslynVersion>
</PropertyGroup>

<ItemGroup>
Expand Down