Skip to content

Conversation

@WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Sep 17, 2022

**Closes #148 **

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Add the NuGet package info and links, thanks for @Nirmal4G 's help

Preview: https://github.com/WeihanLi/dotnet-CommunityTookit/blob/readme-nuget-package-enhancement/README.md#-what-does-this-repo-contain

image

@Nirmal4G
Copy link
Contributor

@Sergio0694 @michael-hawker Also, the docs.microsoft.com has been changed to learn.microsoft.com. Do we need to update it here or in a separate PR?

Add link for `CommunityToolkit`

Co-authored-by: Nirmal Guru <[email protected]>
Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

@Sergio0694 Sergio0694 merged commit 1287507 into CommunityToolkit:main Sep 17, 2022
@WeihanLi WeihanLi deleted the readme-nuget-package-enhancement branch September 17, 2022 15:37
@Sergio0694
Copy link
Member

@Nirmal4G The docs have redirects, so we can update them later on if we want. We're using docs everywhere anyway 😄

@Nirmal4G
Copy link
Contributor

I was aware of that. I only discovered through this PR. Just notifying the project maintainers. That's all. 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add links to preview release NuGet packages

3 participants