Skip to content

Replace characters from StringBuilder to reduce string allocations #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 1 commit into from
Sep 20, 2022
Merged

Replace characters from StringBuilder to reduce string allocations #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CommunityToolkit.Mvvm.SourceGenerators/Extensions/INamedTypeSymbolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ ITypeSymbol ts when ts.ContainingType is ISymbol pt
// one to the outermost namespace, if any. Additionally, the ` and + symbols need to be replaced
// to avoid errors when generating code. This is a known issue with source generators not accepting
// those characters at the moment, see: https://github.com/dotnet/roslyn/issues/58476.
return BuildFrom(symbol, new StringBuilder(256)).ToString().Replace('`', '-').Replace('+', '.');
return BuildFrom(symbol, new StringBuilder(256)).Replace('`', '-').Replace('+', '.').ToString();
}

/// <summary>
Expand Down