Skip to content

More source generator optimizations #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sergio0694 merged 2 commits into from
Oct 29, 2022
Merged

More source generator optimizations #487

Sergio0694 merged 2 commits into from
Oct 29, 2022

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Oct 28, 2022

This PR includes some more generator optimizations:

  • Port ImmutableArrayBuilder<T> tweaks over from ComputeSharp
  • Make GetFullyQualifiedMetadataNameForFileName zero-alloc (except the string)

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • X ] Code follows all style conventions

@Sergio0694 Sergio0694 added next preview ✈️ This changes will be available in the upcoming preview optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Oct 28, 2022
@Sergio0694 Sergio0694 merged commit a0df371 into main Oct 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/generator-tweaks branch October 29, 2022 13:37
@dependabot dependabot bot mentioned this pull request Dec 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit next preview ✈️ This changes will be available in the upcoming preview optimization ☄ Performance or memory usage improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sergio0694