Remove nullability attributes generator #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the nullability attributes generator, which is a change long overdue. This generator was just there to keep the code simpler when generating transitive members (eg. from
[INotifyPropertyChanged]), but in hindsight pushing the extra complexity onto final users was not the right choice, as it resulted in somewhat unintuitive behavior. This is because users would find themselves with a couple of random polyfills for[NotNull]and[NotNullIfNotNull], which would not be expected and not really documented either, and also it could potentially conflict with other generators doing that explicitly.This PR removes the generator entirely, and just updates the code to strip those attributes during generation if not available. That is, if those attributes are not available, the code will simply be generated without using those attributes at all.
PR Checklist