Skip to content

Support partial methods and forwarded attributes with [RelayCommand] #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sergio0694 merged 5 commits into from
Mar 9, 2023
Merged

Support partial methods and forwarded attributes with [RelayCommand] #633

Sergio0694 merged 5 commits into from
Mar 9, 2023

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Mar 9, 2023

Closes #632

cc. @Youssef1313 if you have some spare time 😄

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit bugfix 🔧 PRs fixing a discovered bug labels Mar 9, 2023
@Sergio0694 Sergio0694 requested a review from Arlodotexe March 9, 2023 14:04
@Sergio0694 Sergio0694 force-pushed the dev/partial-commands branch from c1b5d73 to ada70a0 Compare March 9, 2023 14:38
@Sergio0694 Sergio0694 force-pushed the dev/partial-commands branch from ada70a0 to 66f582b Compare March 9, 2023 19:26
@Sergio0694 Sergio0694 merged commit 57d3de4 into main Mar 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the dev/partial-commands branch March 9, 2023 19:47
@dependabot dependabot bot mentioned this pull request Dec 11, 2025
Open
@dependabot dependabot bot mentioned this pull request Dec 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Awaiting requested review from Arlodotexe

1 more reviewer

@Youssef1313 Youssef1313 Youssef1313 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix 🔧 PRs fixing a discovered bug mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit

Projects

No open projects
8.2
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RelayCommand] does not work with partial methods

2 participants

@Sergio0694 @Youssef1313