Skip to content

Add warning when using packages.config for MVVM Toolkit #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 4 commits into from
May 14, 2023
Merged

Add warning when using packages.config for MVVM Toolkit #698

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1121201
Add warning when using packages.config for MVVM Toolkit
Sergio0694 May 14, 2023
9a671aa
Add error code and help link for .targets warnings
Sergio0694 May 14, 2023
14b7672
Manually look for a packages.config file in builds
Sergio0694 May 14, 2023
0071d6a
Skip checking for packages.config in SDK-style projects
Sergio0694 May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add warning when using packages.config for MVVM Toolkit
  • Loading branch information
@Sergio0694
Sergio0694 committed May 14, 2023
commit 1121201a36c1bc8d657bd57a2b44923f4e92580c
13 changes: 13 additions & 0 deletions src/CommunityToolkit.Mvvm/CommunityToolkit.Mvvm.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,17 @@
</ItemGroup>
</Target>

<!-- Remove the analyzer if packages.config is used -->
<Target Name="MVVMToolkitWarnForPackagesConfigUse"
AfterTargets="ResolvePackageDependenciesForBuild;ResolveNuGetPackageAssets"
DependsOnTargets="MVVMToolkitGatherAnalyzers">

<!--
Emit a warning in case packages.config is used, by reading the associated MSBuild property.
This happens when either the project style is using packages.config, or when explicitly requested.
See https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#restoring-packagereference-and-packagesconfig-projects-with-msbuild.
-->
<Warning Condition ="'$(RestorePackagesConfig)' == 'true' OR '$(RestoreProjectStyle)' == 'PackagesConfig'" Text="The MVVM Toolkit source generators might not be loaded correctly, as the current project is using the packages.config setup to restore NuGet packages. Source generators require PackageReference to be used (either in a legacy-style or SDK-style .csproj project, both are supported as long as PackageReference is used)."/>
</Target>

</Project>