-
Notifications
You must be signed in to change notification settings - Fork 363
Add new analyzer/fixer for async void [RelayCommand] methods #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5e8096f
Add AsyncVoidReturningRelayCommandMethodAnalyzer
Sergio0694 8e88f30
Add unit test for new async void analyzer
Sergio0694 328d172
Add AsyncVoidReturningRelayCommandMethodCodeFixer
Sergio0694 ce23265
Add AsyncVoidReturningRelayCommandMethodCodeFixer tests
Sergio0694 c6eedee
Avoid passing properties to async void [RelayCommand] fixer
Sergio0694 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add AsyncVoidReturningRelayCommandMethodCodeFixer tests
- Loading branch information
commit ce23265ddc49303e5f9f45f5383c9860f33d81b5
There are no files selected for viewing
113 changes: 113 additions & 0 deletions
113
...ourceGenerators.Roslyn401.UnitTests/Test_AsyncVoidReturningRelayCommandMethodCodeFixer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.Threading.Tasks; | ||
| using CommunityToolkit.Mvvm.Input; | ||
| using Microsoft.CodeAnalysis.Testing; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
| using CSharpCodeFixTest = Microsoft.CodeAnalysis.CSharp.Testing.CSharpCodeFixTest< | ||
| CommunityToolkit.Mvvm.SourceGenerators.AsyncVoidReturningRelayCommandMethodAnalyzer, | ||
| CommunityToolkit.Mvvm.CodeFixers.AsyncVoidReturningRelayCommandMethodCodeFixer, | ||
| Microsoft.CodeAnalysis.Testing.Verifiers.MSTestVerifier>; | ||
| using CSharpCodeFixVerifier = Microsoft.CodeAnalysis.CSharp.Testing.CSharpCodeFixVerifier< | ||
| CommunityToolkit.Mvvm.SourceGenerators.AsyncVoidReturningRelayCommandMethodAnalyzer, | ||
| CommunityToolkit.Mvvm.CodeFixers.AsyncVoidReturningRelayCommandMethodCodeFixer, | ||
| Microsoft.CodeAnalysis.Testing.Verifiers.MSTestVerifier>; | ||
|
|
||
| namespace CommunityToolkit.Mvvm.SourceGenerators.Roslyn401.UnitTests; | ||
|
|
||
| [TestClass] | ||
| public class Test_AsyncVoidReturningRelayCommandMethodCodeFixer | ||
| { | ||
| [TestMethod] | ||
| public async Task AsyncVoidMethod_FileContainsSystemThreadingTasksUsingDirective() | ||
| { | ||
| string original = """ | ||
| using System.Threading.Tasks; | ||
| using CommunityToolkit.Mvvm.Input; | ||
|
|
||
| partial class C | ||
| { | ||
| [RelayCommand] | ||
| private async void Foo() | ||
| { | ||
| } | ||
| } | ||
| """; | ||
|
|
||
| string @fixed = """ | ||
| using System.Threading.Tasks; | ||
| using CommunityToolkit.Mvvm.Input; | ||
|
|
||
| partial class C | ||
| { | ||
| [RelayCommand] | ||
| private async Task Foo() | ||
| { | ||
| } | ||
| } | ||
| """; | ||
|
|
||
| CSharpCodeFixTest test = new() | ||
| { | ||
| TestCode = original, | ||
| FixedCode = @fixed, | ||
| ReferenceAssemblies = ReferenceAssemblies.Net.Net60 | ||
| }; | ||
|
|
||
| test.TestState.AdditionalReferences.Add(typeof(RelayCommand).Assembly); | ||
| test.ExpectedDiagnostics.AddRange(new[] | ||
| { | ||
| // /0/Test0.cs(7,24): error MVVMTK0039: The method C.Foo() annotated with [RelayCommand] is async void (make sure to return a Task type instead) | ||
| CSharpCodeFixVerifier.Diagnostic().WithSpan(7, 24, 7, 27).WithArguments("C.Foo()") | ||
| }); | ||
|
|
||
| await test.RunAsync(); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public async Task AsyncVoidMethod_FileDoesNotContainSystemThreadingTasksUsingDirective() | ||
| { | ||
| string original = """ | ||
| using CommunityToolkit.Mvvm.Input; | ||
|
|
||
| partial class C | ||
| { | ||
| [RelayCommand] | ||
| private async void Foo() | ||
| { | ||
| } | ||
| } | ||
| """; | ||
|
|
||
| string @fixed = """ | ||
| using System.Threading.Tasks; | ||
Sergio0694 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| using CommunityToolkit.Mvvm.Input; | ||
|
|
||
| partial class C | ||
| { | ||
| [RelayCommand] | ||
| private async Task Foo() | ||
| { | ||
| } | ||
| } | ||
| """; | ||
|
|
||
| CSharpCodeFixTest test = new() | ||
| { | ||
| TestCode = original, | ||
| FixedCode = @fixed, | ||
| ReferenceAssemblies = ReferenceAssemblies.Net.Net60 | ||
| }; | ||
|
|
||
| test.TestState.AdditionalReferences.Add(typeof(RelayCommand).Assembly); | ||
| test.ExpectedDiagnostics.AddRange(new[] | ||
| { | ||
| // /0/Test0.cs(7,24): error MVVMTK0039: The method C.Foo() annotated with [RelayCommand] is async void (make sure to return a Task type instead) | ||
| CSharpCodeFixVerifier.Diagnostic().WithSpan(6, 24, 6, 27).WithArguments("C.Foo()") | ||
| }); | ||
|
|
||
| await test.RunAsync(); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.