Skip to content

Add MVVM Toolkit analyzers for WinRT scenarios #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 10 commits into from
Nov 8, 2024
Merged

Add MVVM Toolkit analyzers for WinRT scenarios #979

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1599d68
Add 'CommunityToolkit.Mvvm.Windows.targets'
Sergio0694 Nov 7, 2024
24064de
Add 'WinRTObservablePropertyOnFieldsIsNotAotCompatibleAnalyzer'
Sergio0694 Nov 7, 2024
729e96c
Add 'WinRTRelayCommandIsNotGeneratedBindablePropertyProviderCompatibl…
Sergio0694 Nov 7, 2024
374b2d0
Use 'GetMSBuildBooleanPropertyValue' in more places
Sergio0694 Nov 7, 2024
e2c33e7
Add 'WinRTGeneratedBindableCustomPropertyWithBasesMemberAnalyzer'
Sergio0694 Nov 7, 2024
171ba41
Tweaks to the '[ObservableProperty]' code fixer
Sergio0694 Nov 7, 2024
f74269b
Fix formatting in '[ObservableProperty]' diagnostics
Sergio0694 Nov 8, 2024
c6ca94d
Minor code refactoring to internal extensions
Sergio0694 Nov 8, 2024
7ba700e
Fix some analyzer bugs
Sergio0694 Nov 8, 2024
ec0a331
Add unit tests for all WinRT analyzers
Sergio0694 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add 'CommunityToolkit.Mvvm.Windows.targets'
  • Loading branch information
@Sergio0694
Sergio0694 committed Nov 7, 2024
commit 1599d68b9b1fc42bed88931c47aa0f29acd352a4
17 changes: 17 additions & 0 deletions src/CommunityToolkit.Mvvm/CommunityToolkit.Mvvm.Windows.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<Project>

<!-- Allows the generators and analyzers to determine whether the current project is targeting Windows on modern .NET -->
<PropertyGroup>
<_MvvmToolkitIsUsingWindowsRuntimePack>false</_MvvmToolkitIsUsingWindowsRuntimePack>
<_MvvmToolkitIsUsingWindowsRuntimePack Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0-windows10.0.17763.0'))">true</_MvvmToolkitIsUsingWindowsRuntimePack>
</PropertyGroup>

<!-- MSBuild properties that generators and analyzers need access to -->
<ItemGroup>
<CompilerVisibleProperty Include="_MvvmToolkitIsUsingWindowsRuntimePack" />
<CompilerVisibleProperty Include="CsWinRTComponent" />
<CompilerVisibleProperty Include="CsWinRTAotOptimizerEnabled" />
<CompilerVisibleProperty Include="CsWinRTAotWarningLevel" />
</ItemGroup>

</Project>
2 changes: 2 additions & 0 deletions src/CommunityToolkit.Mvvm/CommunityToolkit.Mvvm.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,12 @@
<!-- Include the custom .targets files (shared across TFMs) -->
<None Include="CommunityToolkit.Mvvm.FeatureSwitches.targets" PackagePath="build" Pack="true" />
<None Include="CommunityToolkit.Mvvm.SourceGenerators.targets" PackagePath="build" Pack="true" />
<None Include="CommunityToolkit.Mvvm.Windows.targets" PackagePath="build" Pack="true" />
<None Include="CommunityToolkit.Mvvm.WindowsSdk.targets" PackagePath="build" Pack="true" />
<None Include="CommunityToolkit.Mvvm.targets" PackagePath="build" Pack="true" />
<None Include="CommunityToolkit.Mvvm.FeatureSwitches.targets" PackagePath="buildTransitive" Pack="true" />
<None Include="CommunityToolkit.Mvvm.SourceGenerators.targets" PackagePath="buildTransitive" Pack="true" />
<None Include="CommunityToolkit.Mvvm.Windows.targets" PackagePath="buildTransitive" Pack="true" />
<None Include="CommunityToolkit.Mvvm.WindowsSdk.targets" PackagePath="buildTransitive" Pack="true" />
<None Include="CommunityToolkit.Mvvm.targets" PackagePath="buildTransitive" Pack="true" />

Expand Down
2 changes: 2 additions & 0 deletions src/CommunityToolkit.Mvvm/CommunityToolkit.Mvvm.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@
<PropertyGroup>
<_CommunityToolkitMvvmFeatureSwitchesTargets>$(MSBuildThisFileDirectory)CommunityToolkit.Mvvm.FeatureSwitches.targets</_CommunityToolkitMvvmFeatureSwitchesTargets>
<_CommunityToolkitMvvmSourceGeneratorsTargets>$(MSBuildThisFileDirectory)CommunityToolkit.Mvvm.SourceGenerators.targets</_CommunityToolkitMvvmSourceGeneratorsTargets>
<_CommunityToolkitMvvmWindowsTargets>$(MSBuildThisFileDirectory)CommunityToolkit.Mvvm.Windows.targets</_CommunityToolkitMvvmWindowsTargets>
<_CommunityToolkitMvvmWindowsSdkTargets>$(MSBuildThisFileDirectory)CommunityToolkit.Mvvm.WindowsSdk.targets</_CommunityToolkitMvvmWindowsSdkTargets>
</PropertyGroup>

<!-- Import all available .targets -->
<Import Project="$(_CommunityToolkitMvvmFeatureSwitchesTargets)" />
<Import Project="$(_CommunityToolkitMvvmSourceGeneratorsTargets)" />
<Import Project="$(_CommunityToolkitMvvmWindowsTargets)" />
<Import Project="$(_CommunityToolkitMvvmWindowsSdkTargets)" />

</Project>