Skip to content

Add more WinRT analyzers for class-level attributes #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sergio0694 merged 3 commits into from
Nov 9, 2024
Merged

Add more WinRT analyzers for class-level attributes #981

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16deedf
Add 'WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer'
Sergio0694 Nov 8, 2024
a74423d
Run WinRT '[RelayCommand]' tests for all Roslyn-s
Sergio0694 Nov 9, 2024
ae66c28
Add unit tests for new WinRT analyzer
Sergio0694 Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add unit tests for new WinRT analyzer
  • Loading branch information
@Sergio0694
Sergio0694 committed Nov 9, 2024
commit ae66c28c6c223f822a37677b9dda39bf90115655
142 changes: 142 additions & 0 deletions tests/CommunityToolkit.Mvvm.SourceGenerators.UnitTests/Test_SourceGeneratorsDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,6 +2084,148 @@ await CSharpAnalyzerWithLanguageVersionTest<WinRTRelayCommandIsNotGeneratedBinda
editorconfig: [("_MvvmToolkitIsUsingWindowsRuntimePack", true)]);
}

[TestMethod]
public async Task WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer_NotTargetingWindows_DoesNotWarn()
{
const string source = """
using System;
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

[ObservableObject]
public partial class SampleViewModel : BaseType
{
}

public class BaseType
{
}
""";

await CSharpAnalyzerWithLanguageVersionTest<WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer>.VerifyAnalyzerAsync(
source,
LanguageVersion.CSharp10,
editorconfig: []);
}

[TestMethod]
public async Task WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer_TargetingWindows_NoCsWinRTAotOptimizer_DoesNotWarn()
{
const string source = """
using System;
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

[ObservableObject]
public partial class SampleViewModel : BaseType
{
}

public class BaseType
{
}
""";

await CSharpAnalyzerWithLanguageVersionTest<WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer>.VerifyAnalyzerAsync(
source,
LanguageVersion.CSharp10,
editorconfig: [("_MvvmToolkitIsUsingWindowsRuntimePack", true)]);
}

[TestMethod]
public async Task WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer_TargetingWindows_NoBaseType_ObservableObject_DoesNotWarn()
{
const string source = """
using System;
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

[ObservableObject]
public partial class SampleViewModel
{
}
""";

await CSharpAnalyzerWithLanguageVersionTest<WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer>.VerifyAnalyzerAsync(
source,
LanguageVersion.CSharp10,
editorconfig: [("_MvvmToolkitIsUsingWindowsRuntimePack", true), ("CsWinRTAotOptimizerEnabled", "auto")]);
}

[TestMethod]
public async Task WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer_TargetingWindows_NoBaseType_INotifyPropertyChanged_DoesNotWarn()
{
const string source = """
using System;
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

[INotifyPropertyChanged]
public partial class SampleViewModel
{
}
""";

await CSharpAnalyzerWithLanguageVersionTest<WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer>.VerifyAnalyzerAsync(
source,
LanguageVersion.CSharp10,
editorconfig: [("_MvvmToolkitIsUsingWindowsRuntimePack", true), ("CsWinRTAotOptimizerEnabled", "auto")]);
}

[TestMethod]
public async Task WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer_TargetingWindows_BaseType_ObservableObject_Warns()
{
const string source = """
using System;
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

[ObservableObject]
public partial class {|MVVMTK0050:SampleViewModel|} : BaseType
{
}

public class BaseType
{
}
""";

await CSharpAnalyzerWithLanguageVersionTest<WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer>.VerifyAnalyzerAsync(
source,
LanguageVersion.CSharp10,
editorconfig: [("_MvvmToolkitIsUsingWindowsRuntimePack", true), ("CsWinRTAotOptimizerEnabled", "auto")]);
}

[TestMethod]
public async Task WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer_TargetingWindows_BaseType_INotifyPropertyChanged_Warns()
{
const string source = """
using System;
using CommunityToolkit.Mvvm.ComponentModel;

namespace MyApp;

[INotifyPropertyChanged]
public partial class {|MVVMTK0049:SampleViewModel|} : BaseType
{
}

public class BaseType
{
}
""";

await CSharpAnalyzerWithLanguageVersionTest<WinRTClassUsingNotifyPropertyChangedAttributesAnalyzer>.VerifyAnalyzerAsync(
source,
LanguageVersion.CSharp10,
editorconfig: [("_MvvmToolkitIsUsingWindowsRuntimePack", true), ("CsWinRTAotOptimizerEnabled", "auto")]);
}

/// <summary>
/// Verifies the diagnostic errors for a given analyzer, and that all available source generators can run successfully with the input source (including subsequent compilation).
/// </summary>
Expand Down