Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Mar 24, 2022

Signed-off-by: Dzmitry Lahoda [email protected]

  • make benches parts of tests
  • fixes liqudatin interface
  • document sometings
  • made binary and typed call to liqudation

@dzmitry-lahoda dzmitry-lahoda changed the title xcmp liqudation CU-1wzgvc6 sample of cross chain transaction for SELL (DEX/liqudation) Mar 24, 2022
Signed-off-by: Dzmitry Lahoda <[email protected]>
@vivekvpandya vivekvpandya requested review from vivekvpandya and removed request for vivekvpandya March 25, 2022 08:55
Signed-off-by: Dzmitry Lahoda <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #815 (e78dd55) into main (73ac560) will decrease coverage by 0.26%.
The diff coverage is 95.71%.

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   70.83%   70.57%   -0.27%     
==========================================
  Files         187      203      +16     
  Lines       28773    29961    +1188     
==========================================
+ Hits        20382    21144     +762     
- Misses       8391     8817     +426     
Impacted Files Coverage Δ
frame/bonded-finance/src/lib.rs 45.08% <0.00%> (-0.47%) ⬇️
frame/dutch-auction/src/mock/runtime.rs 100.00% <ø> (+6.81%) ⬆️
frame/dutch-auction/src/weights.rs 25.00% <ø> (ø)
frame/lending/src/mocks/mod.rs 47.20% <ø> (-9.60%) ⬇️
frame/liquidations/src/benchmarking.rs 100.00% <ø> (ø)
frame/liquidations/src/mock/runtime.rs 76.47% <ø> (-17.65%) ⬇️
frame/oracle/src/lib.rs 57.77% <ø> (ø)
...tegration-tests/local-integration-tests/src/lib.rs 100.00% <ø> (ø)
...on-tests/local-integration-tests/src/relaychain.rs 100.00% <ø> (ø)
runtime/dali/src/lib.rs 24.66% <ø> (+3.52%) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ac560...e78dd55. Read the comment docs.

Signed-off-by: Dzmitry Lahoda <[email protected]>
@dzmitry-lahoda dzmitry-lahoda merged commit 4e4b2b4 into main Mar 30, 2022
@dzmitry-lahoda dzmitry-lahoda deleted the dz/xcmp-sell-tx branch March 30, 2022 10:47
ysfkel pushed a commit that referenced this pull request Apr 6, 2022
#815)

* xcmp liqudation

Signed-off-by: Dzmitry Lahoda <[email protected]>

* fixed review comments

Signed-off-by: Dzmitry Lahoda <[email protected]>

* fixing review

Signed-off-by: Dzmitry Lahoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants