This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix:slow tests sometimes timeout #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjpaterno
approved these changes
Jan 17, 2020
Contributor
nicholasjpaterno
left a comment
nicholasjpaterno
left a comment
There was a problem hiding this comment.
LGTM! (where the exclamation mark means not 😂 )
✔️
I'm adding a todo to follow up with web3 about this issue.
| @@ -1,3 +1,4 @@ | |||
| const memdown = require("memdown"); | |||
| await send("evm_mine"); | ||
| // web3 doesn't subscribe fast enough to newHeads after issuing the previous send | ||
| // we we mine another block to give it an additional newHeads notification. /shrug | ||
| await send("evm_mine"); |
davidmurdoch
changed the title
1 task
This was referenced Jun 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.