This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: handle failure to retrieve net_version when forking
#676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
approved these changes
Jan 12, 2021
davidmurdoch
changed the title
net_version when forkingnet_version when forking
v-stickykeys
pushed a commit
to xGodMode/godmode-ganache-core
that referenced
this pull request
Feb 13, 2021
v-stickykeys
pushed a commit
to xGodMode/godmode-ganache-core
that referenced
this pull request
Feb 13, 2021
1 task
This was referenced Jun 6, 2021
This was referenced Jun 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When forking against a local full node, some clients will reject
net_versionRPC requests, such as turbo-geth. In this case, if thenetworkIdparam was set - use it instead.