This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(ethereum): ensure randomBytes can return 0-255 #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it returned only bytes 0 - 254.
Contributor
|
Do note this may change the behavior of |
Contributor
Author
BREAK ALL THE THINGS! |
Contributor
Author
Ah, wait... crap. While this function doesn't matter for the start up accounts... there is another function that does have the same bug, even in version 2, and that WILL change things. hmmmmm |
davidmurdoch
commented
Feb 12, 2021
mikeseese
approved these changes
Feb 12, 2021
sambacha
pushed a commit
to contractshark/ganache-core
that referenced
this pull request
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it returned only bytes 0 - 254.