This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: rearchitect server status and move async functions from constructors to initialize functions #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
changed the title
This was referenced Mar 26, 2021
mikeseese
added a commit
that referenced
this pull request
Mar 26, 2021
davidmurdoch
suggested changes
Mar 29, 2021
davidmurdoch
suggested changes
Mar 30, 2021
mikeseese
added a commit
that referenced
this pull request
Mar 30, 2021
davidmurdoch
approved these changes
Mar 30, 2021
mikeseese
changed the title
mikeseese
added a commit
that referenced
this pull request
Mar 30, 2021
mikeseese
added a commit
that referenced
this pull request
Mar 30, 2021
mikeseese
added a commit
that referenced
this pull request
Mar 30, 2021
…nc-init implement #877 async init changes for the filecoin flavor
sambacha
pushed a commit
to contractshark/ganache-core
that referenced
this pull request
Apr 14, 2021
* chore: point community link at our discord channel (ConsenSys-archive#874) * chore(deps): bump y18n from 4.0.0 to 4.0.1 (ConsenSys-archive#884) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: rearchitect server status and move async functions from constructors to initialize functions (ConsenSys-archive#877) * feat: add filecoin flavor (ConsenSys-archive#888) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]> * fix: support a uws fallback if uws native binaries don't exist (win+electron) (ConsenSys-archive#893) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Seese <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]>
sambacha
pushed a commit
to contractshark/ganache-core
that referenced
this pull request
Apr 15, 2021
* chore: point community link at our discord channel (ConsenSys-archive#874) * chore(deps): bump y18n from 4.0.0 to 4.0.1 (ConsenSys-archive#884) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: rearchitect server status and move async functions from constructors to initialize functions (ConsenSys-archive#877) * feat: add filecoin flavor (ConsenSys-archive#888) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]> * fix: support a uws fallback if uws native binaries don't exist (win+electron) (ConsenSys-archive#893) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Seese <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was driven by having an issue incorporating Ganache v7 into Ganache UI. If there was an error before the
Server.statuswas set toopening, but the constructors started async operations (i.e. opening the database), then things would get locked without the ability to be closed properly duringServer.close()So this PR does a couple of things:
Statusenum to be more accurate and appropriateinitializefunctions so that we can guarantee that we can appropriately close things when things failGanache.provider()to become asynchronous by nature. It always "was" and the work around was to use an event emitter to say when things were ready. This may get modified to go back to the old way (while still keeping the other benefits added in this PR) to maintain back-compatibility. However that decision is still waiting on feedback from the rest of the team. This PR won't get merged until the final direction has been decided and implemented in this PR. In the meantime, the other parts can be reviewed.